Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/lsp/safetoken: TestGoplsSourceDoesNotCallTokenFileMethods failures #58749

Closed
gopherbot opened this issue Feb 27, 2023 · 2 comments
Closed

x/tools/gopls/internal/lsp/safetoken: TestGoplsSourceDoesNotCallTokenFileMethods failures #58749

gopherbot opened this issue Feb 27, 2023 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/safetoken" && test == "TestGoplsSourceDoesNotCallTokenFileMethods"

Issue created automatically to collect these failures.

Example (log):

SIGQUIT: quit
PC=0x133ca m=0 sigcode=0

r0   0x4d0e60	r1   0x119
r2   0x1	r3   0x22bd50
r4   0xc0000d7e20	r5   0x1000004
r6   0x0	r7   0x0
r8   0x4d0e60	r9   0x1
r10  0x0	r11  0xc0000b44c0
r12  0xc0000a0180	r13  0xc000082680
...
	/data/golang/workdir/gopath/src/golang.org/x/tools/go/packages/golist.go:454 +0xc8 fp=0xc000143930 sp=0xc000142f08 pc=0x298198
golang.org/x/tools/go/packages.goListDriver(0xc0000aa008, {0xc0000a8000, 0x2, 0x2})
	/data/golang/workdir/gopath/src/golang.org/x/tools/go/packages/golist.go:200 +0x99a fp=0xc000143b48 sp=0xc000143930 pc=0x29567a
golang.org/x/tools/go/packages.defaultDriver(0xc0000aa008, {0xc0000a8000, 0x2, 0x2})
	/data/golang/workdir/gopath/src/golang.org/x/tools/go/packages/packages.go:278 +0x6c fp=0xc000143b88 sp=0xc000143b48 pc=0x2a590c
golang.org/x/tools/go/packages.Load(0xc00008dda8, {0xc0000a8000, 0x2, 0x2})
	/data/golang/workdir/gopath/src/golang.org/x/tools/go/packages/packages.go:261 +0x6e fp=0xc000143bd0 sp=0xc000143b88 pc=0x2a57ae
golang.org/x/tools/gopls/internal/lsp/safetoken_test.TestGoplsSourceDoesNotCallTokenFileMethods(0xc000003d40)
	/data/golang/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/safetoken/safetoken_test.go:76 +0xa4 fp=0xc000143f60 sp=0xc000143bd0 pc=0x2af1f4
testing.tRunner(0xc000003d40, 0x32b0d0)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 27, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/safetoken" && test == "TestGoplsSourceDoesNotCallTokenFileMethods"
2023-02-25 00:08 linux-s390x-ibm tools@f98fce20 go@af6bb3f9 x/tools/gopls/internal/lsp/safetoken.TestGoplsSourceDoesNotCallTokenFileMethods (log) 
SIGQUIT: quit
PC=0x133ca m=0 sigcode=0

r0   0x4d0e60	r1   0x119
r2   0x1	r3   0x22bd50
r4   0xc0000d7e20	r5   0x1000004
r6   0x0	r7   0x0
r8   0x4d0e60	r9   0x1
r10  0x0	r11  0xc0000b44c0
r12  0xc0000a0180	r13  0xc000082680
...
	/data/golang/workdir/gopath/src/golang.org/x/tools/go/packages/golist.go:454 +0xc8 fp=0xc000143930 sp=0xc000142f08 pc=0x298198
golang.org/x/tools/go/packages.goListDriver(0xc0000aa008, {0xc0000a8000, 0x2, 0x2})
	/data/golang/workdir/gopath/src/golang.org/x/tools/go/packages/golist.go:200 +0x99a fp=0xc000143b48 sp=0xc000143930 pc=0x29567a
golang.org/x/tools/go/packages.defaultDriver(0xc0000aa008, {0xc0000a8000, 0x2, 0x2})
	/data/golang/workdir/gopath/src/golang.org/x/tools/go/packages/packages.go:278 +0x6c fp=0xc000143b88 sp=0xc000143b48 pc=0x2a590c
golang.org/x/tools/go/packages.Load(0xc00008dda8, {0xc0000a8000, 0x2, 0x2})
	/data/golang/workdir/gopath/src/golang.org/x/tools/go/packages/packages.go:261 +0x6e fp=0xc000143bd0 sp=0xc000143b88 pc=0x2a57ae
golang.org/x/tools/gopls/internal/lsp/safetoken_test.TestGoplsSourceDoesNotCallTokenFileMethods(0xc000003d40)
	/data/golang/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/safetoken/safetoken_test.go:76 +0xa4 fp=0xc000143f60 sp=0xc000143bd0 pc=0x2af1f4
testing.tRunner(0xc000003d40, 0x32b0d0)

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 27, 2023
@gopherbot gopherbot added this to the Unreleased milestone Feb 27, 2023
@bcmills bcmills mentioned this issue Feb 27, 2023
Closed
@findleyr
Copy link
Contributor

findleyr commented Mar 1, 2023

s390x again. Transient issues.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Mar 1, 2023
@golang golang locked and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@gopherbot @findleyr