Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/lsp: TestLSP failures #58702

Closed
gopherbot opened this issue Feb 24, 2023 · 20 comments
Closed

x/tools/gopls/internal/lsp: TestLSP failures #58702

gopherbot opened this issue Feb 24, 2023 · 20 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.12.0

Comments

@gopherbot
Copy link

gopherbot commented Feb 24, 2023 •
edited by bcmills 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp" && test == "TestLSP" && date < "2023-06-01"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestLSP (397.43s)
    --- FAIL: TestLSP/MultiModule (112.62s)
        --- FAIL: TestLSP/MultiModule/Completion (80.97s)
            --- FAIL: TestLSP/MultiModule/Completion/func_rank_31_19_0 (78.35s)
                completion_test.go:31: mismatching completion items (-want +got):
                      []protocol.CompletionItem(
                    - 	{
                    - 		{
                    - 			Label:         "AA",
                    - 			Kind:          5,
...
                    - 			Kind:          5,
                    - 			Detail:        "string",
                    - 			Documentation: &protocol.Or_CompletionItem_documentation{Value: string("")},
                    - 			SortText:      "-0",
                    - 			InsertText:    "AB",
                    - 			TextEdit:      &protocol.TextEdit{},
                    - 		},
                    - 	},
                    + 	nil,
                      )

— watchflakes
@gopherbot gopherbot added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 24, 2023
@gopherbot gopherbot added this to the Unreleased milestone Feb 24, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp" && test == "TestLSP"
2023-02-16 17:09 windows-amd64-race tools@a30296b4 go@518889b3 x/tools/gopls/internal/lsp.TestLSP (log) 
--- FAIL: TestLSP (397.43s)
    --- FAIL: TestLSP/MultiModule (112.62s)
        --- FAIL: TestLSP/MultiModule/Completion (80.97s)
            --- FAIL: TestLSP/MultiModule/Completion/func_rank_31_19_0 (78.35s)
                completion_test.go:31: mismatching completion items (-want +got):
                      []protocol.CompletionItem(
                    - 	{
                    - 		{
                    - 			Label:         "AA",
                    - 			Kind:          5,
...
                    - 			Kind:          5,
                    - 			Detail:        "string",
                    - 			Documentation: &protocol.Or_CompletionItem_documentation{Value: string("")},
                    - 			SortText:      "-0",
                    - 			InsertText:    "AB",
                    - 			TextEdit:      &protocol.TextEdit{},
                    - 		},
                    - 	},
                    + 	nil,
                      )
2023-02-17 19:56 windows-amd64-race tools@193023cc go@81eda3a3 x/tools/gopls/internal/lsp.TestLSP (log) 
--- FAIL: TestLSP (272.75s)
    --- FAIL: TestLSP/MultiModule (115.62s)
        --- FAIL: TestLSP/MultiModule/Completion (77.92s)
            --- FAIL: TestLSP/MultiModule/Completion/func_rank_26_12_0 (74.41s)
                completion_test.go:31: mismatching completion items (-want +got):
                      []protocol.CompletionItem(
                    - 	{
                    - 		{
                    - 			Label:         "AA",
                    - 			Kind:          5,
...
                    - 			Kind:          5,
                    - 			Detail:        "string",
                    - 			Documentation: &protocol.Or_CompletionItem_documentation{Value: string("")},
                    - 			SortText:      "-0",
                    - 			InsertText:    "AB",
                    - 			TextEdit:      &protocol.TextEdit{},
                    - 		},
                    - 	},
                    + 	nil,
                      )

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp" && test == "TestLSP"
2023-02-25 00:08 linux-s390x-ibm tools@f98fce20 go@af6bb3f9 x/tools/gopls/internal/lsp.TestLSP (log) 
SIGQUIT: quit
PC=0x97768 m=0 sigcode=0

r0   0x0	r1   0xee
r2   0x11e84e8	r3   0x80
r4   0x0	r5   0x0
r6   0x0	r7   0x0
r8   0x703d619ebf0dc	r9   0x7
r10  0x0	r11  0x80
r12  0x1	r13  0x11e79a0
r14  0x50412	r15  0x3fffb47eab8
pc   0x97768	link 0x50412
*** Test killed with quit: ran too long (11m0s).

runtime.gopark(0xc1c058, 0xc0000407c8, 0xe, 0x17, 0x2)
	/data/golang/workdir/go/src/runtime/proc.go:381 +0x136 fp=0xc00007cd40 sp=0xc00007cd28 pc=0x588f6
runtime.chanrecv(0xc000040770, 0xc00007ce2f, 0x1)
	/data/golang/workdir/go/src/runtime/chan.go:583 +0x5a6 fp=0xc00007cdb8 sp=0xc00007cd40 pc=0x186f6
runtime.chanrecv1(0xc000040770, 0xc00007ce2f)
	/data/golang/workdir/go/src/runtime/chan.go:442 +0x2e fp=0xc00007cde0 sp=0xc00007cdb8 pc=0x180ee
testing.(*T).Run(0xc0002ce820, {0xac696a, 0x7}, 0xc00027e4b0)
	/data/golang/workdir/go/src/testing/testing.go:1633 +0x4c4 fp=0xc00007ce98 sp=0xc00007cde0 pc=0x17d614
golang.org/x/tools/gopls/internal/lsp/tests.RunTests(0xc0002ce820, {0xaca858, 0x8}, 0x1, 0xc1b428)
	/data/golang/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/tests/tests.go:297 +0x15e fp=0xc00007cf30 sp=0xc00007ce98 pc=0x8ba97e
golang.org/x/tools/gopls/internal/lsp.TestLSP(0xc0002ce820)
	/data/golang/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/lsp_test.go:51 +0x4c fp=0xc00007cf60 sp=0xc00007cf30 pc=0x90841c
testing.tRunner(0xc0002ce820, 0xc1b408)

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp" && test == "TestLSP"
2023-02-27 20:01 windows-amd64-race tools@b0fcf2a0 go@e8fbad5d x/tools/gopls/internal/lsp.TestLSP (log) 
--- FAIL: TestLSP (256.72s)
    --- FAIL: TestLSP/MultiModule (106.95s)
        --- FAIL: TestLSP/MultiModule/Completion (62.19s)
            --- FAIL: TestLSP/MultiModule/Completion/literal_snippets_139_21_0 (60.16s)
                completion_test.go:31: mismatching completion items (-want +got):
                      []protocol.CompletionItem(
                    - 	{
                    - 		{
                    - 			Label:         "func(...) {}",
                    - 			Kind:          6,
                    - 			Documentation: &protocol.Or_CompletionItem_documentation{Value: string("")},
                    - 			SortText:      "-0",
                    - 			InsertText:    "func(...) {}",
                    - 			TextEdit:      &protocol.TextEdit{},
                    - 		},
                    - 	},
                    + 	nil,
                      )

— watchflakes

@findleyr
Copy link
Contributor

findleyr commented Mar 1, 2023

Both of these builders have issues (the windows one is likely #58714, though it's hard to be sure since we're missing logs in output).

In any case, closing this as unactionable.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Mar 1, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp" && test == "TestLSP"
2023-03-01 16:36 windows-amd64-race tools@096bae8f go@4eb3aea2 x/tools/gopls/internal/lsp.TestLSP (log) 
--- FAIL: TestLSP (215.30s)
    --- FAIL: TestLSP/MultiModule (91.82s)
        --- FAIL: TestLSP/MultiModule/Completion (64.39s)
            --- FAIL: TestLSP/MultiModule/Completion/func_rank_23_16_0 (62.59s)
                completion_test.go:31: mismatching completion items (-want +got):
                      []protocol.CompletionItem(
                    - 	{
                    - 		{
                    - 			Label:         "AB",
                    - 			Kind:          5,
...
                    - 			Kind:          5,
                    - 			Detail:        "int",
                    - 			Documentation: &protocol.Or_CompletionItem_documentation{Value: string("")},
                    - 			SortText:      "-0",
                    - 			InsertText:    "AC",
                    - 			TextEdit:      &protocol.TextEdit{},
                    - 		},
                    - 	},
                    + 	nil,
                      )

— watchflakes

@gopherbot gopherbot reopened this Mar 6, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp" && test == "TestLSP"
2023-03-06 18:12 windows-amd64-race tools@c91d0b88 go@dbdb3359 x/tools/gopls/internal/lsp.TestLSP (log) 
--- FAIL: TestLSP (417.46s)
    --- FAIL: TestLSP/GOPATH (300.11s)
        --- FAIL: TestLSP/GOPATH/Completion (109.45s)
            --- FAIL: TestLSP/GOPATH/Completion/func_rank_22_11_0 (105.44s)
                completion_test.go:31: mismatching completion items (-want +got):
                      []protocol.CompletionItem(
                    - 	{
                    - 		{
                    - 			Label:         "AB",
                    - 			Kind:          5,
...
                    - 			Kind:          5,
                    - 			Detail:        "int",
                    - 			Documentation: &protocol.Or_CompletionItem_documentation{Value: string("")},
                    - 			SortText:      "-0",
                    - 			InsertText:    "AC",
                    - 			TextEdit:      &protocol.TextEdit{},
                    - 		},
                    - 	},
                    + 	nil,
                      )

— watchflakes

@bcmills

This comment was marked as outdated.

Sign in to view
@bcmills bcmills marked this as a duplicate of #58714 Mar 6, 2023
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Mar 6, 2023
@bcmills bcmills marked this as not a duplicate of #58714 Mar 6, 2023
@bcmills
Copy link
Contributor

bcmills commented Mar 6, 2023

Actually, looking at the last failure log, there isn't nearly enough information in the log to diagnose the problem — all of the gopls logs seem to be completely missing.

That part, at least, seems actionable: we can improve the test's output enough for the watchflakes rules for other issues to successfully diagnose it.

@bcmills bcmills reopened this Mar 6, 2023
@bcmills bcmills added the Testing An issue that has been verified to require only test changes, not just a test failure. label Mar 6, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp" && test == "TestLSP"
2023-03-07 18:17 windows-amd64-race tools@75c657b1 go@74a9d283 x/tools/gopls/internal/lsp.TestLSP (log) 
--- FAIL: TestLSP (287.64s)
    --- FAIL: TestLSP/GOPATH (174.99s)
        --- FAIL: TestLSP/GOPATH/Completion (98.83s)
            --- FAIL: TestLSP/GOPATH/Completion/func_rank_29_24_0 (96.72s)
                completion_test.go:31: mismatching completion items (-want +got):
                      []protocol.CompletionItem{
                      	Inverse(NormalizeAny, protocol.CompletionItem{Label: "AA", Kind: 5, Detail: "int", ...}),
                    - 	{
                    - 		Label:         "AB",
                    - 		Kind:          5,
                    - 		Detail:        "string",
                    - 		Documentation: &protocol.Or_CompletionItem_documentation{Value: string("")},
                    - 		SortText:      "-0",
                    - 		InsertText:    "AB",
                    - 		TextEdit:      &protocol.TextEdit{},
                    - 	},
                    - 	{
                    - 		Label:         "AC",
                    - 		Kind:          5,
                    - 		Detail:        "int",
                    - 		Documentation: &protocol.Or_CompletionItem_documentation{Value: string("")},
                    - 		SortText:      "-0",
                    - 		InsertText:    "AC",
                    - 		TextEdit:      &protocol.TextEdit{},
                    - 	},
                      }

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp" && test == "TestLSP"
2023-03-07 18:17 windows-amd64-race tools@75c657b1 go@73ca5c0d x/tools/gopls/internal/lsp.TestLSP (log) 
panic: test timed out after 20m0s
running tests:
	TestLSP (20m4s)
	TestLSP/GOPATH (18m27s)
	TestLSP/GOPATH/Implementation (14m22s)
	TestLSP/GOPATH/Implementation/other_generics_14_6 (14m22s)

testing.(*T).Run(0xc0002841a0, {0x140ea3d5d, 0x6}, 0xc00b33ea20)
	C:/workdir/go/src/testing/testing.go:1633 +0x865
golang.org/x/tools/gopls/internal/lsp/tests.RunTests(0xc0002841a0, {0x140ea9ee7, 0x8}, 0x1, 0x140ffb670)
	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/tests/tests.go:297 +0x16b
golang.org/x/tools/gopls/internal/lsp.TestLSP(0x0?)
	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/lsp_test.go:51 +0x3f
testing.tRunner(0xc0002841a0, 0x140ffb650)

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp" && test == "TestLSP"
2023-03-08 01:14 windows-amd64-race tools@dd1e2f66 go@f5c74165 x/tools/gopls/internal/lsp.TestLSP (log) 
panic: test timed out after 20m0s
running tests:
	TestLSP (20m4s)
	TestLSP/GOPATH (18m28s)
	TestLSP/GOPATH/Implementation (15m49s)
	TestLSP/GOPATH/Implementation/implementation_19_6 (15m49s)

testing.(*T).Run(0xc00027eea0, {0x140ea2c9d, 0x6}, 0xc023d633b0)
	C:/workdir/go/src/testing/testing.go:1633 +0x865
golang.org/x/tools/gopls/internal/lsp/tests.RunTests(0xc00027eea0, {0x140ea8e27, 0x8}, 0x1, 0x140ffa588)
	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/tests/tests.go:297 +0x16b
golang.org/x/tools/gopls/internal/lsp.TestLSP(0x0?)
	C:/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/lsp_test.go:51 +0x3f
testing.tRunner(0xc00027eea0, 0x140ffa568)

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp" && test == "TestLSP"
2023-03-08 01:14 windows-amd64-race tools@dd1e2f66 go@b561ebab x/tools/gopls/internal/lsp.TestLSP (log) 
--- FAIL: TestLSP (555.10s)
    --- FAIL: TestLSP/GOPATH (437.22s)
        --- FAIL: TestLSP/GOPATH/Completion (76.06s)
            --- FAIL: TestLSP/GOPATH/Completion/func_rank_29_24_0 (72.40s)
                completion_test.go:31: mismatching completion items (-want +got):
                      []protocol.CompletionItem{
                      	Inverse(NormalizeAny, protocol.CompletionItem{Label: "AA", Kind: 5, Detail: "int", ...}),
                    - 	{
                    - 		Label:         "AB",
                    - 		Kind:          5,
                    - 		Detail:        "string",
                    - 		Documentation: &protocol.Or_CompletionItem_documentation{Value: string("")},
                    - 		SortText:      "-0",
                    - 		InsertText:    "AB",
                    - 		TextEdit:      &protocol.TextEdit{},
                    - 	},
                    - 	{
                    - 		Label:         "AC",
                    - 		Kind:          5,
                    - 		Detail:        "int",
                    - 		Documentation: &protocol.Or_CompletionItem_documentation{Value: string("")},
                    - 		SortText:      "-0",
                    - 		InsertText:    "AC",
                    - 		TextEdit:      &protocol.TextEdit{},
                    - 	},
                      }

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp" && test == "TestLSP"
2023-03-13 18:43 windows-amd64-race tools@ae907a4e go@90dde5de x/tools/gopls/internal/lsp.TestLSP (log) 
--- FAIL: TestLSP (290.57s)
    --- FAIL: TestLSP/GOPATH (156.51s)
        --- FAIL: TestLSP/GOPATH/Completion (118.91s)
            --- FAIL: TestLSP/GOPATH/Completion/func_rank_32_20_0 (115.22s)
                completion_test.go:31: mismatching completion items (-want +got):
                      []protocol.CompletionItem(
                    - 	{
                    - 		{
                    - 			Label:         "AA",
                    - 			Kind:          5,
...
                    - 			Kind:          5,
                    - 			Detail:        "string",
                    - 			Documentation: &protocol.Or_CompletionItem_documentation{Value: string("")},
                    - 			SortText:      "-0",
                    - 			InsertText:    "AB",
                    - 			TextEdit:      &protocol.TextEdit{},
                    - 		},
                    - 	},
                    + 	nil,
                      )

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp" && test == "TestLSP"
2023-03-13 18:43 windows-amd64-race tools@243a9484 go@035db07d x/tools/gopls/internal/lsp.TestLSP (log) 
--- FAIL: TestLSP (250.50s)
    --- FAIL: TestLSP/GOPATH (139.65s)
        --- FAIL: TestLSP/GOPATH/Completion (106.61s)
            --- FAIL: TestLSP/GOPATH/Completion/func_rank_26_12_0 (101.73s)
                completion_test.go:31: mismatching completion items (-want +got):
                      []protocol.CompletionItem{
                      	Inverse(NormalizeAny, protocol.CompletionItem{Label: "AA", Kind: 5, Detail: "int", ...}),
                    - 	{
                    - 		Label:         "AC",
                    - 		Kind:          5,
                    - 		Detail:        "int",
                    - 		Documentation: &protocol.Or_CompletionItem_documentation{Value: string("")},
                    - 		SortText:      "-0",
                    - 		InsertText:    "AC",
                    - 		TextEdit:      &protocol.TextEdit{},
                    - 	},
                    - 	{
                    - 		Label:         "AB",
                    - 		Kind:          5,
                    - 		Detail:        "string",
                    - 		Documentation: &protocol.Or_CompletionItem_documentation{Value: string("")},
                    - 		SortText:      "-0",
                    - 		InsertText:    "AB",
                    - 		TextEdit:      &protocol.TextEdit{},
                    - 	},
                      }

— watchflakes

@findleyr
Copy link
Contributor

findleyr commented Apr 6, 2023 •
edited

These new failures look like timeouts.

The internal/lsp tests should be fast -- they take ~9s on my laptop. Yet on the windows race builder, they are taking 200-1200s! This suggests to me that the new gopls architecture (perhaps the filecache) is significantly less performant on Windows.

CC @adonovan

@findleyr findleyr modified the milestones: Unreleased, gopls/v0.12.0 Apr 6, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp" && test == "TestLSP"
2023-04-20 16:14 illumos-amd64 tools@240a4dcd go@0d699b6c x/tools/gopls/internal/lsp.TestLSP (log) 
panic: test timed out after 10m0s
running tests:
	TestLSP (10m0s)
	TestLSP/MultiModule (15s)
	TestLSP/MultiModule/CallHierarchy (3s)
	TestLSP/MultiModule/CallHierarchy/callhierarchy_29_6 (3s)

testing.(*T).Run(0xc0002d9860, {0xd78eec?, 0xbc2d60?}, 0xc005500de0)
	/var/tmp/workdir-host-illumos-amd64-jclulow/go/src/testing/testing.go:1649 +0x3c8
golang.org/x/tools/gopls/internal/lsp/tests.RunTests(0xc0002d9860, {0xd72117, 0x8}, 0x1, 0xec6c10)
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/tests/tests.go:284 +0x12a
golang.org/x/tools/gopls/internal/lsp.TestLSP(0xc0002d9520?)
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/lsp_test.go:42 +0x2b
testing.tRunner(0xc0002d9860, 0xec6bf0)
2023-04-20 20:04 illumos-amd64 tools@9c9e11f3 go@15c12762 x/tools/gopls/internal/lsp.TestLSP (log) 
SIGQUIT: quit (ASCII FS)
PC=0xfffffc7fef1f8087 m=25 sigcode=0

rax    0x5b
rbx    0xfffffc7feebaba40
rcx    0xfffffc7feed5c180
rdx    0x0
rdi    0x0
rsi    0x0
rbp    0xfffffc7fa13ffd98
...
	/var/tmp/workdir-host-illumos-amd64-jclulow/go/src/runtime/chan.go:583 +0x3cd fp=0xc00006ddb8 sp=0xc00006dd40 pc=0x4072ed
runtime.chanrecv1(0x14bdd60?, 0xc39660?)
	/var/tmp/workdir-host-illumos-amd64-jclulow/go/src/runtime/chan.go:442 +0x12 fp=0xc00006dde0 sp=0xc00006ddb8 pc=0x406ef2
testing.(*T).Run(0xc0002d51e0, {0xd6e5b5?, 0xbc3580?}, 0xc0002dc510)
	/var/tmp/workdir-host-illumos-amd64-jclulow/go/src/testing/testing.go:1649 +0x3c8 fp=0xc00006dea0 sp=0xc00006dde0 pc=0x527ae8
golang.org/x/tools/gopls/internal/lsp/tests.RunTests(0xc0002d51e0, {0xd7217f, 0x8}, 0x1, 0xec6c50)
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/tests/tests.go:284 +0x12a fp=0xc00006df38 sp=0xc00006dea0 pc=0xb6aeea
golang.org/x/tools/gopls/internal/lsp.TestLSP(0xc0002d4ea0?)
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/lsp_test.go:42 +0x2b fp=0xc00006df70 sp=0xc00006df38 pc=0xbb4f4b
testing.tRunner(0xc0002d51e0, 0xec6c30)
2023-04-20 20:04 illumos-amd64 tools@9c9e11f3 go@ecf7e00d x/tools/gopls/internal/lsp.TestLSP (log) 
panic: test timed out after 10m0s
running tests:
	TestLSP (10m53s)
	TestLSP/Modules (10m53s)
	TestLSP/Modules/Completion (3m38s)
	TestLSP/Modules/Completion/imported_complit_11_14_0 (3m38s)

testing.(*T).Run(0xc000292b60, {0xdb9878?, 0xc12700?}, 0xc00028c120)
	/var/tmp/workdir-host-illumos-amd64-jclulow/go/src/testing/testing.go:1630 +0x405
golang.org/x/tools/gopls/internal/lsp/tests.RunTests(0xc000292b60, {0xdbd464, 0x8}, 0x1, 0xf10fd8)
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/tests/tests.go:284 +0x139
golang.org/x/tools/gopls/internal/lsp.TestLSP(0xc000292820?)
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/lsp_test.go:42 +0x31
testing.tRunner(0xc000292b60, 0xf10fb8)
2023-04-20 20:04 illumos-amd64 tools@9c9e11f3 go@bdccb85f x/tools/gopls/internal/lsp.TestLSP (log) 
panic: test timed out after 10m0s
running tests:
	TestLSP (10m0s)
	TestLSP/Modules (10m0s)
	TestLSP/Modules/CallHierarchy (9m55s)
	TestLSP/Modules/CallHierarchy/callhierarchy_29_6 (9m55s)

testing.(*T).Run(0xc000292b60, {0xd6e5b5?, 0xbc3480?}, 0xc00028c120)
	/var/tmp/workdir-host-illumos-amd64-jclulow/go/src/testing/testing.go:1649 +0x3c8
golang.org/x/tools/gopls/internal/lsp/tests.RunTests(0xc000292b60, {0xd7217f, 0x8}, 0x1, 0xec6c50)
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/tests/tests.go:284 +0x12a
golang.org/x/tools/gopls/internal/lsp.TestLSP(0xc000292820?)
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/lsp_test.go:42 +0x2b
testing.tRunner(0xc000292b60, 0xec6c30)

— watchflakes

@findleyr
Copy link
Contributor

findleyr commented May 3, 2023

Illumos failures look like #59950.

@findleyr
Copy link
Contributor

findleyr commented May 3, 2023

Interesting that the timeouts have not reoccurred on Windows. Need to greplogs to confirm, but perhaps we improved performance sufficiently that this is no longer a problem.

Note that the completion timeout is 1m

@findleyr
Copy link
Contributor

findleyr commented May 3, 2023

Yes, looks like this stopped in mid-march, around the same time as we made many optimizations.

Closing this as fixed.

@findleyr findleyr closed this as completed May 3, 2023
@gopherbot gopherbot reopened this Jun 30, 2023
@gopherbot

This comment was marked as off-topic.

Sign in to view
@bcmills bcmills closed this as completed Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
gopls/v0.12.0
Development

No branches or pull requests
3 participants
@bcmills @gopherbot @findleyr