Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: reimplement unimported completion #58663

Closed
findleyr opened this issue Feb 23, 2023 · 1 comment
Closed

x/tools/gopls: reimplement unimported completion #58663

findleyr opened this issue Feb 23, 2023 · 1 comment
Labels
FrozenDueToAge gopls/completion Issues related to auto-completion in gopls. gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.12.0

Comments

@findleyr
Copy link
Contributor

Tracking issue.

With gopls' new incremental execution (#57987), we can no longer look up unimported completions in cached packages.

Similar limitations applied to other operations (references, implementations, call-hierarchy, etc), but we addressed those before implementing incremental execution for gopls. This issue tracks re-implementing unimported completions to not depend on global package data.

CC @adonovan
@findleyr findleyr added the gopls/completion Issues related to auto-completion in gopls. label Feb 23, 2023
@findleyr findleyr added this to the gopls/v0.12.0 milestone Feb 23, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 23, 2023
@gopherbot
Copy link

Change https://go.dev/cl/472183 mentions this issue: gopls/internal/lsp/source/completion: avoid Snapshot.CachedPackages

@golang golang locked and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls/completion Issues related to auto-completion in gopls. gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.12.0
Development

No branches or pull requests
2 participants
@gopherbot @findleyr