cmd/link: linker fails on linux/amd64 when gcc's lto options are used #58619

jcajka · 2023-02-21T11:41:34Z

What version of Go are you using (`go version`)?

$ go version
go version devel go1.21-7f59bea53c Tue Feb 21 05:09:21 2023 +0000 linux/amd64

Does this issue reproduce with the latest release?

yes, seems to be reproducible at least as far back as go1.18

What operating system and processor architecture are you using (`go env`)?

go env Output

GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/root/.cache/go-build"
GOENV="/root/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/root/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/root/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="devel go1.21-7f59bea53c Tue Feb 21 05:09:21 2023 +0000"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/loki/go.mod"
GOWORK=""
CGO_CFLAGS="-O2 -g"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-O2 -g"
CGO_FFLAGS="-O2 -g"
CGO_LDFLAGS="-O2 -g"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build3131861800=/tmp/go-build -gno-record-gcc-switches"

This is with gcc-13.0.1, binutils-2.40 and glibc-2.37

What did you do?

git clone https://github.com/grafana/loki
cd loki
export CGO_CFLAGS='-O2 -flto=auto -ffat-lto-objects'
go build -o logcli ./cmd/logcli

What did you expect to see?

Build finishing successfully or more clear error message being displayed.

What did you see instead?

go build -o logcli ./cmd/logcli
# github.com/grafana/loki/cmd/logcli
net(.text): relocation target malloc not defined
net(.text): relocation target __errno_location not defined
net(.text): relocation target getnameinfo not defined
net(.text): relocation target __errno_location not defined
net(.text): relocation target getaddrinfo not defined
net(.text): relocation target free not defined
net(.text): relocation target freeaddrinfo not defined
net(.text): relocation target gai_strerror not defined
net(.text): relocation target __errno_location not defined
net(.text): relocation target res_search not defined
runtime/cgo(.text): relocation target stderr not defined
runtime/cgo(.text): relocation target fwrite not defined
runtime/cgo(.text): relocation target vfprintf not defined
runtime/cgo(.text): relocation target fputc not defined
runtime/cgo(.text): relocation target abort not defined
runtime/cgo(.text): relocation target pthread_mutex_lock not defined
runtime/cgo(.text): relocation target pthread_cond_wait not defined
runtime/cgo(.text): relocation target pthread_mutex_unlock not defined
runtime/cgo(.text): relocation target pthread_cond_broadcast not defined
runtime/cgo(.text): relocation target pthread_create not defined
runtime/cgo(.text): relocation target nanosleep not defined
/go/pkg/tool/linux_amd64/link: too many errors

The text was updated successfully, but these errors were encountered:

thanm · 2023-02-21T15:47:42Z

@golang/compiler

thanm · 2023-02-21T15:49:39Z

Similar to #58620, we're doing CGO internal linking (due to use of CGO in "net" and related packages), and the linker's host object loader is getting confused by the non-standard objects.

gopherbot · 2023-02-22T19:31:12Z

Change https://go.dev/cl/470298 mentions this issue: cmd/link: default to external linking with cgo std packages

gopherbot · 2023-02-23T20:27:42Z

Change https://go.dev/cl/470835 mentions this issue: Revert "cmd/link: default to external linking with cgo std packages"

This reverts CL 470298. Reason for revert: causes issues with Google internal testing. Updates #58619. Updates #58620. Change-Id: Ic6601820ba8758ef96b71e32d9ffc549c36d5c98 Reviewed-on: https://go-review.googlesource.com/c/go/+/470835 Reviewed-by: Russ Cox <rsc@golang.org> TryBot-Result: Gopher Robot <gobot@golang.org> Run-TryBot: Than McIntosh <thanm@google.com> Reviewed-by: Than McIntosh <thanm@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com>

gopherbot · 2023-02-24T14:13:37Z

Change https://go.dev/cl/471055 mentions this issue: cmd/go: request external linking for all CGO use

gopherbot · 2023-03-10T16:35:08Z

Change https://go.dev/cl/475375 mentions this issue: cmd/go,cmd/link: prefer external linking when strange cgo flags seen

This patch changes the Go command to examine the set of compiler flags feeding into the C compiler when packages that use cgo are built. If any of a specific set of strange/dangerous flags are in use, then the Go command generates a token file ("preferlinkext") and embeds it into the compiled package's archive. When the Go linker reads the archives of the packages feeding into the link and detects a "preferlinkext" token, it will then use external linking for the program by default (although this default can be overridden with an explicit "-linkmode" flag). The intent here is to avoid having to teach the Go linker's host object reader to grok/understand the various odd symbols/sections/types that can result from boutique flag use, but rather to just boot the objects in question over to the C linker instead. Updates #58619. Updates #58620. Updates #58848. Change-Id: I56382dd305de8dac3841a7a7e664277826061eaa Reviewed-on: https://go-review.googlesource.com/c/go/+/475375 Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Bryan Mills <bcmills@google.com> Run-TryBot: Than McIntosh <thanm@google.com> TryBot-Result: Gopher Robot <gobot@golang.org>

thanm · 2023-03-14T14:16:49Z

This issue should now be resolved by CL 475375, submitted this morning. Thanks.

thanm · 2023-03-15T14:49:56Z

@gopherbot please open backport issues

gopherbot · 2023-03-15T14:50:07Z

Backport issue(s) opened: #59050 (for 1.19), #59051 (for 1.20).

Remember to create the cherry-pick CL(s) as soon as the patch is submitted to master, according to https://go.dev/wiki/MinorReleases.

gopherbot · 2023-03-15T18:16:45Z

Change https://go.dev/cl/476576 mentions this issue: cmd/go,cmd/link: prefer external linking when strange cgo flags seen

gopherbot · 2023-03-15T18:30:09Z

Change https://go.dev/cl/476577 mentions this issue: cmd/go,cmd/link: prefer external linking when strange cgo flags seen

… strange cgo flags seen This patch changes the Go command to examine the set of compiler flags feeding into the C compiler when packages that use cgo are built. If any of a specific set of strange/dangerous flags are in use, then the Go command generates a token file ("preferlinkext") and embeds it into the compiled package's archive. When the Go linker reads the archives of the packages feeding into the link and detects a "preferlinkext" token, it will then use external linking for the program by default (although this default can be overridden with an explicit "-linkmode" flag). The intent here is to avoid having to teach the Go linker's host object reader to grok/understand the various odd symbols/sections/types that can result from boutique flag use, but rather to just boot the objects in question over to the C linker instead. Fixes #59051. Updates #58619. Updates #58620. Updates #58848. Change-Id: I56382dd305de8dac3841a7a7e664277826061eaa Reviewed-on: https://go-review.googlesource.com/c/go/+/475375 Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Bryan Mills <bcmills@google.com> Run-TryBot: Than McIntosh <thanm@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> (cherry picked from commit 035db07) Reviewed-on: https://go-review.googlesource.com/c/go/+/476577

… strange cgo flags seen This patch changes the Go command to examine the set of compiler flags feeding into the C compiler when packages that use cgo are built. If any of a specific set of strange/dangerous flags are in use, then the Go command generates a token file ("preferlinkext") and embeds it into the compiled package's archive. When the Go linker reads the archives of the packages feeding into the link and detects a "preferlinkext" token, it will then use external linking for the program by default (although this default can be overridden with an explicit "-linkmode" flag). The intent here is to avoid having to teach the Go linker's host object reader to grok/understand the various odd symbols/sections/types that can result from boutique flag use, but rather to just boot the objects in question over to the C linker instead. Fixes #59050. Updates #58619. Updates #58620. Updates #58848. Change-Id: I56382dd305de8dac3841a7a7e664277826061eaa Reviewed-on: https://go-review.googlesource.com/c/go/+/475375 Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Bryan Mills <bcmills@google.com> Run-TryBot: Than McIntosh <thanm@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> (cherry picked from commit 035db07) Reviewed-on: https://go-review.googlesource.com/c/go/+/476576

gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Feb 21, 2023

thanm added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 21, 2023

thanm mentioned this issue Feb 21, 2023

Go compiler and runtime meeting notes #43930

Open

gopherbot closed this as completed in 06b6759 Feb 22, 2023

dmitshur reopened this Feb 28, 2023

dmitshur added this to the Go1.21 milestone Feb 28, 2023

thanm mentioned this issue Mar 6, 2023

cmd/link: coverage analysis fail when using CGO & LLVM/clang 12 #58848

Closed

thanm closed this as completed Mar 14, 2023

This was referenced Mar 15, 2023

cmd/link: linker fails on linux/amd64 when gcc's lto options are used [1.19 backport] #59050

Closed

cmd/link: linker fails on linux/amd64 when gcc's lto options are used [1.20 backport] #59051

Closed

dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Mar 15, 2023

thanm added the GoCommand cmd/go label Mar 15, 2023

fastcat mentioned this issue Aug 15, 2023

cmd/nm: TestCgoLib fails if CGO_CFLAGS contains unrecognized flags (tool nm can't process .a file) #62036

Closed

golang locked and limited conversation to collaborators Mar 14, 2024

gopherbot added the FrozenDueToAge label Mar 14, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

cmd/link: linker fails on linux/amd64 when gcc's lto options are used #58619

cmd/link: linker fails on linux/amd64 when gcc's lto options are used #58619

jcajka commented Feb 21, 2023

thanm commented Feb 21, 2023

thanm commented Feb 21, 2023

gopherbot commented Feb 22, 2023

gopherbot commented Feb 23, 2023

gopherbot commented Feb 24, 2023

gopherbot commented Mar 10, 2023

thanm commented Mar 14, 2023

thanm commented Mar 15, 2023

gopherbot commented Mar 15, 2023

gopherbot commented Mar 15, 2023

gopherbot commented Mar 15, 2023

cmd/link: linker fails on linux/amd64 when gcc's lto options are used #58619

cmd/link: linker fails on linux/amd64 when gcc's lto options are used #58619

Comments

jcajka commented Feb 21, 2023

What version of Go are you using (go version)?

Does this issue reproduce with the latest release?

What operating system and processor architecture are you using (go env)?

What did you do?

What did you expect to see?

What did you see instead?

thanm commented Feb 21, 2023

thanm commented Feb 21, 2023

gopherbot commented Feb 22, 2023

gopherbot commented Feb 23, 2023

gopherbot commented Feb 24, 2023

gopherbot commented Mar 10, 2023

thanm commented Mar 14, 2023

thanm commented Mar 15, 2023

gopherbot commented Mar 15, 2023

gopherbot commented Mar 15, 2023

gopherbot commented Mar 15, 2023

What version of Go are you using (`go version`)?

What operating system and processor architecture are you using (`go env`)?