Skip to content

cmd/api: add API checks for FreeBSD arm64 and riscv64 ports #58582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dmgk opened this issue Feb 17, 2023 · 2 comments
Closed

cmd/api: add API checks for FreeBSD arm64 and riscv64 ports #58582

dmgk opened this issue Feb 17, 2023 · 2 comments
Assignees
@dmgk
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-FreeBSD
Milestone
Go1.21

Comments

@dmgk
Copy link
Member

dmgk commented Feb 17, 2023

FreeBSD arm64 port was added in go1.14 and riscv64 in go1.20. It would be helpful to make cmd/api aware of these ports.
@dmgk dmgk self-assigned this Feb 17, 2023
@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 17, 2023
@bcmills bcmills added this to the Backlog milestone Feb 17, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/469115 mentions this issue: cmd/api: add API checks for freebsd/arm64

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/469135 mentions this issue: cmd/api: add API checks for freebsd/riscv64

gopherbot pushed a commit that referenced this issue Feb 17, 2023
@dmgk @gopherbot
cmd/api: add API checks for freebsd/arm64

Verified

This commit was signed with the committer’s verified signature.
xhit Santiago De la Cruz
GPG key ID: 40A6C44C770472AF
Verified
Learn about vigilant mode
990501e 
The freebsd/arm64 port was added in go1.14, make cmd/api aware of it and
backfill API files.

For #58582

Change-Id: I8b25c6cf5a66611d90d225762b257679a4abface
Reviewed-on: https://go-review.googlesource.com/c/go/+/469115
Reviewed-by: Bryan Mills <bcmills@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Dmitri Goutnik <dgoutnik@gmail.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopherbot pushed a commit that referenced this issue Feb 17, 2023
@dmgk @gopherbot
cmd/api: add API checks for freebsd/riscv64
209df38 
The freebsd/riscv64 port was added in go1.20, make cmd/api aware of it and
backfill API files.

For #58582

Change-Id: I242b161cdb6221c8f60a1868c6435be26fca0078
Reviewed-on: https://go-review.googlesource.com/c/go/+/469135
Run-TryBot: Dmitri Goutnik <dgoutnik@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
@dmgk dmgk closed this as completed Feb 18, 2023
johanbrandhorst pushed a commit to Pryz/go that referenced this issue Feb 22, 2023
@dmgk @johanbrandhorst
cmd/api: add API checks for freebsd/arm64
734cbc2 
The freebsd/arm64 port was added in go1.14, make cmd/api aware of it and
backfill API files.

For golang#58582

Change-Id: I8b25c6cf5a66611d90d225762b257679a4abface
Reviewed-on: https://go-review.googlesource.com/c/go/+/469115
Reviewed-by: Bryan Mills <bcmills@google.com>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Dmitri Goutnik <dgoutnik@gmail.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
johanbrandhorst pushed a commit to Pryz/go that referenced this issue Feb 22, 2023
@dmgk @johanbrandhorst
cmd/api: add API checks for freebsd/riscv64
ed1bfb1 
The freebsd/riscv64 port was added in go1.20, make cmd/api aware of it and
backfill API files.

For golang#58582

Change-Id: I242b161cdb6221c8f60a1868c6435be26fca0078
Reviewed-on: https://go-review.googlesource.com/c/go/+/469135
Run-TryBot: Dmitri Goutnik <dgoutnik@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Ian Lance Taylor <iant@google.com>
Run-TryBot: Ian Lance Taylor <iant@google.com>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
@dmitshur dmitshur modified the milestones: Backlog, Go1.21 Apr 27, 2023
@golang golang locked and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dmgk dmgk

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-FreeBSD
Projects
None yet
Milestone
Go1.21
Development

No branches or pull requests
4 participants
@dmitshur @bcmills @dmgk @gopherbot