Skip to content

x/benchmarks: clean up low-signal benchmarks #58534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mknyszek opened this issue Feb 14, 2023 · 2 comments
Closed

x/benchmarks: clean up low-signal benchmarks #58534

mknyszek opened this issue Feb 14, 2023 · 2 comments
Assignees
@mknyszek
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Performance Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Unreleased

Comments

@mknyszek
Copy link
Contributor

mknyszek commented Feb 14, 2023 •
edited
Loading

We have quite a few benchmarks I would consider as providing us very little useful signal that we still run anyway. For example, there are a few bent benchmarks that flail wildly with innocuous commits (supposedly they're sensitive to code movement, or so the theory goes). Other benchmarks are broken on various platforms, but these also don't provide us much signal, like #58533.

I propose we just remove them. After going through all the benchmarks on our dashboard, looking back 90 days, I think the list includes:

Sweet:

Bent:

Other:

Happy to debate which of these are still worth keeping.

CC @dr2chase @prattmic @aclements @randall77
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Feb 14, 2023
@gopherbot gopherbot added this to the Unreleased milestone Feb 14, 2023
@bcmills bcmills added Performance Testing An issue that has been verified to require only test changes, not just a test failure. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Feb 15, 2023
@mknyszek mknyszek self-assigned this Feb 15, 2023
@mknyszek mknyszek moved this to In Progress in Go Compiler / Runtime Feb 15, 2023
@mknyszek mknyszek mentioned this issue Feb 15, 2023
Open
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/478615 mentions this issue: perf/app: drop BleveQuery from dashboard home page

gopherbot pushed a commit to golang/build that referenced this issue Mar 24, 2023
@prattmic
perf/app: drop BleveQuery from dashboard home page
f9fc598 
This benchmark was deleted and now the home page doesn't load because
there is no data.

For golang/go#58534.

Change-Id: Ic203932f6d9896dcd102484721cfe73152590403
Reviewed-on: https://go-review.googlesource.com/c/build/+/478615
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Michael Pratt <mpratt@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
@mknyszek
Copy link
Contributor Author

This is basically done. Also superseded by #59672.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Compiler / Runtime Jul 21, 2023
@golang golang locked and limited conversation to collaborators Jul 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mknyszek mknyszek

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Performance Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@mknyszek @bcmills @gopherbot