Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/internal/task: macOS PKG installer doesn't tell where Go is being installed #58496

Closed
dolmen opened this issue Feb 13, 2023 · 3 comments
Closed

x/build/internal/task: macOS PKG installer doesn't tell where Go is being installed #58496

dolmen opened this issue Feb 13, 2023 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@dolmen
Copy link
Contributor

dolmen commented Feb 13, 2023

What version of Go are you using (go version)?

$ go version
go version go1.20 darwin/amd64

Does this issue reproduce with the latest release?

Yes.

What did you do?

Install Go 1.20 using package https://go.dev/dl/go1.20.darwin-amd64.pkg

Screenshots from French install:

Capture d’écran 2023-02-13 à 17 35 38

Note that "Destination" screen (mentioned on the sidebar) is never shown to the user.

Capture d’écran 2023-02-13 à 17 35 46

Capture d’écran 2023-02-13 à 17 36 14

Capture d’écran 2023-02-13 à 17 36 51

What did you expect to see?

I expect that the installer tells me that Go has been installed into /usr/local/go and that I have to manually inject /usr/local/go/bin into $PATH like described at https://go.dev/doc/install.

What did you see instead?

As screenshots show, no indication of where Go has been installed.

The information is available at https://go.dev/doc/install though.
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Feb 13, 2023
@gopherbot gopherbot added this to the Unreleased milestone Feb 13, 2023
@dolmen
Copy link
Contributor Author

dolmen commented Feb 13, 2023 •
edited

gopherbot added this to the Unreleased milestone

Well 1.20 has been released.

@prattmic
Copy link
Member

cc @golang/release

@prattmic prattmic added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 14, 2023
@dmitshur
Copy link
Contributor

Thanks for reporting this.

The Go installer on macOS adds the installed go and gofmt binaries to PATH by placing a file containing the "/usr/local/go/bin" path to the /etc/paths.d directory. You should be able to see it by running cat /etc/paths.d/go. There is no need to manually modify PATH—it is automatically handled by the installer. You might need to restart the terminal if it was the first time Go was installed on a given Mac.

This is consistent with what's written in macOS tab at https://go.dev/doc/install:

The package installs the Go distribution to /usr/local/go. The package should put the /usr/local/go/bin directory in your PATH environment variable. You may need to restart any open Terminal sessions for the change to take effect.

Everything seems to be working as intended and as documented, so I'll close this. Please comment if I missed something. Thanks.

@dmitshur dmitshur changed the title x/build: macOS PKG installer doesn't tell where Go is being installed x/build/internal/task: macOS PKG installer doesn't tell where Go is being installed Feb 15, 2023
@golang golang locked and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@dolmen @prattmic @dmitshur @gopherbot