Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/ssa: TestStdlib failing with new generic code in std/net #58491

Closed
findleyr opened this issue Feb 13, 2023 · 4 comments
Closed

x/tools/go/ssa: TestStdlib failing with new generic code in std/net #58491

findleyr opened this issue Feb 13, 2023 · 4 comments
Assignees
@timothy-king
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs to be done soon. (regressions, serious bugs, outages) Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@findleyr
Copy link
Contributor

It appears that https://go.dev/cl/465836 broke x/tools/go/ssa, apparently because we don't handle the new generic code correctly.

https://build.golang.org/log/999175e1f8f6df38aed77ac653fc1626eaed5464

Selected output from that log:

panic: in net.doBlockingWithCtx[int]$1: cannot convert extract t0 #0 (int) to T

goroutine 10067 [running]:
golang.org/x/tools/go/ssa.emitConv(0x34e1e000, {0xef896180, 0x34e10540}, {0x8400354, 0xe978ee0})
	/workdir/gopath/src/golang.org/x/tools/go/ssa/emit.go:286 +0xe87
golang.org/x/tools/go/ssa.emitStore(0x34e1e000, {0x84014b4, 0x34e10570}, {0xef896180, 0x34e10540}, 0x6843b7)
	/workdir/gopath/src/golang.org/x/tools/go/ssa/emit.go:377 +0x69
golang.org/x/tools/go/ssa.(*lazyAddress).store(0x31d13bd8, 0x34e1e000, {0xef896180, 0x34e10540})
	/workdir/gopath/src/golang.org/x/tools/go/ssa/lvalue.go:115 +0x4d
golang.org/x/tools/go/ssa.(*builder).assignStmt(0x29d2bf18, 0x34e1e000, {0x122d6830, 0x2, 0x2}, {0x122f6768, 0x1, 0x1}, 0x0)
	/workdir/gopath/src/golang.org/x/tools/go/ssa/builder.go:1213 +0x2b3

CC @timothy-king @adonovan
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Feb 13, 2023
@gopherbot gopherbot added this to the Unreleased milestone Feb 13, 2023
@findleyr
Copy link
Contributor Author

In the meantime, I will put in a temporary skip to allow our longtest builders to pass.

@findleyr findleyr added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs to be done soon. (regressions, serious bugs, outages) labels Feb 13, 2023
@findleyr findleyr changed the title x/tools/go/ssa: longtest builders failing with new generic code in std/net x/tools/go/ssa: TestStdlib failing with new generic code in std/net Feb 13, 2023
@gopherbot
Copy link

Change https://go.dev/cl/467676 mentions this issue: go/ssa: temporarily skip the 'net' package in TestStdlib

gopherbot pushed a commit to golang/tools that referenced this issue Feb 13, 2023
@findleyr
go/ssa: temporarily skip the 'net' package in TestStdlib
72d72f9 
Following CL 465836, go/ssa panics on the net package. Skip it for now
to unbreak the longtest builders.

I thought I may need to skip the reverse transitive cone of net, but
simply skipping the net package appears to fix the failing test.

For golang/go#58491

Change-Id: Id2fb898ba2867ecf70311ab8945ac6330dbffb0a
Reviewed-on: https://go-review.googlesource.com/c/tools/+/467676
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
gopls-CI: kokoro <noreply+kokoro@google.com>
@gopherbot
Copy link

Change https://go.dev/cl/467995 mentions this issue: go/ssa: substitute type parameters in local types

@gopherbot
Copy link

Change https://go.dev/cl/469295 mentions this issue: all: update dependency to tools

gopherbot pushed a commit to golang/vuln that referenced this issue Feb 17, 2023
@timothy-king @zpavlinovic
all: update dependency to tools
b91abcc 
Resolves some panics in ssa.

Updates golang/go#58491

Change-Id: I99fc36b652bd4e9989875c1f6a5ed3622f9511ec
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/469295
Reviewed-by: Zvonimir Pavlinovic <zpavlinovic@google.com>
Run-TryBot: Tim King <taking@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Tim King <taking@google.com>
softdev050 added a commit to softdev050/Golangvuln that referenced this issue Apr 5, 2023
@softdev050
all: update dependency to tools
8fdca78 
Resolves some panics in ssa.

Updates golang/go#58491

Change-Id: I99fc36b652bd4e9989875c1f6a5ed3622f9511ec
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/469295
Reviewed-by: Zvonimir Pavlinovic <zpavlinovic@google.com>
Run-TryBot: Tim King <taking@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Tim King <taking@google.com>
sayjun0505 added a commit to sayjun0505/Golangvuln that referenced this issue Apr 8, 2023
@sayjun0505
all: update dependency to tools
fbe331e 
Resolves some panics in ssa.

Updates golang/go#58491

Change-Id: I99fc36b652bd4e9989875c1f6a5ed3622f9511ec
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/469295
Reviewed-by: Zvonimir Pavlinovic <zpavlinovic@google.com>
Run-TryBot: Tim King <taking@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Tim King <taking@google.com>
stanislavkononiuk added a commit to stanislavkononiuk/Golangvuln that referenced this issue Jun 26, 2023
@stanislavkononiuk
all: update dependency to tools
2a54e6d 
Resolves some panics in ssa.

Updates golang/go#58491

Change-Id: I99fc36b652bd4e9989875c1f6a5ed3622f9511ec
Reviewed-on: https://go-review.googlesource.com/c/vuln/+/469295
Reviewed-by: Zvonimir Pavlinovic <zpavlinovic@google.com>
Run-TryBot: Tim King <taking@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Tim King <taking@google.com>
@golang golang locked and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@timothy-king timothy-king

Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Soon This needs to be done soon. (regressions, serious bugs, outages) Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@timothy-king @gopherbot @findleyr