-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/tools/go/ssa: TestStdlib failing with new generic code in std/net #58491
Labels
FrozenDueToAge
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Soon
This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)
Tools
This label describes issues relating to any tools in the x/tools repository.
Milestone
Comments
In the meantime, I will put in a temporary skip to allow our longtest builders to pass. |
Change https://go.dev/cl/467676 mentions this issue: |
gopherbot
pushed a commit
to golang/tools
that referenced
this issue
Feb 13, 2023
Following CL 465836, go/ssa panics on the net package. Skip it for now to unbreak the longtest builders. I thought I may need to skip the reverse transitive cone of net, but simply skipping the net package appears to fix the failing test. For golang/go#58491 Change-Id: Id2fb898ba2867ecf70311ab8945ac6330dbffb0a Reviewed-on: https://go-review.googlesource.com/c/tools/+/467676 Reviewed-by: Bryan Mills <bcmills@google.com> Run-TryBot: Robert Findley <rfindley@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> gopls-CI: kokoro <noreply+kokoro@google.com>
Change https://go.dev/cl/467995 mentions this issue: |
Change https://go.dev/cl/469295 mentions this issue: |
gopherbot
pushed a commit
to golang/vuln
that referenced
this issue
Feb 17, 2023
Resolves some panics in ssa. Updates golang/go#58491 Change-Id: I99fc36b652bd4e9989875c1f6a5ed3622f9511ec Reviewed-on: https://go-review.googlesource.com/c/vuln/+/469295 Reviewed-by: Zvonimir Pavlinovic <zpavlinovic@google.com> Run-TryBot: Tim King <taking@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Tim King <taking@google.com>
softdev050
added a commit
to softdev050/Golangvuln
that referenced
this issue
Apr 5, 2023
Resolves some panics in ssa. Updates golang/go#58491 Change-Id: I99fc36b652bd4e9989875c1f6a5ed3622f9511ec Reviewed-on: https://go-review.googlesource.com/c/vuln/+/469295 Reviewed-by: Zvonimir Pavlinovic <zpavlinovic@google.com> Run-TryBot: Tim King <taking@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Tim King <taking@google.com>
sayjun0505
added a commit
to sayjun0505/Golangvuln
that referenced
this issue
Apr 8, 2023
Resolves some panics in ssa. Updates golang/go#58491 Change-Id: I99fc36b652bd4e9989875c1f6a5ed3622f9511ec Reviewed-on: https://go-review.googlesource.com/c/vuln/+/469295 Reviewed-by: Zvonimir Pavlinovic <zpavlinovic@google.com> Run-TryBot: Tim King <taking@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Tim King <taking@google.com>
stanislavkononiuk
added a commit
to stanislavkononiuk/Golangvuln
that referenced
this issue
Jun 26, 2023
Resolves some panics in ssa. Updates golang/go#58491 Change-Id: I99fc36b652bd4e9989875c1f6a5ed3622f9511ec Reviewed-on: https://go-review.googlesource.com/c/vuln/+/469295 Reviewed-by: Zvonimir Pavlinovic <zpavlinovic@google.com> Run-TryBot: Tim King <taking@google.com> TryBot-Result: Gopher Robot <gobot@golang.org> Auto-Submit: Tim King <taking@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
FrozenDueToAge
NeedsInvestigation
Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Soon
This needs action soon. (recent regressions, service outages, unusual time-sensitive situations)
Tools
This label describes issues relating to any tools in the x/tools repository.
It appears that https://go.dev/cl/465836 broke x/tools/go/ssa, apparently because we don't handle the new generic code correctly.
https://build.golang.org/log/999175e1f8f6df38aed77ac653fc1626eaed5464
Selected output from that log:
CC @timothy-king @adonovan
The text was updated successfully, but these errors were encountered: