x/website: short links should work on tip.golang.org #58484
Comments
rittneje
changed the title
seankhliao
changed the title
seankhliao
added
NeedsInvestigation
|
Hey @rittneje , I would like to work on this issue ... |
|
I am very new to open source , I tried to search alot for the text "rejects anonymous interface cycles" but couldn't find , @rittneje please help me solve this issue and make me move one step forward in my open source contribution journey |
|
The text is at https://go.googlesource.com/website/+/refs/heads/master/_content/doc/go1.20.html#339. But the fix for this is not to change that file. This fix for this is to change tip.golang.org so that /issue links redirect as they do for go.dev. See references to tip.golang.org and gotip in the Go files in go.googlesource.com/website. |
|
@ianlancetaylor Thanks for replying , But I suspect that the file go1.20.html is not present on my localhost but can be seen when inspecting or viewing the source code. In this type of situation , what can i do more ? |
|
I'm sorry, I don't understand the question. To be clear, I suspect that fixing this issue is going to require checking out the source code from go.googlesource.com/website and changing it so that the /issue (and /cl) shortlinks from tip.golang.org redirect correctly. |
|
I can find the above code for the site https://go.dev/issue/56103 which redirects to #56103. First line specifies that its for site https://go.dev/doc/go1.20#compiler I understood what changes are to be made .. If I would get the text " rejects anonymous interface cycles" which is linked with https://tip.golang.org/issue/56103 then I will make the appropriate changes which will then be redirected to #56103 Hope you understand |
|
@aryanvarma7272 I think you have misunderstood what is to be done. The link I mentioned in the original issue is just one example of the problem. The fix is NOT to fix the link itself. Rather, it is add/fix the redirection logic in the tip.golang.org server. Here is where the redirection logic is set up: For some reason, it seems that code is not running on tip.golang.org (or it isn't working correctly). |
|
Change https://go.dev/cl/475555 mentions this issue: |
What is the URL of the page with the issue?
https://tip.golang.org/doc/go1.20#compiler
What did you do?
If you look at the release notes on https://go.dev/doc/go1.20#compiler, the text "rejects anonymous interface cycles" links to
https://go.dev/issue/56103, which results in a 302 redirect tohttps://github.com/golang/go/issues/56103.However, if you look at the release notes on https://tip.golang.org/doc/go1.20#compiler, the link is for
https://tip.golang.org/issue/56103, which results in a 404 and thus renders theto, err := human()page.What did you expect to see?
Either
https://tip.golang.org/issue/56103should redirect tohttps://github.com/golang/go/issues/56103, or the release notes should just directly link to GitHub in the first place.What did you see instead?
The text was updated successfully, but these errors were encountered: