Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

math: TestCompare failures #58468

Closed
gopherbot opened this issue Feb 11, 2023 · 5 comments
Closed

math: TestCompare failures #58468

gopherbot opened this issue Feb 11, 2023 · 5 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "math" && test == "TestCompare"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestCompare (0.00s)
    all_test.go:2296: Compare(NaN, -Inf) = 1, want -1
    all_test.go:2296: Compare(-Inf, NaN) = -1, want 1
    all_test.go:2302: Compare32(NaN, -Inf) = 1, want -1
    all_test.go:2302: Compare32(-Inf, NaN) = -1, want 1

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 11, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "math" && test == "TestCompare"
2023-02-09 21:14 linux-mips-rtrk go@a4d5fbc3 math.TestCompare (log) 
--- FAIL: TestCompare (0.00s)
    all_test.go:2296: Compare(NaN, -Inf) = 1, want -1
    all_test.go:2296: Compare(-Inf, NaN) = -1, want 1
    all_test.go:2302: Compare32(NaN, -Inf) = 1, want -1
    all_test.go:2302: Compare32(-Inf, NaN) = -1, want 1
2023-02-09 23:41 linux-mips-rtrk go@fb79da29 math.TestCompare (log) 
--- FAIL: TestCompare (0.00s)
    all_test.go:2296: Compare(NaN, -Inf) = 1, want -1
    all_test.go:2296: Compare(-Inf, NaN) = -1, want 1
    all_test.go:2302: Compare32(NaN, -Inf) = 1, want -1
    all_test.go:2302: Compare32(-Inf, NaN) = -1, want 1

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "math" && test == "TestCompare"
2023-02-09 21:14 linux-mips64le-rtrk go@a4d5fbc3 math.TestCompare (log) 
--- FAIL: TestCompare (0.00s)
    all_test.go:2296: Compare(NaN, -Inf) = 1, want -1
    all_test.go:2296: Compare(-Inf, NaN) = -1, want 1
    all_test.go:2302: Compare32(NaN, -Inf) = 1, want -1
    all_test.go:2302: Compare32(-Inf, NaN) = -1, want 1
2023-02-09 23:41 linux-mips64le-rtrk go@fb79da29 math.TestCompare (log) 
--- FAIL: TestCompare (0.00s)
    all_test.go:2296: Compare(NaN, -Inf) = 1, want -1
    all_test.go:2296: Compare(-Inf, NaN) = -1, want 1
    all_test.go:2302: Compare32(NaN, -Inf) = 1, want -1
    all_test.go:2302: Compare32(-Inf, NaN) = -1, want 1
2023-02-10 16:53 linux-mips64le-rtrk go@2b807e1d math.TestCompare (log) 
--- FAIL: TestCompare (0.00s)
    all_test.go:2296: Compare(NaN, -Inf) = 1, want -1
    all_test.go:2296: Compare(-Inf, NaN) = -1, want 1
    all_test.go:2302: Compare32(NaN, -Inf) = 1, want -1
    all_test.go:2302: Compare32(-Inf, NaN) = -1, want 1

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "math" && test == "TestCompare"
2023-02-09 21:14 linux-mips64-rtrk go@a4d5fbc3 math.TestCompare (log) 
--- FAIL: TestCompare (0.00s)
    all_test.go:2296: Compare(NaN, -Inf) = 1, want -1
    all_test.go:2296: Compare(-Inf, NaN) = -1, want 1
    all_test.go:2302: Compare32(NaN, -Inf) = 1, want -1
    all_test.go:2302: Compare32(-Inf, NaN) = -1, want 1
2023-02-09 23:41 linux-mips64-rtrk go@fb79da29 math.TestCompare (log) 
--- FAIL: TestCompare (0.00s)
    all_test.go:2296: Compare(NaN, -Inf) = 1, want -1
    all_test.go:2296: Compare(-Inf, NaN) = -1, want 1
    all_test.go:2302: Compare32(NaN, -Inf) = 1, want -1
    all_test.go:2302: Compare32(-Inf, NaN) = -1, want 1

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "math" && test == "TestCompare"
2023-02-09 21:14 linux-mipsle-rtrk go@a4d5fbc3 math.TestCompare (log) 
--- FAIL: TestCompare (0.00s)
    all_test.go:2296: Compare(NaN, -Inf) = 1, want -1
    all_test.go:2296: Compare(-Inf, NaN) = -1, want 1
    all_test.go:2302: Compare32(NaN, -Inf) = 1, want -1
    all_test.go:2302: Compare32(-Inf, NaN) = -1, want 1
2023-02-09 23:41 linux-mipsle-rtrk go@fb79da29 math.TestCompare (log) 
--- FAIL: TestCompare (0.00s)
    all_test.go:2296: Compare(NaN, -Inf) = 1, want -1
    all_test.go:2296: Compare(-Inf, NaN) = -1, want 1
    all_test.go:2302: Compare32(NaN, -Inf) = 1, want -1
    all_test.go:2302: Compare32(-Inf, NaN) = -1, want 1
2023-02-10 15:04 linux-mipsle-rtrk go@79e01ab7 math.TestCompare (log) 
--- FAIL: TestCompare (0.00s)
    all_test.go:2296: Compare(NaN, -Inf) = 1, want -1
    all_test.go:2296: Compare(-Inf, NaN) = -1, want 1
    all_test.go:2302: Compare32(NaN, -Inf) = 1, want -1
    all_test.go:2302: Compare32(-Inf, NaN) = -1, want 1

— watchflakes

@earthboundkid earthboundkid mentioned this issue Feb 11, 2023
Closed
@smasher164
Copy link
Member

The change that caused this test failure was reverted in https://go-review.googlesource.com/c/go/+/467255

Discussion on addressing the cause is happening in #56491

@golang golang locked and limited conversation to collaborators Feb 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Test Flakes
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gopherbot @smasher164