Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc/effective_go: sentence has a period when it should have a comma:"...refer to its contents, so exported names..." #5846

Closed
gopherbot opened this issue Jul 7, 2013 · 7 comments

Comments

@gopherbot
Copy link

by feedback.test.account:

https://feedback.corp.google.com/#/Report/866861792

Description:
sentence has a period when it should have a comma:

"...refer to its contents, so exported names..."

UI language: en
Detected language: en
@minux
Copy link
Member

minux commented Jul 7, 2013

Comment 1:

where does this report come from? why it lacks essential information?
i have to google the partial sentence to find out the reporter is complaining about
the effective Go document, and the issue is in fact valid.

Status changed to Accepted.

@DanielMorsing
Copy link
Contributor

Comment 2:

I think it comes from the send feedback link that was recently added to the site.

@minux
Copy link
Member

minux commented Jul 7, 2013

Comment 3:

aha, i see.
we probably should make it also put the URL in the issue, or we will have to
grep the whole tree for the issue each time handling this kind of issue.

@DanielMorsing
Copy link
Contributor

Comment 4:

I don't know how much you can customize integration with feedback.
If it's not possible, then we should just remove integration and have it mail someone
with corp.google.com access. Seeing as this is the first one of these I've seen, it
shouldn't be too big a burden.

@adg
Copy link
Contributor

adg commented Jul 7, 2013

Comment 5:

Unfortunately there's no way I provide give access to feedback.corp.google.com to anyone
but Google employees.
Non-Googlers should just ignore issues marked "Feedback" until they are triaged by the
team.
I would prefer to have all the issues filed on the tracker here, as otherwise they
present yet another queue of tasks to monitor. Almost all of them should become issues
here anyway.
OT: I disagree with the report.

Owner changed to @adg.

Status changed to Invalid.

@minux
Copy link
Member

minux commented Jul 8, 2013

Comment 6:

could feedback.test.account post more details here?
i think the URL alone will be of great help here.

@adg
Copy link
Contributor

adg commented Jul 8, 2013

Comment 7:

No, it cannot be configured. Sorry.

@golang golang locked and limited conversation to collaborators Jun 24, 2016
@rsc rsc unassigned adg Jun 22, 2022
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants