Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/ecdsa: GenerateKey infinite loop/reader EOF with all zero reader #58454

Open
djedward opened this issue Feb 10, 2023 · 2 comments
Open

crypto/ecdsa: GenerateKey infinite loop/reader EOF with all zero reader #58454

djedward opened this issue Feb 10, 2023 · 2 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.

Comments

@djedward
Copy link

What version of Go are you using (go version)?

$ go version
go version go1.20 darwin/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE="on"
GOARCH="amd64"
GOBIN=""
GOCACHE="/Users/user/Library/Caches/go-build"
GOENV="/Users/user/Library/Application Support/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOINSECURE=""
GOMODCACHE="/Users/user/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="darwin"
GOPATH="/Users/user/go"
GOPRIVATE=""
GOPROXY="direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/darwin_amd64"
GOVCS=""
GOVERSION="go1.20"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="clang"
CXX="clang++"
CGO_ENABLED="1"
GOMOD="/Users/user/workplace/aws-sdk-go-v2/go.mod"
GOWORK=""
CGO_CFLAGS="-O2 -g"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-O2 -g"
CGO_FFLAGS="-O2 -g"
CGO_LDFLAGS="-O2 -g"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -arch x86_64 -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/bl/1vrx92z52vlbnzw22s5_vv9nfc7g3n/T/go-build2434718469=/tmp/go-build -gno-record-gcc-switches -fno-common"

What did you do?

Ran tests on a package after upgrading to Go 1.20. It had a test passing a reader with all zero bytes to GenerateKey. I've distilled it down to two examples in the Go playground:

What did you expect to see?

In 1.19, the call succeeded. The new code in 1.20 has tests to reject this, so perhaps an appropriate error after a certain number of loops/bytes read? This is a highly unlikely scenario, but figured it was probably worth at least reporting.

What did you see instead?

With a limited reader, I receive "unexpected EOF", since it hits the end of the reader. With a reader that keeps returning data, an infinite loop happens.
@seankhliao seankhliao added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 10, 2023
@seankhliao
Copy link
Member

cc @golang/security

@AlexanderYastrebov
Copy link
Contributor

Both issues are caused by the same assumption that k can not be zero here:

go/src/crypto/ecdsa/ecdsa.go

Lines 219 to 225 in 48f4728

// FIPS 186-4 makes us check k <= N - 2 and then add one.
// Checking 0 < k <= N - 1 is strictly equivalent.
// None of this matters anyway because the chance of selecting
// zero is cryptographically negligible.
if _, err = k.SetBytes(b, c.N); err == nil && k.IsZero() == 0 {
break
}

First case returns zeroes until loop hits unexpectedEOF, second case triggers infinite loop.

@aajtodd aajtodd mentioned this issue Feb 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AlexanderYastrebov @djedward @seankhliao