Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/vet: Doesn't detect Git conflict markers in comments #58433

Closed
debarshiray opened this issue Feb 9, 2023 · 1 comment
Closed

cmd/vet: Doesn't detect Git conflict markers in comments #58433

debarshiray opened this issue Feb 9, 2023 · 1 comment
Labels
FrozenDueToAge

Comments

@debarshiray
Copy link

What version of Go are you using (go version)?

$ go version
go version go1.18.10 linux/amd64

Does this issue reproduce with the latest release?

I haven't tried anything newer.

What operating system and processor architecture are you using (go env)?

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/home/rishi/.cache/go-build"
GOENV="/home/rishi/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/home/rishi/.cache/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/home/rishi/.cache/go"
GOPRIVATE=""
GOPROXY="direct"
GOROOT="/usr/lib/golang"
GOSUMDB="off"
GOTMPDIR=""
GOTOOLDIR="/usr/lib/golang/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.18.10"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -fmessage-length=0 -fdebug-prefix-map=/tmp/go-build3843776021=/tmp/go-build -gno-record-gcc-switches"

What did you do?

A contributor submitted a merge/pull request to my project where they forgot to resolve some Git conflicts and the markers were left behind in the source code. Normally I would have expected go build to fail, but these conflicts were in comment blocks. So, I was wondering if go vet should have caught these instead.

What did you expect to see?

I was expecting go vet to fail.

What did you see instead?

go vet didn't fail.
@seankhliao
Copy link
Member

I believe this is out of scope for vet.
It's not go code.

@seankhliao seankhliao closed this as not planned Won't fix, can't repro, duplicate, stale Feb 9, 2023
@golang golang locked and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@debarshiray @gopherbot @seankhliao