Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go/internal/test: TestVetAnalyzersSetIsCorrect failures #58430

Closed
gopherbot opened this issue Feb 9, 2023 · 2 comments
Closed

cmd/go/internal/test: TestVetAnalyzersSetIsCorrect failures #58430

gopherbot opened this issue Feb 9, 2023 · 2 comments
Assignees
@bcmills
Labels
FrozenDueToAge GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.21

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "cmd/go/internal/test" && test == "TestVetAnalyzersSetIsCorrect"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestVetAnalyzersSetIsCorrect (0.00s)
    flagdefs_test.go:55: go vet: can't execute /workdir/go/pkg/tool/js_wasm/vet -flags: pipe: not implemented on js

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 9, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "cmd/go/internal/test" && test == "TestVetAnalyzersSetIsCorrect"
2023-02-08 23:52 js-wasm-node18 go@910f041f cmd/go/internal/test.TestVetAnalyzersSetIsCorrect (log) 
--- FAIL: TestVetAnalyzersSetIsCorrect (0.00s)
    flagdefs_test.go:55: go vet: can't execute /workdir/go/pkg/tool/js_wasm/vet -flags: pipe: not implemented on js
2023-02-09 01:06 js-wasm-node18 go@8fb95658 cmd/go/internal/test.TestVetAnalyzersSetIsCorrect (log) 
--- FAIL: TestVetAnalyzersSetIsCorrect (0.00s)
    flagdefs_test.go:55: go vet: can't execute /workdir/go/pkg/tool/js_wasm/vet -flags: pipe: not implemented on js
2023-02-09 09:33 js-wasm-node18 go@fd208c88 cmd/go/internal/test.TestVetAnalyzersSetIsCorrect (log) 
--- FAIL: TestVetAnalyzersSetIsCorrect (0.00s)
    flagdefs_test.go:55: go vet: can't execute /workdir/go/pkg/tool/js_wasm/vet -flags: pipe: not implemented on js

— watchflakes

@bcmills bcmills self-assigned this Feb 9, 2023
@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. GoCommand cmd/go labels Feb 9, 2023
@bcmills bcmills added this to the Go1.21 milestone Feb 9, 2023
@bcmills
Copy link
Contributor

bcmills commented Feb 9, 2023

Fixed in CL 466695.

@bcmills bcmills closed this as completed Feb 9, 2023
@golang golang locked and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bcmills bcmills

Labels
FrozenDueToAge GoCommand cmd/go NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
Test Flakes
Status: Done
Milestone
Go1.21
Development

No branches or pull requests
2 participants
@bcmills @gopherbot