Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/link: relocation truncated to fit: R_ARM_CALL against `runtime.duffcopy' #58425

Closed
saschagrunert opened this issue Feb 9, 2023 · 48 comments
Assignees
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@saschagrunert
Copy link

saschagrunert commented Feb 9, 2023

What version of Go are you using (go version)?

$ go version
go version go1.20 linux/amd64

Does this issue reproduce with the latest release?

Yes, by cross compiling kubernetes/kubernetes@b7ad179 to the linux/arm platform.

What operating system and processor architecture are you using (go env)?

We build in a custom container image registry.k8s.io/build-image/kube-cross

go env Output
$ go env
GO111MODULE=""
GOARCH="amd64"
GOBIN=""
GOCACHE="/go/src/k8s.io/kubernetes/.cache/go-build"
GOENV="/go/src/k8s.io/kubernetes/.config/go/env"
GOEXE=""
GOEXPERIMENT=""
GOFLAGS=""
GOHOSTARCH="amd64"
GOHOSTOS="linux"
GOINSECURE=""
GOMODCACHE="/go/pkg/mod"
GONOPROXY=""
GONOSUMDB=""
GOOS="linux"
GOPATH="/go"
GOPRIVATE=""
GOPROXY="https://proxy.golang.org,direct"
GOROOT="/usr/local/go"
GOSUMDB="sum.golang.org"
GOTMPDIR=""
GOTOOLDIR="/usr/local/go/pkg/tool/linux_amd64"
GOVCS=""
GOVERSION="go1.20"
GCCGO="gccgo"
GOAMD64="v1"
AR="ar"
CC="gcc"
CXX="g++"
CGO_ENABLED="1"
GOMOD="/dev/null"
GOWORK=""
CGO_CFLAGS="-O2 -g"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-O2 -g"
CGO_FFLAGS="-O2 -g"
CGO_LDFLAGS="-O2 -g"
PKG_CONFIG="pkg-config"
GOGCCFLAGS="-fPIC -m64 -pthread -Wl,--no-gc-sections -fmessage-length=0 -fdebug-prefix-map=/tmp.k8s/go-build942910395=/tmp/go-build -gno-record-gcc-switches"

What did you do?

Running make release in the root of the Kubernetes repository. Everything gets built successfully, except the k8s.io/kubernetes/test/e2e_node.test, which fails with:

/usr/local/go/pkg/tool/linux_amd64/link: running arm-linux-gnueabihf-gcc failed: exit status 1
/tmp.k8s/go-link-865684912/go.o: in function `k8s.io/kubernetes/vendor/github.com/aws/aws-sdk-go/service/ec2.(*ModifyCapacityReservationInput).GoString':
go.go:(.text+0x207ca88): relocation truncated to fit: R_ARM_CALL against `runtime.duffcopy'
go.go:(.text+0x207ca94): relocation truncated to fit: R_ARM_CALL against `runtime.duffcopy'
collect2: error: ld returned 1 exit status

A small patch can be applied to make it fail faster for reproduction:

diff --git a/hack/make-rules/cross.sh b/hack/make-rules/cross.sh
index f8a6d0dbf5e..1a7a19ff307 100755
--- a/hack/make-rules/cross.sh
+++ b/hack/make-rules/cross.sh
@@ -27,12 +27,12 @@ source "${KUBE_ROOT}/hack/lib/init.sh"
 # NOTE: Using "${array[*]}" here is correct.  [@] becomes distinct words (in
 # bash parlance).
 
-make all WHAT="${KUBE_SERVER_TARGETS[*]}" KUBE_BUILD_PLATFORMS="${KUBE_SERVER_PLATFORMS[*]}"
+#make all WHAT="${KUBE_SERVER_TARGETS[*]}" KUBE_BUILD_PLATFORMS="${KUBE_SERVER_PLATFORMS[*]}"
 
-make all WHAT="${KUBE_NODE_TARGETS[*]}" KUBE_BUILD_PLATFORMS="${KUBE_NODE_PLATFORMS[*]}"
+#make all WHAT="${KUBE_NODE_TARGETS[*]}" KUBE_BUILD_PLATFORMS="${KUBE_NODE_PLATFORMS[*]}"
 
-make all WHAT="${KUBE_CLIENT_TARGETS[*]}" KUBE_BUILD_PLATFORMS="${KUBE_CLIENT_PLATFORMS[*]}"
+#make all WHAT="${KUBE_CLIENT_TARGETS[*]}" KUBE_BUILD_PLATFORMS="${KUBE_CLIENT_PLATFORMS[*]}"
 
-make all WHAT="${KUBE_TEST_TARGETS[*]}" KUBE_BUILD_PLATFORMS="${KUBE_TEST_PLATFORMS[*]}"
+#make all WHAT="${KUBE_TEST_TARGETS[*]}" KUBE_BUILD_PLATFORMS="${KUBE_TEST_PLATFORMS[*]}"
 
-make all WHAT="${KUBE_TEST_SERVER_TARGETS[*]}" KUBE_BUILD_PLATFORMS="${KUBE_TEST_SERVER_PLATFORMS[*]}"
+make all WHAT="test/e2e_node/e2e_node.test" KUBE_BUILD_PLATFORMS="linux/arm"

Setting CGO_CFLAGS=-mlong-calls does not help, disabling CGO does provide a workaround.

Source code changes seem to have impact on the issue, because the build works with the next commit kubernetes/kubernetes@b0171f7

Ref: kubernetes/kubernetes#115613, kubernetes/kubernetes#115605

What did you expect to see?

That the test binary compiles correctly with CGO enabled.

What did you see instead?

The link failure.

@saschagrunert
Copy link
Author

saschagrunert commented Feb 9, 2023

Copying from kubernetes/kubernetes#115605 (comment)

Reproducer with a Dockerfile, on kubernetes/kubernetes@b7ad179:

FROM debian:latest

RUN apt-get update && \
    apt-get install -y \
        gcc-arm-linux-gnueabihf \
        wget

RUN wget https://go.dev/dl/go1.20.linux-amd64.tar.gz && \
    tar xf *.tar.gz && \
    mv go /usr/local

ENV PATH=$PATH:/usr/local/go/bin
ENV GOARCH=arm
ENV CGO_ENABLED=1
ENV CC=arm-linux-gnueabihf-gcc

COPY . /work
WORKDIR /work
RUN go test -o e2e_node.test k8s.io/kubernetes/test/e2e_node
  • It breaks with go 1.20 but works with go 1.19.5 on debian:latest (bullseye-20230208, arm-linux-gnueabihf-gcc 10.2.1)
  • It breaks with go 1.20 but works with go 1.19.5 on debian:testing (testing-20230208, arm-linux-gnueabihf-gcc 12.2.0)

@tpaschalis
Copy link
Contributor

tpaschalis commented Feb 10, 2023

We're also having this issue when cross-compiling the Grafana Agent on ARMv6/ARMv7. I've posted some details on #58428

@dr2chase
Copy link
Contributor

@golang/compiler

@dr2chase dr2chase added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 10, 2023
@thanm thanm self-assigned this Feb 10, 2023
@thanm
Copy link
Contributor

thanm commented Feb 10, 2023

I'll take a look.

@liggitt
Copy link
Contributor

liggitt commented Feb 10, 2023

I bisected to 833367e:

git bisect start
# good: [e99f53fed98b0378c147588789b8c56b0305469b] doc: move Go 1.19 release notes to x/website
git bisect good e99f53fed98b0378c147588789b8c56b0305469b
# bad: [de4748c47c67392a57f250714509f590f68ad395] [release-branch.go1.20] go1.20
git bisect bad de4748c47c67392a57f250714509f590f68ad395
# bad: [1e4989c33674bf9570c99250a081a448c3cded65] cmd: relocate search.MatchPattern to cmd/internal/pkgpattern
git bisect bad 1e4989c33674bf9570c99250a081a448c3cded65
# bad: [00bee6d9a4c3ed6168350fc6551043ff7a1895f2] cmd/compile/internal/typebits: relax alignment check
git bisect bad 00bee6d9a4c3ed6168350fc6551043ff7a1895f2
# bad: [72a76ca1f9c195ed39e929cf768d5df5421eada1] cmd/compile: restore test/nested.go test cases
git bisect bad 72a76ca1f9c195ed39e929cf768d5df5421eada1
# good: [9e4638ad20181ba4c3b1985da48c56be121901fb] net: discard unrooted 254 byte names, not rooted ones
git bisect good 9e4638ad20181ba4c3b1985da48c56be121901fb
# good: [90466e1ddf0e4305bc56f6eac61a690704e6fab8] crypto/internal/subtle: rename to crypto/internal/alias
git bisect good 90466e1ddf0e4305bc56f6eac61a690704e6fab8
# bad: [d654117075d1dd0686aa6833b22f28275623c759] cmd/compile: add intrinsic for MulUintptr on arm64
git bisect bad d654117075d1dd0686aa6833b22f28275623c759
# good: [c82bbc0e8edbbebe47e92729e8f3f1b60d380b5b] runtime: convert timer0When/timerModifiedEarliest to atomic.Int64
git bisect good c82bbc0e8edbbebe47e92729e8f3f1b60d380b5b
# good: [9485d4c1bd871be792d03c29b7902f6ac284ed27] cmd/compile/internal/syntax: handle missing index like in go/parser
git bisect good 9485d4c1bd871be792d03c29b7902f6ac284ed27
# bad: [55ecc3a88670c14bbbfc9d6c96cf65891cc608f5] net: allow single dot in resolv.conf search statement
git bisect bad 55ecc3a88670c14bbbfc9d6c96cf65891cc608f5
# bad: [833367e98af838a2511ee7e4e19dc8f1da7b8ed7] internal/buildcfg: enable unified IR by default
git bisect bad 833367e98af838a2511ee7e4e19dc8f1da7b8ed7
# good: [17211c355f015862b635f8cbd48ffc65a1081b92] go/types, types2: consolidate testdata/spec test files
git bisect good 17211c355f015862b635f8cbd48ffc65a1081b92
# good: [0a4a57de4d0764a4291e4d8654e88b44e65d8059] cmd/compile/internal/types2: use go/types/testdata/spec tests
git bisect good 0a4a57de4d0764a4291e4d8654e88b44e65d8059
# first bad commit: [833367e98af838a2511ee7e4e19dc8f1da7b8ed7] internal/buildcfg: enable unified IR by default

Notes:

  1. I had to cherry-pick 00bee6d onto each candidate commit prior to that fix before building to get around the alignment bug to make it to the failed linking step
  2. linux/arm failed, linux/arm64 seemed to work

Reproducer:

# checkout of https://github.com/golang/go
pushd go
  git checkout 833367e98af838a2511ee7e4e19dc8f1da7b8ed7
  git cherry-pick 00bee6d9a4c3ed6168350fc6551043ff7a1895f2
  pushd src
    ./make.bash
  popd
popd

export GOROOT=$PWD/go
export GOPATH=$PWD/emptydir
export PATH=$PWD/go/bin:$PATH

# checkout of https://github.com/kubernetes/kubernetes/
pushd kubernetes
  git checkout b7ad17978eaba508c560f81bab2fb9d0b256e469
  GOARCH=arm CGO_ENABLED=1 CC=arm-linux-gnueabihf-gcc go test -c k8s.io/kubernetes/test/e2e_node
popd

Output is:

# k8s.io/kubernetes/test/e2e_node.test
/usr/local/google/home/liggitt/tmp/arm/go/pkg/tool/linux_amd64/link: running arm-linux-gnueabihf-gcc failed: exit status 1
/tmp/go-link-3447838833/go.o: in function `github.com/aws/aws-sdk-go/service/ec2.(*DescribeScheduledInstancesInput).GoString':
./<autogenerated>:1:(.text+0x207e440): relocation truncated to fit: R_ARM_CALL against `runtime.duffcopy'
/tmp/go-link-3447838833/go.o: in function `github.com/aws/aws-sdk-go/service/ec2.(*DescribeScheduledInstancesInput).GoString':
/usr/local/google/home/liggitt/tmp/arm/kubernetes/vendor/github.com/aws/aws-sdk-go/service/ec2/api.go:94642:(.text+0x207e44c): relocation truncated to fit: R_ARM_CALL against `runtime.duffcopy'
/tmp/go-link-3447838833/go.o: in function `github.com/aws/aws-sdk-go/service/ec2.(*DescribeScheduledInstancesInput).String':
./<autogenerated>:1:(.text+0x207e4f0): relocation truncated to fit: R_ARM_CALL against `runtime.duffcopy'
/tmp/go-link-3447838833/go.o: in function `github.com/aws/aws-sdk-go/service/ec2.(*ScheduledInstance).GoString':
./<autogenerated>:1:(.text+0x207e598): relocation truncated to fit: R_ARM_CALL against `runtime.duffcopy'
/tmp/go-link-3447838833/go.o: in function `github.com/aws/aws-sdk-go/service/ec2.(*ScheduledInstance).GoString':
/usr/local/google/home/liggitt/tmp/arm/kubernetes/vendor/github.com/aws/aws-sdk-go/service/ec2/api.go:153021:(.text+0x207e5a4): relocation truncated to fit: R_ARM_CALL against `runtime.duffcopy'
collect2: error: ld returned 1 exit status

That commit defaulted GOEXPERIMENT=Unified on. Starting to run the bisection again with that experiment on in the invocation

@liggitt
Copy link
Contributor

liggitt commented Feb 10, 2023

Building go1.19.5 with GOEXPERIMENT=Unified reproduces the relocation truncated to fit: R_ARM_CALL against 'runtime.duffcopy' issue, so it looks like the unified build regresses on arm

@liggitt
Copy link
Contributor

liggitt commented Feb 10, 2023

cc @mdempsky

@liggitt
Copy link
Contributor

liggitt commented Feb 10, 2023

until this issue is fixed, I was able to build with GOEXPERIMENT=nounified to work around this issue and -gcflags=all=-d=inlstaticinit=0 to work around #58339

@thanm
Copy link
Contributor

thanm commented Feb 13, 2023

@liggitt thanks for the bisect.

In this case my guess would be that the bug is not actually due to the introduction of unified IR, but rather that the switch to unified IR makes the binary in question a bit bigger, which triggers the need for trampoline insertion.

I am testing a CL with a fix, I'll post it shortly.

@gopherbot
Copy link

Change https://go.dev/cl/467715 mentions this issue: cmd/link/internal/ld: fix text section splitting for ARM

@thanm
Copy link
Contributor

thanm commented Feb 13, 2023

@liggitt if you are able to test with my CL to see if the tests run cleanly on ARM that would be great.

I verified that with the CL I can link the k8s.io/kubernetes/test/e2e_node test, but my ARM test machine doesn't seem to be configured properly for me to run it (no "modprobe", , or something like that).

@liggitt
Copy link
Contributor

liggitt commented Feb 13, 2023

I don't actually have an arm test machine, all I could do was reproduce / verify the cross-compile/link worked. I'll see if I can track down an env to run the resulting binary.

I'd be curious if the CL also resolves #58428 ... the reporters of that issue might have an env to exercise their resulting binary as well

@thanm
Copy link
Contributor

thanm commented Feb 13, 2023

OK thanks. Yes, I verified that the fix also takes care of #58428. I am planning on duping that bug against this one. I'll on that issue about testing.

rfratto added a commit to tpaschalis/agent that referenced this issue Feb 13, 2023
@rfratto
Copy link

rfratto commented Feb 13, 2023

👋 We've tested your CL against the resulting binary for #58428 and verified that everything still works. Thank you!

@liggitt
Copy link
Contributor

liggitt commented Feb 13, 2023

Thanks for the quick turnaround. Could this be backported to 1.20, since it resolves a compiler issue that doesn't have a workaround (#58428)?

@thanm
Copy link
Contributor

thanm commented Feb 13, 2023

I will indeed look into backports.

@liggitt
Copy link
Contributor

liggitt commented Mar 15, 2023

thanks, can that fix be taken back to 1.19 / 1.20?

@thanm
Copy link
Contributor

thanm commented Mar 15, 2023

Yes, I've kicked off the process to back-port the second fix (issue to follow is #59034).

@gopherbot
Copy link

Change https://go.dev/cl/476935 mentions this issue: cmd/link/internal/arm: fix off-by-1 in trampoline reachability computation

@gopherbot
Copy link

Change https://go.dev/cl/476936 mentions this issue: cmd/link/internal/arm: fix off-by-1 in trampoline reachability computation

gopherbot pushed a commit that referenced this issue Mar 22, 2023
…line reachability computation

Tweak the code in trampoline generation that determines if a given
call branch will reach, changing the lower limit guard from "x <
-0x800000" to "x <= -0x800000". This is to resolve linking failures
when the computed displacement is exactly -0x800000, which results in
errors of the form

  .../ld.gold: internal error in arm_branch_common, at ../../gold/arm.cc:4079

when using the Gold linker, and

  ...:(.text+0x...): relocation truncated to fit: R_ARM_CALL against `runtime.morestack_noctxt'

when using the bfd linker.

Fixes #59059.
Updates #59034.
Updates #58425.

Change-Id: I8a76986b38727df1b961654824c2af23f06b9fcf
Reviewed-on: https://go-review.googlesource.com/c/go/+/475957
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
(cherry picked from commit f26bf20)
Reviewed-on: https://go-review.googlesource.com/c/go/+/476936
gopherbot pushed a commit that referenced this issue Mar 22, 2023
…line reachability computation

Tweak the code in trampoline generation that determines if a given
call branch will reach, changing the lower limit guard from "x <
-0x800000" to "x <= -0x800000". This is to resolve linking failures
when the computed displacement is exactly -0x800000, which results in
errors of the form

  .../ld.gold: internal error in arm_branch_common, at ../../gold/arm.cc:4079

when using the Gold linker, and

  ...:(.text+0x...): relocation truncated to fit: R_ARM_CALL against `runtime.morestack_noctxt'

when using the bfd linker.

Fixes #59058.
Updates #59034.
Updates #58425.

Change-Id: I8a76986b38727df1b961654824c2af23f06b9fcf
Reviewed-on: https://go-review.googlesource.com/c/go/+/475957
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
(cherry picked from commit f26bf20)
Reviewed-on: https://go-review.googlesource.com/c/go/+/476935
@rfratto
Copy link

rfratto commented Apr 6, 2023

We just updated to go1.20.3, and our 32-bit ARM builds seem to be working again 🎉 Thanks @thanm!

@rfratto
Copy link

rfratto commented Apr 6, 2023

@thanm Unfortunately I spoke too soon. grafana/agent#3485 just ran into the issue again after removing some code, with two different errors for two different commands (both ARMv6):

# github.com/grafana/agent/cmd/grafana-agent-flow
/usr/local/go/pkg/tool/linux_amd64/link: running viceroycc failed: exit status 1
/tmp/go-link-4002740392/go.o: in function `github.com/weaveworks/common/middleware.Log.Wrap.func1':
/go/pkg/mod/github.com/weaveworks/common@v0.0.0-20221201103051-7c2720a9024d/middleware/response.go:45:(.text+0x207dab0): relocation truncated to fit: R_ARM_CALL against `runtime.duffcopy'
# github.com/grafana/agent/cmd/grafana-agentctl
/usr/local/go/pkg/tool/linux_amd64/link: running viceroycc failed: exit status 1
/tmp/go-link-1646694243/go.o: in function `google.golang.org/api/compute/v1.(*RegionSecurityPoliciesListCall).doRequest':
/go/pkg/mod/google.golang.org/api@v0.109.0/compute/v1/compute-gen.go:153224:(.text+0x207d7f4): relocation truncated to fit: R_ARM_CALL against `runtime.gcWriteBarrier'

This can be validated by checking out 0369aedde7d227b221eaf97c6b489a433f21ba5d and building ./cmd/grafana-agentctl and ./cmd/grafana-agent-flow with CGO_ENABLED=1 GOOS=linux GOARCH=arm GOARM=6

@thanm
Copy link
Contributor

thanm commented Apr 6, 2023

Thanks for the update. This bug seems to be the "gift that keeps giving", apparently. I will take another look.

@mknyszek
Copy link
Contributor

mknyszek commented Jun 9, 2023

Hey @thanm, doing a sweep of the Go 1.21 milestone. Any updates here? Should this go to Backlog? Thanks.

@thanm
Copy link
Contributor

thanm commented Jun 9, 2023

Should still be in 1.21 I think (just got a bit lost in the sauce). I will take another look.

@gopherbot gopherbot modified the milestones: Go1.21, Go1.22 Aug 8, 2023
@kminehart
Copy link

kminehart commented Sep 12, 2023

This strangely started showing up in Grafana. We bisected to a seemingly benign commit, though it is consistently failing in a function in a specific dependency. Based on what I'm seeing in this thread, the dependency is unrelated.

We are seeing this on 1.21.1, but we are not seeing this error on 1.21.0 or 1.20.8.

CC=/toolchain/arm-linux-musleabihf-cross/bin/arm-linux-musleabihf-gcc
CGO_CFLAGS="-D_LARGEFILE64_SOURCE"
CGO_ENABLED=1
CXX=/toolchain/arm-linux-musleabihf-cross/bin/arm-linux-musleabihf-cpp
GOARCH=arm
GOARM=7
GOOS=linux
go build -ldflags -w -s -linkmode=external -extldflags=-static -X 'main.version=10.2.0-pre' -X 'main.commit=40c7aac087' -X 'main.buildstamp=1694554530' -X 'main.buildBranch=main'  -o bin/linux/arm/v7/grafana-cli -tags netgo,osusergo -trimpath ./pkg/cmd/grafana

/usr/local/go/pkg/tool/linux_amd64/link: running /toolchain/arm-linux-musleabihf-cross/bin/arm-linux-musleabihf-gcc failed: exit status 1
/tmp/go-link-2970699141/go.o: in function `github.com/rueian/rueidis/internal/cmds.(*ClientTrackingBcast).Optout':
go.go:(.text+0x2081d14): relocation truncated to fit: R_ARM_CALL against `runtime.gcWriteBarrier2'
collect2: error: ld returned 1 exit status

@cherrymui
Copy link
Member

This failure is very sensitive to binary size and and code layout. A seemingly unrelated change may change the code layout just slightly to go over or under the limit.

@gopherbot
Copy link

Change https://go.dev/cl/531795 mentions this issue: cmd/link: split text sections for arm 32-bit

@gopherbot
Copy link

Change https://go.dev/cl/532096 mentions this issue: cmd/link: split text sections for arm 32-bit

@gopherbot
Copy link

Change https://go.dev/cl/532097 mentions this issue: cmd/link: split text sections for arm 32-bit

gopherbot pushed a commit that referenced this issue Oct 12, 2023
This CL is a roll-forward (tweaked slightly) of CL 467715, which
turned on text section splitting for GOARCH=arm. The intent is to
avoid recurrent problems with external linking where there is a
disagreement between the Go linker and the external linker over
whether a given branch will reach. In the past our approach has been
to tweak the reachability calculations slightly to try to work around
potential linker problems, but this hasn't proven to be very robust;
section splitting seems to offer a better long term fix.

Updates #58425.
Fixes #63317.

Change-Id: I7372d41abce84097906a3d0805b6b9c486f345d6
Reviewed-on: https://go-review.googlesource.com/c/go/+/531795
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 1e69040)
Reviewed-on: https://go-review.googlesource.com/c/go/+/532096
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
gopherbot pushed a commit that referenced this issue Oct 12, 2023
This CL is a roll-forward (tweaked slightly) of CL 467715, which
turned on text section splitting for GOARCH=arm. The intent is to
avoid recurrent problems with external linking where there is a
disagreement between the Go linker and the external linker over
whether a given branch will reach. In the past our approach has been
to tweak the reachability calculations slightly to try to work around
potential linker problems, but this hasn't proven to be very robust;
section splitting seems to offer a better long term fix.

Updates #58425.
Fixes #63316.

Change-Id: I7372d41abce84097906a3d0805b6b9c486f345d6
Reviewed-on: https://go-review.googlesource.com/c/go/+/531795
Reviewed-by: Cherry Mui <cherryyz@google.com>
Run-TryBot: Than McIntosh <thanm@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 1e69040)
Reviewed-on: https://go-review.googlesource.com/c/go/+/532097
Auto-Submit: Dmitri Shuralyov <dmitshur@google.com>
kylebrandt added a commit to grafana/grafana that referenced this issue Jan 29, 2024
…hange drone to fix ARM rpm build and Update Swagger) (#81396)

 - Feature Toggle is `promQLScope`.
 - Query property is:

"scope": {
  "matchers": "{job=~\".*\"}"
 }

Misc:
 - Also updates drone GO version to address ARM bug golang/go#58425
 - Also updates Swagger defs that were causing builds to fail

---------

Co-authored-by: Kevin Minehart <kmineh0151@gmail.com>
Ukochka pushed a commit to grafana/grafana that referenced this issue Feb 14, 2024
…hange drone to fix ARM rpm build and Update Swagger) (#81396)

 - Feature Toggle is `promQLScope`.
 - Query property is:

"scope": {
  "matchers": "{job=~\".*\"}"
 }

Misc:
 - Also updates drone GO version to address ARM bug golang/go#58425
 - Also updates Swagger defs that were causing builds to fail

---------

Co-authored-by: Kevin Minehart <kmineh0151@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests