Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go/internal/test: stale flagdefs.go not detected by tests [1.20 backport] #58421

Closed
gopherbot opened this issue Feb 8, 2023 · 2 comments
Closed

cmd/go/internal/test: stale flagdefs.go not detected by tests [1.20 backport] #58421

gopherbot opened this issue Feb 8, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go
Milestone
Go1.20.1

Comments

@gopherbot
Copy link

@bcmills requested issue #58415 to be considered for backport to the next 1.20 minor release.

@gopherbot, please backport to Go 1.20. This masked two missing vet analyzer flags that should be added.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 8, 2023
@gopherbot gopherbot mentioned this issue Feb 8, 2023
Closed
@gopherbot gopherbot added this to the Go1.20.1 milestone Feb 8, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/466855 mentions this issue: [release-branch.go1.20] cmd/go/internal/test: refresh flagdefs.go and fix test

@bcmills bcmills added GoCommand cmd/go CherryPickApproved Used during the release process for point releases labels Feb 9, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Feb 9, 2023
@gopherbot
Copy link
Author

Closed by merging 7628627 to release-branch.go1.20.

gopherbot pushed a commit that referenced this issue Feb 10, 2023
@dr2chase
[release-branch.go1.20] cmd/go/internal/test: refresh flagdefs.go and…
7628627 
… fix test

The tests for cmd/go/internal/test were not running at all due to a
missed call to m.Run in TestMain. That masked a missing vet analyzer
("timeformat") and a missed update to the generator script in
CL 355452.

Fixes #58421.
Updates #58415.

Change-Id: I7b0315952967ca07a866cdaa5903478b2873eb7a
Reviewed-on: https://go-review.googlesource.com/c/go/+/466635
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
(cherry picked from commit 910f041)
Reviewed-on: https://go-review.googlesource.com/c/go/+/466855
romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Feb 14, 2023
@romaindoumenc
[release-branch.go1.20] cmd/go/internal/test: refresh flagdefs.go and…
f2eb473 
… fix test

The tests for cmd/go/internal/test were not running at all due to a
missed call to m.Run in TestMain. That masked a missing vet analyzer
("timeformat") and a missed update to the generator script in
CL 355452.

Fixes golang#58421.
Updates golang#58415.

Change-Id: I7b0315952967ca07a866cdaa5903478b2873eb7a
Reviewed-on: https://go-review.googlesource.com/c/go/+/466635
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
(cherry picked from commit 910f041)
Reviewed-on: https://go-review.googlesource.com/c/go/+/466855
@golang golang locked and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge GoCommand cmd/go
Projects
None yet
Milestone
Go1.20.1
Development

No branches or pull requests
2 participants
@bcmills @gopherbot