Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/playground/cmd/latestgo: use gerrit for resolving go versions #58350

Closed
findleyr opened this issue Feb 6, 2023 · 3 comments
Closed

x/playground/cmd/latestgo: use gerrit for resolving go versions #58350

findleyr opened this issue Feb 6, 2023 · 3 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.21

Comments

@findleyr
Copy link
Contributor

findleyr commented Feb 6, 2023

In #58305, we observed that there is a race in the x/playground deployment: the deployment is triggered by git tagging, but uses maintner for repo information, and maintner state changes are triggered by pub/sub. As a result, the playground deployment found the wrong go versions.

We should update cmd/latestgo to use the same information as the trigger. @dmitshur pointed to the following reference where x/build determines Go versions: https://cs.opensource.google/go/x/build/+/master:internal/task/version.go;l=24-47;drc=dd73d1bda781b30f2e6d723897aa0113c72f2534.

Low priority, but it would be nice if this were done at least before Go 1.21, else we may find that the playground serves stale versions again.

This is a self-contained project that is easy to test, and therefore would be a good opportunity for external contribution.

CC @golang/release @toothrot
@findleyr findleyr added this to the Go1.21 milestone Feb 6, 2023
@dr2chase dr2chase added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 10, 2023
@petergeorgas
Copy link

Does this still need fixed? I would love to do this.

@findleyr
Copy link
Contributor Author

@petergeorgas yes this still needs fixing. Please feel free to take it on.

@gopherbot
Copy link

Change https://go.dev/cl/467955 mentions this issue: latestgo: Update latestgo to use Gerrit to retrieve latest Go version

@golang golang locked and limited conversation to collaborators Mar 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.21
Development

No branches or pull requests
4 participants
@dr2chase @gopherbot @petergeorgas @findleyr