Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/pkgsite: package removal request for github.com/kobaxidze256/go-null #58329

Closed
Kobaxidze256 opened this issue Feb 5, 2023 · 6 comments
Closed
Labels
FrozenDueToAge pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package pkgsite
Milestone

Comments

@Kobaxidze256
Copy link

What is the path of the package that you would like to have removed?

github.com/kobaxidze256/go-null

Are you the owner of this package?

Yes.

What is the reason that you could not retract this package instead?

There's a new module where its URL points.

@gopherbot gopherbot added this to the Unreleased milestone Feb 5, 2023
@seankhliao seankhliao added the pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package label Feb 5, 2023
@suzmue
Copy link
Contributor

suzmue commented Feb 7, 2023

Hi @Kobaxidze256, I see that at pkg.go.dev the information for github.com/kobaxidze256/go-null is from 3 days ago. Is this a different module than is there now?

There appear to be a couple of new tagged versions in the github repo, to get those into the module proxy (and onto pkg.go.dev) you need to make a request for the module version through the module proxy. There are a number of ways to do this and instructions on pkg.go.dev (https://pkg.go.dev/about#adding-a-package).

Visiting the following should add the version to pkgsite, and you can do the same for earlier versions if you want those to appear as well:

Removing this package from pkg.go.dev means that pkg.go.dev will no longer serve documentation for that package path at all, including the new module that is at that URL. I see the latest version on pkg.go.dev was 1.0.3, so if you request any of the newer versions through the proxy (as described above), the latest information for the documentation will show this newer version.

@Kobaxidze256
Copy link
Author

The new package is https://pkg.go.dev/github.com/Kobaxidze256/go-null .
I wrote an incorrect path in go.mod which resulted in the old path showing up on pkg.go.dev. I will remove the versions containing the old go.mod.

@suzmue
Copy link
Contributor

suzmue commented Feb 7, 2023

Thanks for the clarification! I missed the change of case.

You should be able to retract the previous versions of the module using retract as follows:

  1. Commit the following (with the old module path):

go.mod:

module github.com/kobaxidze256/go-null

go 1.19

retract (
  v1.0.8
  [v1.0.0, v1.0.3]
)
  1. Tag v1.0.8
  2. Revert go.mod to use the new module path.
    go.mod:
module github.com/Kobaxidze256/go-null

go 1.18

... rest of go.mod file

@Kobaxidze256
Copy link
Author

Did 1 and 2. I will do the third later. I'm expecting the old go doc page to change.

@Kobaxidze256
Copy link
Author

Kobaxidze256 commented Feb 7, 2023

It worked. Close the issue if you want. Thank you @suzmue!

@ianlancetaylor
Copy link
Contributor

Thanks for following up.

@ianlancetaylor ianlancetaylor closed this as not planned Won't fix, can't repro, duplicate, stale Feb 8, 2023
@golang golang locked and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge pkgsite/package-removal Issues for package removal. See https://pkg.go.dev/about#removing-a-package pkgsite
Projects
None yet
Development

No branches or pull requests

5 participants