Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: constant overflows when assigned to package level var (Go 1.20 regression) [1.20 backport] #58319

Closed
gopherbot opened this issue Feb 4, 2023 · 2 comments
Closed

cmd/compile: constant overflows when assigned to package level var (Go 1.20 regression) [1.20 backport] #58319

gopherbot opened this issue Feb 4, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Milestone
Go1.20.1

Comments

@gopherbot
Copy link

@tklauser requested issue #58293 to be considered for backport to the next 1.20 minor release.

@gopherbot please consider this for backport to 1.20, it's a regression.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Feb 4, 2023
@gopherbot gopherbot mentioned this issue Feb 4, 2023
Closed
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Feb 4, 2023
@gopherbot gopherbot added this to the Go1.20.1 milestone Feb 4, 2023
@dr2chase dr2chase added the CherryPickApproved Used during the release process for point releases label Feb 8, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Feb 8, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/466676 mentions this issue: [release-branch.go1.20] cmd/compile: remove constant arithmetic overflows during typecheck

@gopherbot
Copy link
Author

Closed by merging 7302f83 to release-branch.go1.20.

gopherbot pushed a commit that referenced this issue Feb 9, 2023
@cuonglm @dr2chase
[release-branch.go1.20] cmd/compile: remove constant arithmetic overf…
7302f83 
…lows during typecheck

Since go1.19, these errors are already reported by types2 for any user's
Go code. Compiler generated code, which looks like constant expression
should be evaluated as non-constant semantic, which allows overflows.

Fixes #58319

Change-Id: I6f0049a69bdb0a8d0d7a0db49c7badaa92598ea2
Reviewed-on: https://go-review.googlesource.com/c/go/+/466676
Reviewed-by: Keith Randall <khr@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
bradfitz pushed a commit to tailscale/go that referenced this issue Feb 9, 2023
@cuonglm @bradfitz
[release-branch.go1.20] cmd/compile: remove constant arithmetic overf…
2efa24e 
…lows during typecheck

Since go1.19, these errors are already reported by types2 for any user's
Go code. Compiler generated code, which looks like constant expression
should be evaluated as non-constant semantic, which allows overflows.

Fixes golang#58319

Change-Id: I6f0049a69bdb0a8d0d7a0db49c7badaa92598ea2
Reviewed-on: https://go-review.googlesource.com/c/go/+/466676
Reviewed-by: Keith Randall <khr@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Feb 14, 2023
@cuonglm @romaindoumenc
[release-branch.go1.20] cmd/compile: remove constant arithmetic overf…
c8d2256 
…lows during typecheck

Since go1.19, these errors are already reported by types2 for any user's
Go code. Compiler generated code, which looks like constant expression
should be evaluated as non-constant semantic, which allows overflows.

Fixes golang#58319

Change-Id: I6f0049a69bdb0a8d0d7a0db49c7badaa92598ea2
Reviewed-on: https://go-review.googlesource.com/c/go/+/466676
Reviewed-by: Keith Randall <khr@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Tobias Klauser <tobias.klauser@gmail.com>
@golang golang locked and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge
Projects
None yet
Milestone
Go1.20.1
Development

No branches or pull requests
3 participants
@dr2chase @gopherbot and others