Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: Compiler should support : in asm go1.20 #58314

Closed
timandy opened this issue Feb 4, 2023 · 1 comment
Closed

x/tools/gopls: Compiler should support : in asm go1.20 #58314

timandy opened this issue Feb 4, 2023 · 1 comment
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@timandy
Copy link

timandy commented Feb 4, 2023

As you know, go 1.20 auto generated symbols's name is changed(go.->go: and type.->type:).

But when I reference these new symbols in asm, the compiler reported error(illegal or missing addressing mode for symbol type).

I think the compiler's behavior should be adjusted accordingly.

Thanks for all.
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Feb 4, 2023
@gopherbot gopherbot added this to the Unreleased milestone Feb 4, 2023
@suzmue suzmue added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 6, 2023
@suzmue
Copy link
Contributor

suzmue commented Feb 7, 2023

Closing as a duplicate of #58244.

There is nothing gopls can do to address this issue.

@suzmue suzmue closed this as completed Feb 7, 2023
@golang golang locked and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@timandy @suzmue @gopherbot