Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/stringer: TestConstValueChange failures #58313

Closed
gopherbot opened this issue Feb 3, 2023 · 3 comments
Closed

x/tools/cmd/stringer: TestConstValueChange failures #58313

gopherbot opened this issue Feb 3, 2023 · 3 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository. ToolSpeed
Milestone
Unreleased

Comments

@gopherbot
Copy link

gopherbot commented Feb 3, 2023 •
edited by bcmills 

#!watchflakes
post <- pkg == "golang.org/x/tools/cmd/stringer" && test == "TestConstValueChange" && `panic: test timed out`

Issue created automatically to collect these failures.

Example (log):

panic: test timed out after 10m0s
running tests:
	TestConstValueChange (1s)

syscall.Wait4(0x40c948?, 0xc00009ac00?, 0x0?, 0x0?)
	/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/syscall/syscall_solaris.go:275 +0x26
os.(*Process).wait(0xc0000220f0)
	/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/os/exec_unix.go:43 +0x77
os.(*Process).Wait(...)
	/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/os/exec.go:132
os/exec.(*Cmd).Wait(0xc000090580)
	/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/os/exec/exec.go:890 +0x45
os/exec.(*Cmd).Run(0xc000018d20?)
	/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/os/exec/exec.go:590 +0x2d
golang.org/x/tools/cmd/stringer.runInDir({0x6b32ba, 0x1}, {0x6b33b8?, 0x8?}, {0xc000080d50?, 0x839d88?, 0x87a0a0?})
	/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/gopath/src/golang.org/x/tools/cmd/stringer/endtoend_test.go:251 +0x145
golang.org/x/tools/cmd/stringer.run(...)
	/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/gopath/src/golang.org/x/tools/cmd/stringer/endtoend_test.go:240
golang.org/x/tools/cmd/stringer.buildStringer(0xc000007380)
	/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/gopath/src/golang.org/x/tools/cmd/stringer/endtoend_test.go:191 +0x185
golang.org/x/tools/cmd/stringer.TestConstValueChange(0xc000007380)
	/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/gopath/src/golang.org/x/tools/cmd/stringer/endtoend_test.go:142 +0x3e
testing.tRunner(0xc000007380, 0x6cb178)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 3, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/cmd/stringer" && test == "TestConstValueChange"
2023-02-02 23:42 solaris-amd64-oraclerel tools@81111180 go@2f2c5e41 x/tools/cmd/stringer.TestConstValueChange (log) 
panic: test timed out after 10m0s
running tests:
	TestConstValueChange (1s)

syscall.Wait4(0x40c948?, 0xc00009ac00?, 0x0?, 0x0?)
	/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/syscall/syscall_solaris.go:275 +0x26
os.(*Process).wait(0xc0000220f0)
	/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/os/exec_unix.go:43 +0x77
os.(*Process).Wait(...)
	/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/os/exec.go:132
os/exec.(*Cmd).Wait(0xc000090580)
	/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/os/exec/exec.go:890 +0x45
os/exec.(*Cmd).Run(0xc000018d20?)
	/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/go/src/os/exec/exec.go:590 +0x2d
golang.org/x/tools/cmd/stringer.runInDir({0x6b32ba, 0x1}, {0x6b33b8?, 0x8?}, {0xc000080d50?, 0x839d88?, 0x87a0a0?})
	/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/gopath/src/golang.org/x/tools/cmd/stringer/endtoend_test.go:251 +0x145
golang.org/x/tools/cmd/stringer.run(...)
	/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/gopath/src/golang.org/x/tools/cmd/stringer/endtoend_test.go:240
golang.org/x/tools/cmd/stringer.buildStringer(0xc000007380)
	/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/gopath/src/golang.org/x/tools/cmd/stringer/endtoend_test.go:191 +0x185
golang.org/x/tools/cmd/stringer.TestConstValueChange(0xc000007380)
	/opt/golang/tmp/workdir-host-solaris-oracle-amd64-oraclerel/gopath/src/golang.org/x/tools/cmd/stringer/endtoend_test.go:142 +0x3e
testing.tRunner(0xc000007380, 0x6cb178)

— watchflakes

@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Feb 3, 2023
@gopherbot gopherbot added this to the Unreleased milestone Feb 3, 2023
@bcmills
Copy link
Contributor

bcmills commented Feb 6, 2023

This should be fixed by https://go.dev/cl/464350 (thanks @alexandear!).

The cmd/stringer test was repeatedly rebuilding cmd/stringer itself — it looks like the buildStringer helper was called to re-link the same binary three(!) times, which was extremely wasteful on builders with relatively slow linking.

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. ToolSpeed NeedsFix The path to resolution is known, but the work has not been done. labels Feb 6, 2023
@bcmills bcmills closed this as completed Feb 6, 2023
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 6, 2023
@gopherbot

This comment was marked as off-topic.

Sign in to view
@gopherbot gopherbot reopened this Feb 24, 2023
@bcmills bcmills closed this as completed Feb 24, 2023
@golang golang locked and limited conversation to collaborators Feb 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository. ToolSpeed
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot