Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/website: go.dev/learn dark mode text contrast #58295

Closed
talohana opened this issue Feb 3, 2023 · 5 comments
Closed

x/website: go.dev/learn dark mode text contrast #58295

talohana opened this issue Feb 3, 2023 · 5 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. website

Comments

@talohana
Copy link

talohana commented Feb 3, 2023

What is the URL of the page with the issue?

https://go.dev/learn

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/109.0.0.0 Safari/537.36

Screenshot

image

@gopherbot gopherbot added this to the Unreleased milestone Feb 3, 2023
@talohana talohana changed the title x/website: go.dev/learn contrast x/website: go.dev/learn dark mode text contrast Feb 3, 2023
@mknyszek
Copy link
Contributor

mknyszek commented Feb 3, 2023

CC @golang/tools-team

@mknyszek mknyszek added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 3, 2023
@talohana
Copy link
Author

talohana commented Feb 3, 2023

The issue seems to only happen on my external DELL U2722DE display, on my MBP monitor it seems to work:
image

@thediveo
Copy link

thediveo commented Feb 4, 2023

That looks like a layout problem to me, as in a narrow window (regardless of monitor width) the text will flow into the graphic and that will never work well for dark themes.

@suzmue suzmue modified the milestones: Unreleased, website/later Feb 7, 2023
@MarcusXavierr
Copy link

Maybe giving the circle a darker color would solve the problem
image

image

@suzmue
Copy link
Contributor

suzmue commented Sep 27, 2023

Closing as fixed since this was addressed in the learn page redesign in http://go.dev/cl/445579.

@suzmue suzmue closed this as completed Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. website
Projects
None yet
Development

No branches or pull requests

6 participants