Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/internal/task: "Mail update stdlib index CL for 1.20" task panic #58227

Closed
mknyszek opened this issue Feb 1, 2023 · 6 comments
Closed

x/build/internal/task: "Mail update stdlib index CL for 1.20" task panic #58227

mknyszek opened this issue Feb 1, 2023 · 6 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@mknyszek
Copy link
Contributor

mknyszek commented Feb 1, 2023

This is the failure I see:

USMGTaU3zuPiemW

In text, "Mail update stdlib index CL for 1.20" fails with "task interrupted before completion." Retrying doesn't help, and it's currently blocking announcements (@dmitshur informed me that this should be a leaf task).

CC @golang/release @golang/tools-team
@mknyszek mknyszek added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 1, 2023
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Feb 1, 2023
@mknyszek mknyszek added Soon This needs to be done soon. (regressions, serious bugs, outages) and removed Builders x/build issues (builders, bots, dashboards) labels Feb 1, 2023
@gopherbot gopherbot added this to the Unreleased milestone Feb 1, 2023
@dmitshur
Copy link
Contributor

dmitshur commented Feb 1, 2023

This is related to #54377.

@gopherbot
Copy link

Change https://go.dev/cl/464535 mentions this issue: internal/task: skip CreateUpdateStdlibIndexCL

@findleyr
Copy link
Contributor

findleyr commented Feb 1, 2023 •
edited

Is there an easy way to skip this step?

Edit: (Aha, LGTM)

@mknyszek
Copy link
Contributor Author

mknyszek commented Feb 1, 2023 •
edited

I scrapped the CL because the issue caused the whole workflow to fail, so we probably can't resume. @dmitshur thinks this is probably unrecoverable. I'll have to do the announcements manually.

@dmitshur
Copy link
Contributor

dmitshur commented Feb 1, 2023 •
edited

Relevant stack trace to help with the investigation of the problem in CreateUpdateStdlibIndexCL:

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xfedc1c]

goroutine 354024 [running]:
golang.org/x/build/internal/task.(*VersionTasks).CreateUpdateStdlibIndexCL(0xc000a75080, 0xc0006f59a0, {0xc00118e030?, 0xc00118e060?}, {0xc000704000, 0x2, 0x4}, {0xc001061650?, 0x4c4a1e?})
	/app/internal/task/version.go:149 +0x7c
reflect.Value.call({0x1191980?, 0xc000854ed0?, 0x60?}, {0x135a4d1, 0x4}, {0xc001088e40, 0x4, 0x18?})
	/usr/local/go/src/reflect/value.go:556 +0x845
reflect.Value.Call({0x1191980?, 0xc000854ed0?, 0xc0005df380?}, {0xc001088e40, 0x4, 0x4})
	/usr/local/go/src/reflect/value.go:339 +0xbf
golang.org/x/build/internal/workflow.runTask({0x1601f08?, 0xc0009adb40?}, {0xc1, 0x76, 0x62, 0x66, 0xa1, 0xac, 0x49, 0xd3, ...}, ...)
	/app/internal/workflow/workflow.go:845 +0x41c
golang.org/x/build/internal/workflow.(*Workflow).Run.func2()
	/app/internal/workflow/workflow.go:763 +0xbe
created by golang.org/x/build/internal/workflow.(*Workflow).Run
	/app/internal/workflow/workflow.go:763 +0xeef

Looks like the VersionTasks.LatestGoBinaries field is unset.

@dmitshur dmitshur mentioned this issue Feb 1, 2023
Closed
@dmitshur dmitshur changed the title x/build: relui "Mail update stdlib index CL for 1.20" consistently fails and blocks announcement in release workflow x/build/internal/task: "Mail update stdlib index CL for 1.20" task panic Feb 1, 2023
@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. and removed Soon This needs to be done soon. (regressions, serious bugs, outages) NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Feb 1, 2023
@gopherbot
Copy link

Change https://go.dev/cl/464815 mentions this issue: cmd/relui: fix up goimports regeneration task, add one-off workflow

@golang golang locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@mknyszek @dmitshur @gopherbot @findleyr