Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/link: TestBuildForTvOS failing on darwin-amd64-11_0 #58221

Closed
bcmills opened this issue Feb 1, 2023 · 7 comments
Closed

cmd/link: TestBuildForTvOS failing on darwin-amd64-11_0 #58221

bcmills opened this issue Feb 1, 2023 · 7 comments
Assignees
@bcmills
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge mobile Android, iOS, and x/mobile NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin
Milestone
Go1.21

Comments

@bcmills
Copy link
Contributor

bcmills commented Feb 1, 2023 •
edited

https://build.golang.org/log/91e8c2d60784a2c561e285e0d3ac9b204be6e8c2:

--- FAIL: TestBuildForTvOS (11.69s)
    link_test.go:312: [/tmp/buildlet/go/bin/go build -buildmode=c-archive -o /tmp/buildlet/tmp/TestBuildForTvOS1814397663/001/lib.a testdata/testBuildFortvOS/lib.go]: exit status 1:
        -buildmode=c-archive not supported on ios/arm64
FAIL
FAIL	cmd/link	24.797s

(attn @golang/ios)
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Feb 1, 2023
@bcmills bcmills added OS-Darwin mobile Android, iOS, and x/mobile labels Feb 1, 2023
@bcmills bcmills added this to the Go1.21 milestone Feb 1, 2023
@bcmills
Copy link
Contributor Author

bcmills commented Feb 1, 2023

This started failing as of CL 464339 (CC @ianlancetaylor), which marked -buildmode=c-archive as unsupported on ios due to the integration tests for that feature failing when run by cmd/dist.

@bcmills
Copy link
Contributor Author

bcmills commented Feb 1, 2023

I do not understand why the test is failing on only darwin-amd64-11_0 and not the other darwin/amd64 builders. @golang/release, is there an intentional difference in this builder as compared with the others?

The test skips itself if xcrun is not found in $PATH — perhaps our setup instructions for the builders are missing some step to include that tool?

@dmitshur dmitshur added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 1, 2023
@dmitshur
Copy link
Contributor

dmitshur commented Feb 1, 2023

From a quick look at https://farmer.golang.org/builders and the BuildConfig entries in x/build/dashboard, the only intentional and documented difference between darwin-amd64-11_0 and other darwin/amd64 builders is its macOS version. All other differences are incidental.

xcrun seems to be present on darwin-amd64-11_0 and darwin-amd64-12_0 that I quickly tried, but it's likely the problem is along those lines.

@bcmills
Copy link
Contributor Author

bcmills commented Feb 1, 2023

This test was originally added in CL 168321 for #22395.

It appears that ios support was explicitly maintained in carchive_test.go at some point, because skips were added for #13701, #19320, #31722, and #33384. So I think the intent is for the buildmode to be supported on this platform; it's a shame that the integration test failures were masked by the cmd/dist bug for so long. 😞

@bcmills
Copy link
Contributor Author

bcmills commented Feb 1, 2023

xcrun seems to be present

There is a subsequent check for an appletvos SDK specifically — maybe that's the difference?
(https://cs.opensource.google/go/go/+/master:src/cmd/link/link_test.go;l=285-288;drc=4f467f10820e78add23bf5ddeb1de521aa6f8864)

@gopherbot
Copy link

Change https://go.dev/cl/463752 mentions this issue: cmd/dist,internal/platform: reenable the c-archive build mode on ios

@bcmills bcmills mentioned this issue Feb 1, 2023
Open
@bcmills
Copy link
Contributor Author

bcmills commented Feb 1, 2023

The test is once again passing on darwin-amd64-11_0. I've filed #58231 to follow up on the builder configuration issue separately.

@bcmills bcmills self-assigned this Feb 1, 2023
johanbrandhorst pushed a commit to Pryz/go that referenced this issue Feb 12, 2023
@johanbrandhorst
cmd/dist,internal/platform: reenable the c-archive build mode on ios
26369a0 
Also fix misc/cgo/testcarchive to provide a missing CoreFoundation
dependency at link time.

Fixes golang#58221.
Updates golang#58172.
Updates golang#58225.

Change-Id: Ib8b6e52ed2914596615da4c427df2fe984722de6
Reviewed-on: https://go-review.googlesource.com/c/go/+/463752
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Bryan Mills <bcmills@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Cherry Mui <cherryyz@google.com>
@golang golang locked and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bcmills bcmills

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge mobile Android, iOS, and x/mobile NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin
Projects
None yet
Milestone
Go1.21
Development

No branches or pull requests
3 participants
@dmitshur @bcmills @gopherbot