Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/regtest/workspace: TestBrokenWorkspace_WrongModulePath failures #58156

Closed
gopherbot opened this issue Jan 30, 2023 · 2 comments
Closed

x/tools/gopls/internal/regtest/workspace: TestBrokenWorkspace_WrongModulePath failures #58156

gopherbot opened this issue Jan 30, 2023 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/workspace" && test == "TestBrokenWorkspace_WrongModulePath"

Issue created automatically to collect these failures.

Example (log):

==================
WARNING: DATA RACE
Read at 0x00c0002960c0 by goroutine 318:
  golang.org/x/tools/gopls/internal/lsp/cache.(*overlayFS).Overlays()
      /workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/fs_overlay.go:33 +0xcb1
  golang.org/x/tools/gopls/internal/lsp.(*Server).diagnose()
      /workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/diagnostics.go:352 +0xc2c
  golang.org/x/tools/gopls/internal/lsp.(*Server).diagnoseSnapshot()
      /workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/diagnostics.go:167 +0x2ea
  golang.org/x/tools/gopls/internal/lsp.(*Server).diagnoseSnapshots.func1()
...

[Trace - 21:20:12.086 PM] Received notification '$/progress'.
Params: {"token":"5715915864827999571","value":{"kind":"end","message":"Done."}}


#### End Gopls Test Logs for "TestBrokenWorkspace_WrongModulePath/default"
--- FAIL: TestBrokenWorkspace_WrongModulePath (7.39s)
    --- FAIL: TestBrokenWorkspace_WrongModulePath/default (2.88s)
        testing.go:1446: race detected during execution of test
    testing.go:1446: race detected during execution of test

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 30, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/workspace" && test == "TestBrokenWorkspace_WrongModulePath"
2023-01-30 20:57 linux-amd64-longtest-race tools@26831282 go@2ab0e046 x/tools/gopls/internal/regtest/workspace.TestBrokenWorkspace_WrongModulePath (log) 
==================
WARNING: DATA RACE
Read at 0x00c0002960c0 by goroutine 318:
  golang.org/x/tools/gopls/internal/lsp/cache.(*overlayFS).Overlays()
      /workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/fs_overlay.go:33 +0xcb1
  golang.org/x/tools/gopls/internal/lsp.(*Server).diagnose()
      /workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/diagnostics.go:352 +0xc2c
  golang.org/x/tools/gopls/internal/lsp.(*Server).diagnoseSnapshot()
      /workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/diagnostics.go:167 +0x2ea
  golang.org/x/tools/gopls/internal/lsp.(*Server).diagnoseSnapshots.func1()
...

[Trace - 21:20:12.086 PM] Received notification '$/progress'.
Params: {"token":"5715915864827999571","value":{"kind":"end","message":"Done."}}


#### End Gopls Test Logs for "TestBrokenWorkspace_WrongModulePath/default"
--- FAIL: TestBrokenWorkspace_WrongModulePath (7.39s)
    --- FAIL: TestBrokenWorkspace_WrongModulePath/default (2.88s)
        testing.go:1446: race detected during execution of test
    testing.go:1446: race detected during execution of test

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 30, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jan 30, 2023
@bcmills
Copy link
Contributor

bcmills commented Jan 31, 2023

Duplicate of #58151

@bcmills bcmills marked this as a duplicate of #58151 Jan 31, 2023
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2023
@golang golang locked and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot