Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls/internal/regtest/workspace: TestNewModule_Issue38207 failures #58155

Closed
gopherbot opened this issue Jan 30, 2023 · 3 comments
Closed
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@gopherbot
Copy link

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/workspace" && test == "TestNewModule_Issue38207"

Issue created automatically to collect these failures.

Example (log):

==================
WARNING: DATA RACE
Read at 0x00c009bd9198 by goroutine 90361:
  golang.org/x/tools/gopls/internal/lsp/cache.(*overlayFS).Overlays()
      /workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/fs_overlay.go:34 +0xda4
  golang.org/x/tools/gopls/internal/lsp.(*Server).diagnose()
      /workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/diagnostics.go:352 +0xc2c
  golang.org/x/tools/gopls/internal/lsp.(*Server).diagnoseSnapshot()
      /workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/diagnostics.go:167 +0x2ea
  golang.org/x/tools/gopls/internal/lsp.(*Server).diagnoseSnapshots.func1()
...

[Trace - 21:21:53.335 PM] Received notification '$/progress'.
Params: {"token":"475964039857791957","value":{"kind":"end","message":"Done."}}


#### End Gopls Test Logs for "TestNewModule_Issue38207/forwarded"
--- FAIL: TestNewModule_Issue38207 (1.25s)
    --- FAIL: TestNewModule_Issue38207/forwarded (0.44s)
        testing.go:1446: race detected during execution of test
    testing.go:1446: race detected during execution of test

watchflakes

@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 30, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/workspace" && test == "TestNewModule_Issue38207"
2023-01-30 20:57 linux-amd64-longtest-race tools@26831282 go@2ab0e046 x/tools/gopls/internal/regtest/workspace.TestNewModule_Issue38207 (log)
==================
WARNING: DATA RACE
Read at 0x00c009bd9198 by goroutine 90361:
  golang.org/x/tools/gopls/internal/lsp/cache.(*overlayFS).Overlays()
      /workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/fs_overlay.go:34 +0xda4
  golang.org/x/tools/gopls/internal/lsp.(*Server).diagnose()
      /workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/diagnostics.go:352 +0xc2c
  golang.org/x/tools/gopls/internal/lsp.(*Server).diagnoseSnapshot()
      /workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/diagnostics.go:167 +0x2ea
  golang.org/x/tools/gopls/internal/lsp.(*Server).diagnoseSnapshots.func1()
...

[Trace - 21:21:53.335 PM] Received notification '$/progress'.
Params: {"token":"475964039857791957","value":{"kind":"end","message":"Done."}}


#### End Gopls Test Logs for "TestNewModule_Issue38207/forwarded"
--- FAIL: TestNewModule_Issue38207 (1.25s)
    --- FAIL: TestNewModule_Issue38207/forwarded (0.44s)
        testing.go:1446: race detected during execution of test
    testing.go:1446: race detected during execution of test

watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 30, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jan 30, 2023
@bcmills
Copy link
Contributor

bcmills commented Jan 31, 2023

Duplicate of #58151

@bcmills bcmills marked this as a duplicate of #58151 Jan 31, 2023
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/regtest/workspace" && test == "TestNewModule_Issue38207"
2023-05-05 18:49 aix-ppc64 tools@4a2dd0d2 go@26899ef3 x/tools/gopls/internal/regtest/workspace.TestNewModule_Issue38207 (log)
--- FAIL: TestNewModule_Issue38207 (2.10s)
    --- FAIL: TestNewModule_Issue38207/default (2.10s)
        diagnostics_test.go:712: organizing imports before save: internal error updating shared cache: write /.cache/gopls/21fe3500/analysis/d7/d7e3fe908dae39374a05b8c955cbbaf6df0d1b667942bfb7127a63a99f7c68d1: no space left on device
#### Start Gopls Test Logs for "TestManuallyCreatingXTest/default"
[Trace - 23:29:11.390 PM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"tagSupport":{"valueSet":[1]}}},"documentSymbol":{"hierarchicalDocumentSymbolSupport":true},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":null,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/gopls-regtest-2535714862/TestManuallyCreatingXTest/default/gopath","GOPROXY":"file:///ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/gopls-regtest-2535714862/TestManuallyCreatingXTest/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/gopls-regtest-2535714862/TestManuallyCreatingXTest/default/work","name":"work"}]}


[Trace - 23:29:11.391 PM] Received response 'initialize - (1)' in 1ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.mem_stats","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor","gopls.workspace_stats"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel 26899ef3ee7cd3d9e663e6f792c93bb411c863db\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}
...


[Trace - 23:29:16.325 PM] Received notification 'window/logMessage'.
Params: {"type":1,"message":"2023/05/05 23:29:16 storing export data for mod.com/hello_test [mod.com/hello.test]: write /.cache/gopls/21fe3500/export/5e/5e12e09af6703a8a5db27e18f06703cc9a3fd57a58c94e6cea1ca3821a72e13b: no space left on device\n"}


[Error - Received] 23:29:16.350 PM #2 internal error updating shared cache: write /.cache/gopls/21fe3500/analysis/bd/bdc7446fb38cdbbeb20bec05928c9d2d9a93190c622a06fccf422295492b1fc5: no space left on device


#### End Gopls Test Logs for "TestManuallyCreatingXTest/default"

watchflakes

@gopherbot gopherbot reopened this Jun 30, 2023
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

2 participants