Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/lsp/cmd/test: TestImports failures #58152

Closed
gopherbot opened this issue Jan 30, 2023 · 6 comments
Closed

x/tools/gopls/internal/lsp/cmd/test: TestImports failures #58152

gopherbot opened this issue Jan 30, 2023 · 6 comments
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.12.0

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cmd/test" && test == "TestImports"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestImports (6.86s)
    integration_test.go:402: gopls imports -diff a.go: exited with code 66, want 0 (gopls imports -diff a.go: exit=66 stdout=<<--- ./a.go.orig
        +++ ./a.go
        @@ -1,4 +1,6 @@
         package a
        +
        +import "fmt"
         func _() {
         	fmt.Println()
         }
...
              /tmp/workdir/gopath/src/golang.org/x/tools/internal/tool/tool.go:92 +0x233
          golang.org/x/tools/gopls/internal/lsp/cmd/test.goplsMain()
              /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:766 +0xdd
          golang.org/x/tools/gopls/internal/lsp/cmd/test.TestMain()
              /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:757 +0x55
          main.main()
              _testmain.go:83 +0x324
        ==================
        Found 1 data race(s)
        >>)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 30, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cmd/test" && test == "TestImports"
2023-01-30 20:48 freebsd-amd64-race tools@d1e92d6a go@01a5a83c x/tools/gopls/internal/lsp/cmd/test.TestImports (log) 
--- FAIL: TestImports (6.86s)
    integration_test.go:402: gopls imports -diff a.go: exited with code 66, want 0 (gopls imports -diff a.go: exit=66 stdout=<<--- ./a.go.orig
        +++ ./a.go
        @@ -1,4 +1,6 @@
         package a
        +
        +import "fmt"
         func _() {
         	fmt.Println()
         }
...
              /tmp/workdir/gopath/src/golang.org/x/tools/internal/tool/tool.go:92 +0x233
          golang.org/x/tools/gopls/internal/lsp/cmd/test.goplsMain()
              /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:766 +0xdd
          golang.org/x/tools/gopls/internal/lsp/cmd/test.TestMain()
              /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:757 +0x55
          main.main()
              _testmain.go:83 +0x324
        ==================
        Found 1 data race(s)
        >>)

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 30, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jan 30, 2023
@bcmills
Copy link
Contributor

bcmills commented Jan 31, 2023

Duplicate of #58151

@bcmills bcmills marked this as a duplicate of #58151 Jan 31, 2023
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2023
@gopherbot gopherbot reopened this Mar 16, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cmd/test" && test == "TestImports"
2023-03-15 19:02 darwin-amd64-12_0 tools@e5f7ae13 go@c69ff3a7 x/tools/gopls/internal/lsp/cmd/test.TestImports (log) 
--- FAIL: TestImports (39.53s)
    integration_test.go:402: gopls imports -diff a.go: exited with code 1, want success: true (gopls imports -diff a.go: exit=1 stdout=<<>> stderr=<<2023/03/15 23:25:24 internal error decoding *[]cache.gobDiagnostic: EOF
        >>)
    integration_test.go:403: gopls imports -diff a.go: stdout does not match [\+import "fmt"]; got <<>>
    integration_test.go:408: gopls imports -write a.go: exited with code 1, want success: true (gopls imports -write a.go: exit=1 stdout=<<>> stderr=<<2023/03/15 23:25:28 internal error decoding *[]cache.gobDiagnostic: EOF
        >>)

— watchflakes

@findleyr findleyr modified the milestones: Unreleased, gopls/v0.12.0 Mar 18, 2023
@adonovan
Copy link
Member

adonovan commented Apr 7, 2023

The latest flake looks like a dup of #59289 (the test failed because stderr included an unexpected log message reporting a failure of gob decoding). It's a little sad that such a serious error was only detected this way, but I'm going to close this issue.

@adonovan adonovan closed this as completed Apr 7, 2023
@adonovan adonovan mentioned this issue Apr 7, 2023
Open
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cmd/test" && test == "TestImports"
2023-04-20 20:04 illumos-amd64 tools@9c9e11f3 go@15c12762 x/tools/gopls/internal/lsp/cmd/test.TestImports (log) 
panic: test timed out after 10m0s
running tests:
	TestImports (10m0s)
	TestLinks (10m0s)

syscall.Wait4(0xc0002e8090?, 0xc000312380?, 0x0?, 0x0?)
	/var/tmp/workdir-host-illumos-amd64-jclulow/go/src/syscall/syscall_solaris.go:275 +0x26
os.(*Process).wait(0xc000198030)
	/var/tmp/workdir-host-illumos-amd64-jclulow/go/src/os/exec_unix.go:43 +0x77
os.(*Process).Wait(...)
	/var/tmp/workdir-host-illumos-amd64-jclulow/go/src/os/exec.go:132
os/exec.(*Cmd).Wait(0xc000394000)
	/var/tmp/workdir-host-illumos-amd64-jclulow/go/src/os/exec/exec.go:890 +0x45
os/exec.(*Cmd).Run(0xc0003a61a0?)
	/var/tmp/workdir-host-illumos-amd64-jclulow/go/src/os/exec/exec.go:590 +0x2d
golang.org/x/tools/gopls/internal/lsp/cmd/test.gopls(0xc000461520, {0xc000390be0, 0x49}, {0xc00006bf10, 0x2, 0x2})
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:812 +0x325
golang.org/x/tools/gopls/internal/lsp/cmd/test.TestImports(0xc000461520)
	/var/tmp/workdir-host-illumos-amd64-jclulow/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:393 +0x125
testing.tRunner(0xc000461520, 0x1032b58)

— watchflakes

@gopherbot gopherbot reopened this Apr 21, 2023
@findleyr
Copy link
Contributor

findleyr commented May 3, 2023

Hung in a syscall, which is a different issue.

@findleyr findleyr closed this as completed May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
gopls/v0.12.0
Development

No branches or pull requests
4 participants
@bcmills @adonovan @gopherbot @findleyr