Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/lsp/cmd/test: TestFormat failures #58149

Closed
gopherbot opened this issue Jan 30, 2023 · 7 comments
Closed

x/tools/gopls/internal/lsp/cmd/test: TestFormat failures #58149

gopherbot opened this issue Jan 30, 2023 · 7 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cmd/test" && test == "TestFormat"

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestFormat (31.63s)
    integration_test.go:267: gopls format a.go: exited with code 66, want 0 (gopls format a.go: exit=66 stdout=<<package a

        func f() {}
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c0004fe390 by goroutine 43:
          golang.org/x/tools/gopls/internal/lsp/cache.(*overlayFS).Overlays()
              /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/fs_overlay.go:33 +0xfea
          golang.org/x/tools/gopls/internal/lsp.(*Server).diagnose()
...
              /tmp/workdir/gopath/src/golang.org/x/tools/internal/tool/tool.go:92 +0x225
          golang.org/x/tools/gopls/internal/lsp/cmd/test.goplsMain()
              /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:766 +0xe4
          golang.org/x/tools/gopls/internal/lsp/cmd/test.TestMain()
              /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:757 +0x55
          main.main()
              _testmain.go:83 +0x317
        ==================
        Found 3 data race(s)
        >>)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 30, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cmd/test" && test == "TestFormat"
2023-01-30 19:34 freebsd-amd64-race tools@ae242ec3 go@581603cb x/tools/gopls/internal/lsp/cmd/test.TestFormat (log) 
--- FAIL: TestFormat (31.63s)
    integration_test.go:267: gopls format a.go: exited with code 66, want 0 (gopls format a.go: exit=66 stdout=<<package a

        func f() {}
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c0004fe390 by goroutine 43:
          golang.org/x/tools/gopls/internal/lsp/cache.(*overlayFS).Overlays()
              /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/fs_overlay.go:33 +0xfea
          golang.org/x/tools/gopls/internal/lsp.(*Server).diagnose()
...
              /tmp/workdir/gopath/src/golang.org/x/tools/internal/tool/tool.go:92 +0x225
          golang.org/x/tools/gopls/internal/lsp/cmd/test.goplsMain()
              /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:766 +0xe4
          golang.org/x/tools/gopls/internal/lsp/cmd/test.TestMain()
              /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:757 +0x55
          main.main()
              _testmain.go:83 +0x317
        ==================
        Found 3 data race(s)
        >>)

— watchflakes

@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 30, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jan 30, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cmd/test" && test == "TestFormat"
2023-01-30 19:34 freebsd-amd64-race tools@ae242ec3 go@581603cb x/tools/gopls/internal/lsp/cmd/test.TestFormat (log) 
--- FAIL: TestFormat (19.27s)
    integration_test.go:267: gopls format a.go: exited with code 66, want 0 (gopls format a.go: exit=66 stdout=<<package a

        func f() {}
        >> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c000236540 by goroutine 83:
          golang.org/x/tools/gopls/internal/lsp/cache.(*overlayFS).Overlays()
              /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/fs_overlay.go:33 +0xfea
          golang.org/x/tools/gopls/internal/lsp.(*Server).diagnose()
...
              /tmp/workdir/gopath/src/golang.org/x/tools/internal/tool/tool.go:92 +0x225
          golang.org/x/tools/gopls/internal/lsp/cmd/test.goplsMain()
              /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:766 +0xe4
          golang.org/x/tools/gopls/internal/lsp/cmd/test.TestMain()
              /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:757 +0x55
          main.main()
              _testmain.go:83 +0x317
        ==================
        Found 3 data race(s)
        >>)

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cmd/test" && test == "TestFormat"
2023-01-30 19:34 freebsd-amd64-race tools@ae242ec3 go@1c4cfb92 x/tools/gopls/internal/lsp/cmd/test.TestFormat (log) 
--- FAIL: TestFormat (13.30s)
    integration_test.go:300: gopls format -write a.go: exited with code 66, want 0 (gopls format -write a.go: exit=66 stdout=<<>> stderr=<<==================
        WARNING: DATA RACE
        Read at 0x00c00011c150 by goroutine 106:
          golang.org/x/tools/gopls/internal/lsp/cache.(*overlayFS).Overlays()
              /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/fs_overlay.go:33 +0xcb1
          golang.org/x/tools/gopls/internal/lsp.(*Server).diagnose()
              /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/diagnostics.go:352 +0xc2c
          golang.org/x/tools/gopls/internal/lsp.(*Server).diagnoseDetached()
              /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/diagnostics.go:127 +0x8a
...
              /tmp/workdir/gopath/src/golang.org/x/tools/internal/tool/tool.go:92 +0x233
          golang.org/x/tools/gopls/internal/lsp/cmd/test.goplsMain()
              /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:766 +0xd9
          golang.org/x/tools/gopls/internal/lsp/cmd/test.TestMain()
              /tmp/workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:757 +0x55
          main.main()
              _testmain.go:83 +0x32f
        ==================
        Found 3 data race(s)
        >>)

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cmd/test" && test == "TestFormat"
2023-01-30 20:57 linux-amd64-race tools@26831282 go@01a5a83c x/tools/gopls/internal/lsp/cmd/test.TestFormat (log) 
--- FAIL: TestFormat (8.79s)
    integration_test.go:281: gopls format -list a.go: exited with code 66, want 0 (gopls format -list a.go: exit=66 stdout=<<./a.go
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00001c0f0 by main goroutine:
          runtime.mapassign_faststr()
              /workdir/go/src/runtime/map_faststr.go:203 +0x0
          golang.org/x/tools/gopls/internal/lsp/cache.(*overlayFS).updateOverlays()
              /workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/session.go:708 +0x77a
          golang.org/x/tools/gopls/internal/lsp/cache.(*Session).DidModifyFiles()
...
              /workdir/gopath/src/golang.org/x/tools/internal/tool/tool.go:92 +0x233
          golang.org/x/tools/gopls/internal/lsp/cmd/test.goplsMain()
              /workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:766 +0xdd
          golang.org/x/tools/gopls/internal/lsp/cmd/test.TestMain()
              /workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:757 +0x55
          main.main()
              _testmain.go:83 +0x324
        ==================
        Found 1 data race(s)
        >>)

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cmd/test" && test == "TestFormat"
2023-01-30 20:57 linux-amd64-race tools@26831282 go@581603cb x/tools/gopls/internal/lsp/cmd/test.TestFormat (log) 
--- FAIL: TestFormat (11.75s)
    integration_test.go:281: gopls format -list a.go: exited with code 66, want 0 (gopls format -list a.go: exit=66 stdout=<<./a.go
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c00021e450 by main goroutine:
          runtime.mapassign_faststr()
              /workdir/go/src/runtime/map_faststr.go:203 +0x0
          golang.org/x/tools/gopls/internal/lsp/cache.(*overlayFS).updateOverlays()
              /workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cache/session.go:708 +0x76f
          golang.org/x/tools/gopls/internal/lsp/cache.(*Session).DidModifyFiles()
...
              /workdir/gopath/src/golang.org/x/tools/internal/tool/tool.go:92 +0x225
          golang.org/x/tools/gopls/internal/lsp/cmd/test.goplsMain()
              /workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:766 +0xe4
          golang.org/x/tools/gopls/internal/lsp/cmd/test.TestMain()
              /workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:757 +0x55
          main.main()
              _testmain.go:83 +0x317
        ==================
        Found 1 data race(s)
        >>)

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Jan 31, 2023

Duplicate of #58151

@bcmills bcmills marked this as a duplicate of #58151 Jan 31, 2023
@bcmills bcmills closed this as not planned Won't fix, can't repro, duplicate, stale Jan 31, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cmd/test" && test == "TestFormat"
2023-01-30 20:26 linux-amd64-longtest-race tools@87d00e63 go@2ab0e046 x/tools/gopls/internal/lsp/cmd/test.TestFormat (log) 
--- FAIL: TestFormat (9.79s)
    integration_test.go:267: gopls format a.go: exited with code 66, want 0 (gopls format a.go: exit=66 stdout=<<package a

        func f() {}
        >> stderr=<<==================
        WARNING: DATA RACE
        Write at 0x00c0004c2900 by main goroutine:
          runtime.mapassign_faststr()
              /workdir/go/src/runtime/map_faststr.go:203 +0x0
          golang.org/x/tools/gopls/internal/lsp/cache.(*overlayFS).updateOverlays()
...
              /workdir/gopath/src/golang.org/x/tools/internal/tool/tool.go:92 +0x233
          golang.org/x/tools/gopls/internal/lsp/cmd/test.goplsMain()
              /workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:766 +0xd9
          golang.org/x/tools/gopls/internal/lsp/cmd/test.TestMain()
              /workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:757 +0x55
          main.main()
              _testmain.go:83 +0x32f
        ==================
        Found 1 data race(s)
        >>)
2023-01-30 20:48 linux-amd64-race tools@d1e92d6a go@01a5a83c x/tools/gopls/internal/lsp/cmd/test.TestFormat (log) 
--- FAIL: TestFormat (7.97s)
    integration_test.go:287: gopls format -diff a.go: exited with code 66, want 0 (gopls format -diff a.go: exit=66 stdout=<<--- ./a.go.orig
        +++ ./a.go
        @@ -1 +1,3 @@
        -package a ;  func f ( ) { }
        +package a
        +
        +func f() {}
        >> stderr=<<==================
        WARNING: DATA RACE
...
              /workdir/gopath/src/golang.org/x/tools/internal/tool/tool.go:92 +0x233
          golang.org/x/tools/gopls/internal/lsp/cmd/test.goplsMain()
              /workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:766 +0xdd
          golang.org/x/tools/gopls/internal/lsp/cmd/test.TestMain()
              /workdir/gopath/src/golang.org/x/tools/gopls/internal/lsp/cmd/test/integration_test.go:757 +0x55
          main.main()
              _testmain.go:83 +0x324
        ==================
        Found 3 data race(s)
        >>)

— watchflakes

@golang golang locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bcmills @gopherbot