Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

time: update zoneinfo_abbrs on Windows [1.20 backport] #58117

Closed
gopherbot opened this issue Jan 27, 2023 · 3 comments
Closed

time: update zoneinfo_abbrs on Windows [1.20 backport] #58117

gopherbot opened this issue Jan 27, 2023 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Milestone
Go1.20.1

Comments

@gopherbot
Copy link

@ianlancetaylor requested issue #58113 to be considered for backport to the next 1.18 minor release.

@gopherbot Please open backport issues

The zoneinfo_abbrs data on Windows has not been updated for several years. We should update and backport if appropriate.
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jan 27, 2023
@gopherbot gopherbot mentioned this issue Jan 27, 2023
Open
@gopherbot gopherbot added this to the Go1.18.11 milestone Jan 27, 2023
@dr2chase dr2chase modified the milestones: Go1.18.11, Go1.20.1 Feb 8, 2023
@dr2chase dr2chase added the CherryPickApproved Used during the release process for point releases label Feb 8, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Feb 8, 2023
@dr2chase
Copy link
Contributor

dr2chase commented Feb 8, 2023

Reusing this cherry pick, now targeted for 1.20.

@dr2chase dr2chase changed the title time: update zoneinfo_abbrs on Windows [1.18 backport] time: update zoneinfo_abbrs on Windows [1.20 backport] Feb 8, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/466436 mentions this issue: [release-branch.go1.20] time: update windows zoneinfo_abbrs

gopherbot pushed a commit that referenced this issue Feb 9, 2023
@qmuntal @dr2chase
[release-branch.go1.20] time: update windows zoneinfo_abbrs
9987cb6 
zoneinfo_abbrs hasn't been updated since go 1.14, it's time to
regenerate it.

Fixes #58117.

Change-Id: Ic156ae607c46f1f5a9408b1fc0b56de6c14a4ed4
Reviewed-on: https://go-review.googlesource.com/c/go/+/463838
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Run-TryBot: Quim Muntal <quimmuntal@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
(cherry picked from commit 007d8f4)
Reviewed-on: https://go-review.googlesource.com/c/go/+/466436
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Quim Muntal <quimmuntal@gmail.com>
Run-TryBot: David Chase <drchase@google.com>
@gopherbot
Copy link
Author

Closed by merging 9987cb6 to release-branch.go1.20.

bradfitz pushed a commit to tailscale/go that referenced this issue Feb 9, 2023
@qmuntal @bradfitz
[release-branch.go1.20] time: update windows zoneinfo_abbrs
37b2def 
zoneinfo_abbrs hasn't been updated since go 1.14, it's time to
regenerate it.

Fixes golang#58117.

Change-Id: Ic156ae607c46f1f5a9408b1fc0b56de6c14a4ed4
Reviewed-on: https://go-review.googlesource.com/c/go/+/463838
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Run-TryBot: Quim Muntal <quimmuntal@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
(cherry picked from commit 007d8f4)
Reviewed-on: https://go-review.googlesource.com/c/go/+/466436
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Quim Muntal <quimmuntal@gmail.com>
Run-TryBot: David Chase <drchase@google.com>
romaindoumenc pushed a commit to TroutSoftware/go that referenced this issue Feb 14, 2023
@qmuntal @romaindoumenc
[release-branch.go1.20] time: update windows zoneinfo_abbrs
db0b02f 
zoneinfo_abbrs hasn't been updated since go 1.14, it's time to
regenerate it.

Fixes golang#58117.

Change-Id: Ic156ae607c46f1f5a9408b1fc0b56de6c14a4ed4
Reviewed-on: https://go-review.googlesource.com/c/go/+/463838
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Run-TryBot: Quim Muntal <quimmuntal@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
(cherry picked from commit 007d8f4)
Reviewed-on: https://go-review.googlesource.com/c/go/+/466436
Reviewed-by: Than McIntosh <thanm@google.com>
Reviewed-by: Quim Muntal <quimmuntal@gmail.com>
Run-TryBot: David Chase <drchase@google.com>
@golang golang locked and limited conversation to collaborators Feb 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge
Projects
None yet
Milestone
Go1.20.1
Development

No branches or pull requests
2 participants
@dr2chase @gopherbot