Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: go get does not work with git submodules in new versions of git #5806

Closed
gopherbot opened this issue Jun 28, 2013 · 5 comments
Closed

cmd/go: go get does not work with git submodules in new versions of git #5806

gopherbot opened this issue Jun 28, 2013 · 5 comments
Labels
ExpertNeeded FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Milestone
Go1.2

Comments

@gopherbot
Copy link

by sig.lange:

using "go get" into a workspace that contains submodules does not work in git
version 1.7.9.5 (from ubuntu precise). However, it does work in git version 1.7.0.4
(ubuntu lucid). 

On precise, Submodules have ".git" files (normally they are directories) and
this is confusing the go get command due to this line of code:

https://code.google.com/p/go/source/browse/src/cmd/go/get.go#277

Even removing the isDir() line doesn't yield success, but returns a different error.
@robpike
Copy link
Contributor

robpike commented Jul 26, 2013

Comment 1:

Labels changed: added priority-later, toolbug, expertneeded, removed priority-triage.

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Jul 30, 2013

Comment 2:

Labels changed: added suggested, go1.2maybe.

@rsc
Copy link
Contributor

rsc commented Jul 30, 2013

Comment 3:

Labels changed: added feature.

@dsymonds
Copy link
Contributor

Comment 4:

It's hard to get excited about this. VCSes are always going to have these kinds of
idiosyncrasies, and I don't think we're trying to make "go get" a universal VCS
interaction tool. It works well for 99% of cases; I suspect we could just write this off
as an unsupported use case of go get, and anyone wanting to use submodules just needs to
"cd $GOPATH/src/whatever" and run git commands directly.

@rsc
Copy link
Contributor

rsc commented Jul 31, 2013

Comment 5:

Status changed to WontFix.

@gopherbot gopherbot added wontfix ExpertNeeded Suggested Issues that may be good for new contributors looking for work to do. labels Jul 31, 2013
@rsc rsc added this to the Go1.2 milestone Apr 14, 2015
@rsc rsc removed the go1.2maybe label Apr 14, 2015
@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
ExpertNeeded FrozenDueToAge Suggested Issues that may be good for new contributors looking for work to do.
Projects
None yet
Milestone
Go1.2
Development

No branches or pull requests
4 participants
@dsymonds @rsc @robpike @gopherbot