Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls/internal/lsp/cache: unrecognized failures #58041

Closed
gopherbot opened this issue Jan 26, 2023 · 5 comments
Closed

x/tools/gopls/internal/lsp/cache: unrecognized failures #58041

gopherbot opened this issue Jan 26, 2023 · 5 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.12.0

Comments

@gopherbot
Copy link 

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cache" && test == ""

Issue created automatically to collect these failures.

Example (log):

signal: segmentation fault

— watchflakes
@gopherbot gopherbot added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 26, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jan 26, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cache" && test == ""
2023-01-25 23:57 darwin-amd64-11_0 tools@82707575 go@4df10fba x/tools/gopls/internal/lsp/cache (log) 
signal: segmentation fault
2023-01-25 23:57 darwin-amd64-11_0 tools@82707575 go@cea70301 x/tools/gopls/internal/lsp/cache (log) 
signal: segmentation fault

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cache" && test == ""
2023-01-25 23:57 darwin-amd64-10_15 tools@82707575 go@4df10fba x/tools/gopls/internal/lsp/cache (log) 
signal: segmentation fault
2023-01-25 23:57 darwin-amd64-10_15 tools@82707575 go@cea70301 x/tools/gopls/internal/lsp/cache (log) 
signal: segmentation fault

— watchflakes

@gopherbot gopherbot reopened this Feb 2, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "golang.org/x/tools/gopls/internal/lsp/cache" && test == ""
2023-01-31 21:23 windows-arm64-11 tools@407bbed8 go@ac7efcb0 x/tools/gopls/internal/lsp/cache [build] (log) 
vet.exe: failed to write analysis facts: write $WORK\b441\vet.out: There is not enough space on the disk.
golang.org/x/tools/gopls/internal/lsp/cmd.test: write C:\Users\gopher\AppData\Local\Temp\go-build956084258\b448\importcfg.link: There is not enough space on the disk.
golang.org/x/tools/gopls/internal/lsp/cmd: write C:\Users\gopher\AppData\Local\Temp\go-build956084258\b447\vet.cfg: There is not enough space on the disk.

— watchflakes

@adonovan
Copy link
Member

adonovan commented Feb 2, 2023

The ones from last week are just "signal: segmentation fault" with no further information, which makes me suspect a problem with the builder or Go toolchain rather than the x/tools code.

The report from an hour ago is a disk-full condition on the Windows builder. Possibly related to the recent filecache deletion bug, since fixed. Perhaps the fix doesn't work on Windows?

@suzmue suzmue modified the milestones: Unreleased, gopls/v0.12.0 Feb 6, 2023
@adonovan
Copy link
Member

Closing due to age.

@golang golang locked and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
Test Flakes
Status: Done
Milestone
gopls/v0.12.0
Development

No branches or pull requests
4 participants
@adonovan @suzmue @gopherbot @findleyr