Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: code lens for interfaces implemented by methods #58024

Closed
guettli opened this issue Jan 26, 2023 · 2 comments
Closed

x/tools/gopls: code lens for interfaces implemented by methods #58024

guettli opened this issue Jan 26, 2023 · 2 comments
Labels
FeatureRequest FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/backlog

Comments

@guettli
Copy link

guettli commented Jan 26, 2023

Is your feature request related to a problem? Please describe.

If I am looking at existing Go code, I would like to see immediately if this method was
implemented to satisify an interface.

For example like this screenshot from a different IDE:

image

the red up-arrow symbol on the left side shows that this method implements an interface.

It would be great to have these indicators next to the line number in vscode.

Describe alternatives you've considered

I thought about alternatives, but having a small indictor next to the line number is the only solution I have found.

Related discusssion: golang/vscode-go#1735
@findleyr
Copy link
Contributor

CC @adonovan, who has just completely reimplemented our implementations feature...

This is similar to the oft-requested feature to show the number of references via a code-lens. Both would have been impossible prior to indexing, but may be possible now.

Transferring to the gopls issue tracker.

@findleyr findleyr changed the title Indicator on methods: Show that this method implements an interface x/tools/gopls: code lens for interfaces implemented by methods Jan 26, 2023
@findleyr findleyr transferred this issue from golang/vscode-go Jan 26, 2023
@findleyr findleyr added this to the gopls/later milestone Jan 26, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 26, 2023
@findleyr
Copy link
Contributor

@hyangah points out that this is a dupe of #56695.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Jan 26, 2023
@golang golang locked and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FeatureRequest FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/backlog
Development

No branches or pull requests
3 participants
@guettli @gopherbot @findleyr