Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: disable auto brackets on function calls completions #58022

Closed
geril2207 opened this issue Jan 9, 2023 · 6 comments
Closed

x/tools/gopls: disable auto brackets on function calls completions #58022

geril2207 opened this issue Jan 9, 2023 · 6 comments
Labels
FeatureRequest gopls Issues related to the Go language server, gopls. help wanted Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/unplanned

Comments

@geril2207
Copy link

Hi guys, i want to keep settings same for all languages and would be great to have setting to disable auto brackets on function call complete suggestions like typescript.suggest.completeFunctionCalls for TypeScript.
I asked on stackoverflow but didn't get answer, maybe it's already there
@geril2207 geril2207 changed the title feature request: disable auto bracket on function calls completions feature request: disable auto brackets on function calls completions Jan 9, 2023
@adonovan
Copy link
Member

cc @findleyr

@findleyr findleyr changed the title feature request: disable auto brackets on function calls completions x/tools/gopls: disable auto brackets on function calls completions Jan 26, 2023
@findleyr findleyr transferred this issue from golang/vscode-go Jan 26, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 26, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jan 26, 2023
@findleyr
Copy link
Contributor

Thanks for the issue; I've transferred this to a gopls feature request.

@findleyr findleyr modified the milestones: Unreleased, gopls/unplanned Jan 26, 2023
@ericlohyg
Copy link

Hi, I am interested in taking this one up. Is this suitable for a first time contributor?

@gopherbot
Copy link

Change https://go.dev/cl/522181 mentions this issue: gopls/internal/lsp/source: Add ui.complete.completeFunctionCalls toggle

@hyangah
Copy link
Contributor

hyangah commented Aug 28, 2023

Is this fixing #41813?

@geril2207
Copy link
Author

@hyangah Yeah, i think so

kongjun18 added a commit to kongjun18/nvim that referenced this issue Sep 28, 2023
@kongjun18
feat(lsp): gopls doesn't complete function call parenthesis
58fa44f 
See golang/go#58022 and gopls doc **completeFunctionCalls**
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FeatureRequest gopls Issues related to the Go language server, gopls. help wanted Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/unplanned
Development

No branches or pull requests
6 participants
@hyangah @adonovan @gopherbot @ericlohyg @findleyr @geril2207