Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: "Run" buttons don't work #58013

Closed
robpike opened this issue Jan 26, 2023 · 3 comments
Closed

x/website: "Run" buttons don't work #58013

robpike opened this issue Jan 26, 2023 · 3 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done. website
Milestone
pkgsite/backlog

Comments

@robpike
Copy link
Contributor

robpike commented Jan 26, 2023 •
edited

Go to a blog page - say https://go.dev/blog/constants - and try the Run button on an example. When I do, I always get this error, albeit with more color:

package play: build constraints exclude all Go files in /tmp/sandbox497940979

Go build failed.

I am mystified what constraints would make all examples fail to run, but it's a shame that the examples have become unrunnable.
@seankhliao seankhliao changed the title website: "Run" buttons don't work x/website: "Run" buttons don't work Jan 26, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jan 26, 2023
@ianlancetaylor
Copy link
Contributor

I don't know this code but I wonder if this could be due to https://go.dev/cl/388016. The files in question all have // +build OMIT. I see some handling of strings containing "OMIT" in x/website/internal/web, and it seems possible that that handling is being skipped by the singleProxy code.

CC @jamalc

@ianlancetaylor ianlancetaylor added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 26, 2023
@hyangah hyangah added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 2, 2023
@hyangah hyangah modified the milestones: Unreleased, pkgsite/later Feb 2, 2023
@gopherbot gopherbot removed the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 2, 2023
@seankhliao
Copy link
Member

is this still broken? seems to work for me now

@robpike
Copy link
Contributor Author

robpike commented Mar 11, 2023

Working for me too. Did someone fix something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done. website
Projects
None yet
Milestone
pkgsite/backlog
Development

No branches or pull requests
5 participants
@ianlancetaylor @robpike @hyangah @gopherbot @seankhliao