Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: “not a valid tag” for commit hashes in the standard library #58004

Open
bcmills opened this issue Jan 25, 2023 · 2 comments
Open

x/pkgsite: “not a valid tag” for commit hashes in the standard library #58004

bcmills opened this issue Jan 25, 2023 · 2 comments
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Milestone
pkgsite/backlog

Comments

@bcmills
Copy link
Contributor

bcmills commented Jan 25, 2023

What is the URL of the page with the issue?

https://pkg.go.dev/context@3d49b683c6095a9a2681e84f05adfbb8d82882e8

What is your user agent?

Mozilla/5.0 (X11; CrOS x86_64 15183.78.0) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36

Screenshot

image

What did you do?

  1. Navigate to https://pkg.go.dev/context@master.
  2. See that it isn't quite up to date.
  3. Change @master to @3d49b683c6095a9a2681e84f05adfbb8d82882e8 to try to force-reload the standard library at a specific commit.

What did you expect to see?

Documentation for the context package at Go commit 3d49b68.

What did you see instead?

An error screen.
@gopherbot gopherbot added this to the Unreleased milestone Jan 25, 2023
@findleyr
Copy link
Contributor

Logic here: https://cs.opensource.google/go/x/pkgsite/+/master:internal/frontend/urlinfo.go;l=157;drc=8ea409f829091208d2d0ba4d81ecbe83b0fee9bb

I think we could just let master through, as we do for non-std packages. @jamalc is that right?

@hyangah
Copy link
Contributor

hyangah commented Feb 2, 2023

This brings up an interesting question - the stdlib code on master may depend on new, not yet released language features. The pkgsite processes the downloaded code with the newest, stable version of go, but it can be still older than the go the stdlib on master assumes.

Moreover, with the new #57001 proposal, it is almost likely that the go version in stdlib's go.mod is not known to the pkgsite in production. How should pkgsite handle the data that require newer go?

cc @golang/tools-team @rsc

@hyangah hyangah added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Feb 2, 2023
@jamalc jamalc modified the milestones: Unreleased, pkgsite/later Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. pkgsite
Projects
None yet
Milestone
pkgsite/backlog
Development

No branches or pull requests
5 participants
@hyangah @bcmills @gopherbot @jamalc @findleyr