Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestTransportClosesBodyOnError failures #57990

Closed
gopherbot opened this issue Jan 25, 2023 · 6 comments
Closed

net/http: TestTransportClosesBodyOnError failures #57990

gopherbot opened this issue Jan 25, 2023 · 6 comments
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@gopherbot
Copy link

gopherbot commented Jan 25, 2023 •
edited by bcmills 

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportClosesBodyOnError" && `timeout waiting for server handler`

Issue created automatically to collect these failures.

Example (log):

--- FAIL: TestTransportClosesBodyOnError (0.00s)
    --- FAIL: TestTransportClosesBodyOnError/h1 (10.24s)
        transport_test.go:3709: timeout waiting for server handler to complete

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 25, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestTransportClosesBodyOnError"
2023-01-17 19:53 darwin-amd64-10_15 go@3af3810a net/http.TestTransportClosesBodyOnError (log) 
--- FAIL: TestTransportClosesBodyOnError (0.00s)
    --- FAIL: TestTransportClosesBodyOnError/h1 (10.24s)
        transport_test.go:3709: timeout waiting for server handler to complete

— watchflakes

@bcmills bcmills added this to the Backlog milestone Jan 25, 2023
@bcmills
Copy link
Contributor

bcmills commented Jan 25, 2023

(attn @neild)

@gopherbot
Copy link
Author

Change https://go.dev/cl/463222 mentions this issue: net/http: remove five second timeout from TestTransportClosesBodyOnError

@gopherbot

This comment was marked as off-topic.

Sign in to view
@gopherbot

This comment was marked as off-topic.

Sign in to view
@bcmills

This comment was marked as off-topic.

Sign in to view
johanbrandhorst pushed a commit to Pryz/go that referenced this issue Feb 22, 2023
@neild @johanbrandhorst
net/http: remove five second timeout from TestTransportClosesBodyOnError
ca3c83e 
Wait forever and let the test time out with a stack trace if the
expected response doesn't happen.

Fixes golang#57990

Change-Id: I835def63db113752cdd06e03e258cb10d63a6a25
Reviewed-on: https://go-review.googlesource.com/c/go/+/463222
TryBot-Result: Gopher Robot <gobot@golang.org>
Run-TryBot: Damien Neil <dneil@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
@golang golang locked and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Test Flakes
Status: Done
Milestone
Backlog
Development

No branches or pull requests
2 participants
@bcmills @gopherbot