Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: shut down -unified and -nounified builders #57977

Closed
mdempsky opened this issue Jan 24, 2023 · 4 comments
Closed

x/build: shut down -unified and -nounified builders #57977

mdempsky opened this issue Jan 24, 2023 · 4 comments
Assignees
@mdempsky
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.21

Comments

@mdempsky
Copy link
Member

These builders aren't relevant to development at tip anymore, because we're dropping support for GOEXPERIMENT=nounified.

It probably makes sense to keep the -nounified builder just for the 1.20 release branch though, to make sure backports don't break GOEXPERIMENT=nounified.
@mdempsky mdempsky added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 24, 2023
@mdempsky mdempsky added this to the Go1.21 milestone Jan 24, 2023
@mdempsky mdempsky self-assigned this Jan 24, 2023
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jan 24, 2023
@gopherbot
Copy link

Change https://go.dev/cl/463156 mentions this issue: dashboard: only test nounified on release-branch.go1.20

@dmitshur
Copy link
Contributor

dmitshur commented Jan 24, 2023 •
edited

It probably makes sense to keep the -nounified builder just for the 1.20 release branch

@mdempsky Just confirming: is it not useful on release-branch.go1.19 because it doesn't support GOEXPERIMENT=nounified, only 1.20 does?

@mdempsky
Copy link
Member Author

mdempsky commented Jan 24, 2023 •
edited

is it not useful on release-branch.go1.19 because it doesn't support GOEXPERIMENT=nounified, only 1.20 does?

Go 1.19 uses GOEXPERIMENT=nounified by default and GOEXPERIMENT=unified wasn't yet fully supported in that release, so I don't think it needs any extra testing with respect to unified IR.

Go 1.20 is the only release that supports both settings: GOEXPERIMENT=unified by default, and GOEXPERIMENT=nounified as a fallback compatibility option.

And Go 1.21 will remove the GOEXPERIMENT option altogether.

@dmitshur
Copy link
Contributor

Makes sense, thanks.

@golang golang locked and limited conversation to collaborators Jan 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mdempsky mdempsky

Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Milestone
Go1.21
Development

No branches or pull requests
3 participants
@mdempsky @dmitshur @gopherbot