Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/website: discoverability of Security contents #57972

Open
Deleplace opened this issue Jan 24, 2023 · 4 comments
Open

x/website: discoverability of Security contents #57972

Deleplace opened this issue Jan 24, 2023 · 4 comments
Labels
FeatureRequest NeedsFix The path to resolution is known, but the work has not been done. website
Milestone
website/backlog

Comments

@Deleplace
Copy link
Contributor

There exists a nice page https://go.dev/security/ but I can't find how to navigate there from the website. As a result, some great contents like Go Fuzzing seem to be buried.

We may add a Security link in the footer, and in https://go.dev/doc/
@gopherbot gopherbot added this to the Unreleased milestone Jan 24, 2023
@findleyr
Copy link
Contributor

A Security link in the footer makes sense to me. CC @julieqiu @jamalc

@julieqiu
Copy link
Member

Agreed! It also looks like the Why Go dropdown currently links to https://go.dev/security/policy, and it should probably link to https://go.dev/security instead.

Screenshot 2023-01-27 at 12 43 21 PM

@mknyszek mknyszek added NeedsFix The path to resolution is known, but the work has not been done. FeatureRequest labels Jan 30, 2023
@Deleplace
Copy link
Contributor Author

@julieqiu as having 2 pages with similar terms can be a bit confusing, we must make sure to keep the link text consistent with the link URL.

Security -> https://go.dev/security/
Security Policy -> https://go.dev/security/policy

I agree that the former is more general, and provides a prominent access to the latter as a sub-content. So indeed it would make sense to amend the dropdown in order to link to the general "Security" page. The text "How Go can help keep you secure by default" fits well the general "Security" page and can be left unchanged.

@hyangah hyangah modified the milestones: Unreleased, website/later Feb 2, 2023
@gopherbot
Copy link

Change https://go.dev/cl/483777 mentions this issue: _content: change nav dropdown text to "Security"

gopherbot pushed a commit to golang/website that referenced this issue Apr 19, 2023
@ariathaker @gopherbot
_content: change nav dropdown text to "Security"
8d26d85 
For golang/go#57972

Change-Id: Ibad8a1ffb1a63b9bb2d45daaad53bc52455d7766
Reviewed-on: https://go-review.googlesource.com/c/website/+/483777
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Auto-Submit: Hyang-Ah Hana Kim <hyangah@gmail.com>
Auto-Submit: Julie Qiu <julieqiu@google.com>
Reviewed-by: Jamal Carvalho <jamal@golang.org>
Run-TryBot: Julie Qiu <julieqiu@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Julie Qiu <julieqiu@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FeatureRequest NeedsFix The path to resolution is known, but the work has not been done. website
Projects
None yet
Milestone
website/backlog
Development

No branches or pull requests
6 participants
@mknyszek @hyangah @julieqiu @gopherbot @Deleplace @findleyr