Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: double magnifying glass icons in search input element on iOS #57948

Closed
willfaught opened this issue Jan 21, 2023 · 6 comments
Closed

x/pkgsite: double magnifying glass icons in search input element on iOS #57948

willfaught opened this issue Jan 21, 2023 · 6 comments
Labels
NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Milestone
pkgsite/backlog

Comments

@willfaught
Copy link
Contributor

What is the URL of the page with the issue?

pkg.go.dev

What is your user agent?

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.2 Safari/605.1.15

Screenshot

IMG_0212

What did you do?

Navigate there in iOS 16.2 Safari.

What did you expect to see?

One magnifying glass icon by the input element.

Moving the cursor to the far left, the input element retains focus and you can still type.

What did you see instead?

Two magnifying glass icons by the input element.

When I typed "pow", then moved the cursor back to the beginning of the input, and then past it to the left, the cursor is lost, and you have to tap the input element again for it to have focus. I assume these two issues are related.
@gopherbot gopherbot added this to the Unreleased milestone Jan 21, 2023
@earthboundkid
Copy link
Contributor

This has bothered me forever but I’m always immediately distracted and forget to file a bug. Thank you.

@findleyr
Copy link
Contributor

CC @jamalc

@hyangah
Copy link
Contributor

hyangah commented Feb 2, 2023

Either make it type="text" or
skip pkgsite's own icon for Safari or
disable the browser styling with css magic.

@hyangah hyangah added the NeedsFix The path to resolution is known, but the work has not been done. label Feb 2, 2023
@hyangah hyangah modified the milestones: Unreleased, pkgsite/later Feb 2, 2023
@gopherbot
Copy link

Change https://go.dev/cl/503075 mentions this issue: static/frontend: fix double search glass icon on search field

@earthboundkid
Copy link
Contributor

IMG_5265

Is this supposed to have deployed yet?

@jamalc
Copy link

jamalc commented Jun 21, 2023

No, gopherbot closes related issues after a fix is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
NeedsFix The path to resolution is known, but the work has not been done. pkgsite
Projects
None yet
Milestone
pkgsite/backlog
Development

No branches or pull requests
6 participants
@willfaught @earthboundkid @hyangah @gopherbot @jamalc @findleyr