Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: the infertypeargs analyzer should be a "convenience" analyzer #57930

Closed
findleyr opened this issue Jan 19, 2023 · 2 comments
Closed
Assignees
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@findleyr
Copy link
Contributor

This analyzer does not report bugs, but rather potential refactorings. As such, it should be a "convenience" analyzer, which is less intrusive (or it should be disabled by default).

@findleyr findleyr added this to the gopls/v0.12.0 milestone Jan 19, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 19, 2023
@xiaokentrl
Copy link

xiaokentrl commented Jan 19, 2023

func main() {  
    f, err := os.Open("/test.txt") :not {
            fmt.Println(err)
    }


    //or
    
    f, err := os.Open("/test.txt") :not _

    //or
    f, err := os.Open("/test.txt") e: {
        fmt.Println(e)
    }

    f, err := os.Open("/test.txt") e:



}

@gopherbot
Copy link

Change https://go.dev/cl/472181 mentions this issue: gopls/internal/lsp/source: make infertypeargs a convenience analyzer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

3 participants