Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/vet: include CL 462438 in Go 1.20 [1.20 backport] #57904

Closed
gopherbot opened this issue Jan 18, 2023 · 2 comments
Closed

cmd/vet: include CL 462438 in Go 1.20 [1.20 backport] #57904

gopherbot opened this issue Jan 18, 2023 · 2 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Milestone
Go1.20

Comments

@gopherbot
Copy link

@rsc requested issue #57903 to be considered for backport to the next 1.20 minor release.

@gopherbot please backport Go 1.20
@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jan 18, 2023
@gopherbot gopherbot mentioned this issue Jan 18, 2023
Closed
@cherrymui cherrymui added the CherryPickApproved Used during the release process for point releases label Jan 18, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jan 18, 2023
@cherrymui cherrymui added this to the Go1.20 milestone Jan 18, 2023
@gopherbot
Copy link
Author

Change https://go.dev/cl/462555 mentions this issue: cmd: update x/tools to latest internal Go 1.20 branch

@gopherbot
Copy link
Author

Change https://go.dev/cl/462695 mentions this issue: [release-branch.go1.20] cmd: update x/tools to latest internal Go 1.20 branch

gopherbot pushed a commit that referenced this issue Jan 18, 2023
@rsc @gopherbot
[release-branch.go1.20] cmd: update x/tools to latest internal Go 1.2…
8b34676 
…0 branch

Import x/tools as of CL 462596 (070db2996ebe, Jan 18 2022),
to bring in two vet analysis fixes (printf and loopclosure).

For #57911.
Fixes #57903.
Fixes #57904.

Change-Id: I82fe4e9bd56fb8e64394ee8618c155316942a517
Reviewed-on: https://go-review.googlesource.com/c/go/+/462555
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Auto-Submit: Russ Cox <rsc@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-on: https://go-review.googlesource.com/c/go/+/462695
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Ian Lance Taylor <iant@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
@golang golang locked and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge release-blocker
Projects
None yet
Milestone
Go1.20
Development

No branches or pull requests
3 participants
@rsc @gopherbot @cherrymui