Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/tools/gopls: tests leave behind a lot of data in .cache/gopls #57900

Closed
findleyr opened this issue Jan 18, 2023 · 14 comments
Closed

x/tools/gopls: tests leave behind a lot of data in .cache/gopls #57900

findleyr opened this issue Jan 18, 2023 · 14 comments
Assignees
Labels
gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone

Comments

@findleyr
Copy link
Contributor

findleyr commented Jan 18, 2023

#!watchflakes
post <- repo == "tools" && builder == "aix-ppc64"

Starting last night, the aix-ppc64 builder started failing frequently on both the main repo and x/tools. (I noticed because watchflakes filed ~30 flakes for x/tools tests related to aix-ppc64).

CC @golang/release

@findleyr
Copy link
Contributor Author

Ah, this appears to be the problem:
/.cache/gopls/7f4281e2/analysis/13: no space left on device

CC @adonovan, in case this is related to gopls file caching.

@findleyr findleyr changed the title x/build: frequent test failures on aix-ppc64 x/build: frequent test failures due to no space on aix-ppc64 builder Jan 18, 2023
This was referenced Jan 18, 2023
@bcmills bcmills changed the title x/build: frequent test failures due to no space on aix-ppc64 builder x/tools/gopls: tests leave behind a lot of data in .cache/gopls Jan 18, 2023
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jan 18, 2023
@bcmills bcmills added Tools This label describes issues relating to any tools in the x/tools repository. Testing An issue that has been verified to require only test changes, not just a test failure. and removed Builders x/build issues (builders, bots, dashboards) Tools This label describes issues relating to any tools in the x/tools repository. labels Jan 18, 2023
@bcmills
Copy link
Contributor

bcmills commented Jan 18, 2023

Independently, we should double-check the gopls cache invalidation logic to make sure we don't end up consuming too much space in end users' .cache directories. 😅

@findleyr
Copy link
Contributor Author

If this is fixed in the builder, we can repurpose this issue for following up on cache usage.

@bcmills thank you for investigating.

@adonovan
Copy link
Member

adonovan commented Jan 18, 2023

I think this is a defect in the gopls test suite: it appears to me that the tests are leaving behind a lot of data in ~/.cache/gopls.

I think you're right. I suspect that because it takes so long (over a minute) just to walk the directory tree at full speed, at least on some machines, none of the test processes ever even starts sweeping garbage before it is terminated. And filecache (intentionally) scans about 25x slower than full speed.

@gopherbot
Copy link

Change https://go.dev/cl/462597 mentions this issue: gopls/internal/lsp/filecache: delete old files aggressively

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- repo == "tools" && builder == "aix-ppc64"
2023-01-17 23:21 aix-ppc64 tools@f3e53e5c go@7e740f91 x/tools/gopls/internal/regtest/completion.TestLSP (log)
--- FAIL: TestLSP (71.76s)
    --- FAIL: TestLSP/Modules (21.85s)
        --- FAIL: TestLSP/Modules/Diagnostics (0.78s)
            --- FAIL: TestLSP/Modules/Diagnostics/generator (0.78s)
                lsp_test.go:224: generator.go:3:5-3:6: unmatched diagnostic pattern "x declared (and|but) not used"
            --- FAIL: TestLSP/Modules/Diagnostics/badstmt (0.00s)
                lsp_test.go:224: badstmt.go:10:12-10:15: unmatched diagnostic pattern "function must be invoked in defer statement|expression in defer must be function call"
                lsp_test.go:224: badstmt.go:12:3-12:5: unmatched diagnostic pattern "no new variables"
            --- FAIL: TestLSP/Modules/Diagnostics/rundespiteerrors (0.00s)
                lsp_test.go:224: rundespiteerrors.go:6:5-6:6: unmatched diagnostic pattern "mismatched types|cannot convert"
            --- FAIL: TestLSP/Modules/Diagnostics/bad_test (0.00s)
                lsp_test.go:224: bad_test.go:9:0-9:0: unmatched diagnostic pattern "Testbad has malformed name: first letter after 'Test' must not be lowercase"
                lsp_test.go:224: bad_test.go:11:5-11:6: unmatched diagnostic pattern "assignment copies lock value to _: sync.Mutex"
                lsp_test.go:224: bad_test.go:13:1-13:20: unmatched diagnostic pattern "golang.org/lsptests/analyzer.printfWrapper format %s reads arg #1, but call has 0 args"
                lsp_test.go:224: bad_test.go:22:25-22:35: unmatched diagnostic pattern "2006-02-01 should be 2006-01-02"
            --- FAIL: TestLSP/Modules/Diagnostics/var (0.00s)
                lsp_test.go:224: var.go:3:11-3:12: unmatched diagnostic pattern "(undeclared name|undefined): y"
                lsp_test.go:224: var.go:6:17-6:18: unmatched diagnostic pattern "(undeclared name|undefined): n"
                lsp_test.go:224: var.go:9:5-9:6: unmatched diagnostic pattern "(undeclared name|undefined): i"
                lsp_test.go:224: var.go:11:1-11:2: unmatched diagnostic pattern "(undeclared name|undefined): r"
...
            --- FAIL: TestLSP/MultiModule/MethodExtraction/extract_basic_13_2 (0.00s)
                lsp_test.go:647: internal error updating shared cache: write /.cache/gopls/3b795cd1/analysis/5a/5a1c242c62c9a14b94f80c868091627ed8c3d3ce5f3758f1daa2befaf3749b39.tmp.7914374889194164709: no space left on device
            --- FAIL: TestLSP/MultiModule/MethodExtraction/extract_basic_14_2 (0.00s)
                lsp_test.go:647: internal error updating shared cache: write /.cache/gopls/3b795cd1/analysis/5a/5a1c242c62c9a14b94f80c868091627ed8c3d3ce5f3758f1daa2befaf3749b39.tmp.7914374889194164709: no space left on device
            --- FAIL: TestLSP/MultiModule/MethodExtraction/extract_basic_18_2 (0.00s)
                lsp_test.go:647: internal error updating shared cache: write /.cache/gopls/3b795cd1/analysis/5a/5a1c242c62c9a14b94f80c868091627ed8c3d3ce5f3758f1daa2befaf3749b39.tmp.7914374889194164709: no space left on device
            --- FAIL: TestLSP/MultiModule/MethodExtraction/extract_basic_22_2 (0.00s)
                lsp_test.go:647: internal error updating shared cache: write /.cache/gopls/3b795cd1/analysis/5a/5a1c242c62c9a14b94f80c868091627ed8c3d3ce5f3758f1daa2befaf3749b39.tmp.7914374889194164709: no space left on device
            --- FAIL: TestLSP/MultiModule/MethodExtraction/extract_basic_23_2 (0.00s)
                lsp_test.go:647: internal error updating shared cache: write /.cache/gopls/3b795cd1/analysis/5a/5a1c242c62c9a14b94f80c868091627ed8c3d3ce5f3758f1daa2befaf3749b39.tmp.7914374889194164709: no space left on device
2023-01-17 23:21 aix-ppc64 tools@f3e53e5c go@7e740f91 x/tools/gopls/internal/regtest/completion.TestCapabilities (log)
2023/01/18 01:23:29 New session
	create_session=1
2023/01/18 01:23:29 go info for /ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/fake3182915598
(go dir /ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/fake3182915598)
(go version go version devel 7e740f91c52c6b56d5e2af9c5295e5397565556c aix/ppc64)
(valid build configuration = true)
(build flags: [])
(selected go env: [GO111MODULE=, GOCACHE=/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gocache, GOFLAGS=, GOMODCACHE=/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/pkg/mod, GOPATH=/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath, GOPRIVATE=, GOROOT=/ramdisk8GB/workdir-host-aix-ppc64-osuosl/go, GOWORK=])

2023/01/18 01:23:29 go/packages.Load #1
...
	directory=file:///ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/fake3182915598
	package="fake"
2023/01/18 01:23:30 warning: analyzing package: internal error updating shared cache: write /.cache/gopls/3a493f4b/analysis/85/85265121b29bc9434dc53ced745a5dd1d8373c25d13036c487b678919db804a3.tmp.6779318729808917382: no space left on device
	snapshot=2
	directory=file:///ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/fake3182915598
	package="fake"
2023/01/18 01:23:30 Shutdown session
	shutdown_session=1
--- FAIL: TestCapabilities (1.22s)
    capabilities_test.go:99: internal error updating shared cache: write /.cache/gopls/3a493f4b/analysis/c5/c5970eb46f50c61131921d0aca7890b4f375c9abca41525a2996a286ebb72933.tmp.8209946457679123689: no space left on device
2023-01-17 23:21 aix-ppc64 tools@f3e53e5c go@7e740f91 x/tools/gopls/internal/regtest/completion.TestBasics (log)
--- FAIL: TestBasics (0.02s)
    filecache_test.go:39: Set failed: write /.cache/gopls/e5c0c4cb/TestBasics/e6/e6bc43ac9d8c6815bba289e16bfa1cac3afde9a8e3313267b2d94c2c8a9df0d6.tmp.6188516273261378957: no space left on device
    filecache_test.go:44: Get after Set failed: not found
2023-01-17 23:21 aix-ppc64 tools@f3e53e5c go@7e740f91 x/tools/gopls/internal/regtest/completion.TestConcurrency (log)
--- FAIL: TestConcurrency (0.06s)
    filecache_test.go:99: open /.cache/gopls/e5c0c4cb/TestConcurrency/8c/8cdbbab787f5fd3a83e114f79f6e545d7af12133e8a1135bdf9ffbc502a787ba.tmp.4450441912424730822: no space left on device
2023-01-17 23:21 aix-ppc64 tools@f3e53e5c go@7e740f91 x/tools/gopls/internal/regtest/completion.TestIPC (log)
--- FAIL: TestIPC (0.00s)
    filecache_test.go:124: Set: write /.cache/gopls/e5c0c4cb/TestIPC/f9/f9067d540b7190ff82b55f032c0d190010df52cc64693b6e45081a44a22f44a4.tmp.7157615454072940601: no space left on device
2023-01-17 23:21 aix-ppc64 tools@f3e53e5c go@7e740f91 x/tools/gopls/internal/regtest/completion.TestSource (log)
--- FAIL: TestSource (58.89s)
    --- FAIL: TestSource/Modules (19.89s)
        --- FAIL: TestSource/Modules/Diagnostics (0.36s)
            --- FAIL: TestSource/Modules/Diagnostics/bad0 (0.09s)
                source_test.go:160: internal error updating shared cache: write /.cache/gopls/ebd83d24/analysis/8b/8bd38ed79d1091ab72c1f9acfc5d9333c141c300bda96af64e4433130b1b9e25.tmp.1235549359673107829: no space left on device
            --- FAIL: TestSource/Modules/Diagnostics/generator (0.01s)
                source_test.go:160: internal error updating shared cache: write /.cache/gopls/ebd83d24/analysis/7c/7c72dca9cb521b47e19a88d7881fb26a69cb789bdf6d2e3b82e19dd47225ee68.tmp.4860761094108526713: no space left on device
            --- FAIL: TestSource/Modules/Diagnostics/bad_test (0.24s)
                source_test.go:160: internal error updating shared cache: write /.cache/gopls/ebd83d24/analysis/a4/a40dcc6c451179f17ee746c005eb65dbcfb0ee57421ee1932b3cd34c69c44889.tmp.9004313941721840562: no space left on device
            --- FAIL: TestSource/Modules/Diagnostics/rundespiteerrors (0.00s)
...
            --- FAIL: TestSource/Modules/Diagnostics/bad1 (0.00s)
                source_test.go:160: internal error updating shared cache: write /.cache/gopls/ebd83d24/analysis/8b/8bd38ed79d1091ab72c1f9acfc5d9333c141c300bda96af64e4433130b1b9e25.tmp.1235549359673107829: no space left on device
            --- FAIL: TestSource/Modules/Diagnostics/noparse (0.00s)
                source_test.go:160: internal error updating shared cache: mkdir /.cache/gopls/ebd83d24/analysis/b5: no space left on device
            --- FAIL: TestSource/Modules/Diagnostics/bad_format (0.00s)
                source_test.go:160: internal error updating shared cache: write /.cache/gopls/ebd83d24/analysis/a4/a40dcc6c451179f17ee746c005eb65dbcfb0ee57421ee1932b3cd34c69c44889.tmp.9004313941721840562: no space left on device
            --- FAIL: TestSource/Modules/Diagnostics/badstmt (0.00s)
                source_test.go:160: internal error updating shared cache: mkdir /.cache/gopls/ebd83d24/analysis/f8: no space left on device
            --- FAIL: TestSource/Modules/Diagnostics/var (0.00s)
                source_test.go:160: internal error updating shared cache: mkdir /.cache/gopls/ebd83d24/analysis/aa: no space left on device
...
            --- FAIL: TestSource/MultiModule/Diagnostics/noparse (0.00s)
                source_test.go:160: internal error updating shared cache: mkdir /.cache/gopls/ebd83d24/analysis/77: no space left on device
            --- FAIL: TestSource/MultiModule/Diagnostics/noparse_format (0.00s)
                source_test.go:160: internal error updating shared cache: write /.cache/gopls/ebd83d24/analysis/7c/7cd1f829f9d30a7e273c6cd16e1396841b64a20479a9a327240f969935f2360a.tmp.7651165714896423336: no space left on device
            --- FAIL: TestSource/MultiModule/Diagnostics/badstmt (0.00s)
                source_test.go:160: internal error updating shared cache: mkdir /.cache/gopls/ebd83d24/analysis/a5: no space left on device
            --- FAIL: TestSource/MultiModule/Diagnostics/generator (0.00s)
                source_test.go:160: internal error updating shared cache: mkdir /.cache/gopls/ebd83d24/analysis/99: no space left on device
            --- FAIL: TestSource/MultiModule/Diagnostics/bad0 (0.00s)
                source_test.go:160: internal error updating shared cache: mkdir /.cache/gopls/ebd83d24/analysis/5a: no space left on device
2023-01-17 23:21 aix-ppc64 tools@f3e53e5c go@7e740f91 x/tools/gopls/internal/regtest/completion.TestRegenerateCgo (log)
#### Start Gopls Test Logs for "TestRegenerateCgo/default"
[Trace - 01:23:58.834 AM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/gopls-regtest-3077163984/TestRegenerateCgo/default/gopath","GOPROXY":"file:///ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/gopls-regtest-3077163984/TestRegenerateCgo/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/gopls-regtest-3077163984/TestRegenerateCgo/default/work","name":"work"}]}


[Trace - 01:23:58.836 AM] Received response 'initialize - (1)' in 2ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":{"documentSelector":null},"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel 7e740f91c52c6b56d5e2af9c5295e5397565556c\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 01:23:58.837 AM] Sending notification 'initialized'.
...
--- FAIL: TestRegenerateCgo (1.71s)
    --- FAIL: TestRegenerateCgo/default (1.65s)
        env.go:322: waiting on:
            Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 1 time(s)" is met, must have:
            any diagnostics at the first position matching `` in "cgo.go", with message containing "go list failed to return CompiledGoFiles"

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...

[Trace - 01:24:01.994 AM] Received notification '$/progress'.
Params: {"token":"8787642733408487110","value":{"kind":"end","message":"Done."}}


[Trace - 01:24:01.995 AM] Received notification 'window/logMessage'.
Params: {"type":1,"message":"2023/01/18 01:24:01 warning: analyzing package: internal error updating shared cache: mkdir /.cache/gopls/b186a8fe/analysis/82: no space left on device\n\tsnapshot=1\n\tdirectory=file:///ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/gopls-regtest-3077163984/TestGCDetails_Toggle/default/work\n\tpackage=\"mod.com\"\n"}


#### End Gopls Test Logs for "TestGCDetails_Toggle/default"
2023-01-17 23:21 aix-ppc64 tools@f3e53e5c go@7e740f91 x/tools/gopls/internal/regtest/completion.TestGCDetails_Toggle (log)
--- FAIL: TestGCDetails_Toggle (559.66s)
    --- FAIL: TestGCDetails_Toggle/default (559.66s)
        env.go:322: waiting on:
            Unmet: once "any diagnostics at main.go:5:13" is met, must have:
            read diagnostics for "main.go"

            err:context deadline exceeded

            state:
            #### log messages (see RPC logs for full text):
            	Info: "2023/01/18 01:24:00 go info for /ramdisk8GB/workdi...
            	Info: "2023/01/18 01:24:01 go/packages.Load #28\n\tsnapsh...
            	Info: "2023/01/18 01:24:01 go/packages.Load #28: updating...
            	Error: "2023/01/18 01:24:01 warning: analyzing package: i...
            	Error: "2023/01/18 01:24:01 warning: analyzing package: i...
            	Error: "2023/01/18 01:24:01 warning: analyzing package: i...

            #### diagnostics:
            	main.go (version 1):

            #### outstanding work:
            #### completed work:
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
            	diagnosing opened files: 1
            	Toggling GC Details: 1
2023-01-17 23:21 aix-ppc64 tools@f3e53e5c go@7e740f91 x/tools/gopls/internal/regtest/completion.TestUndownloadedModule (log)
--- FAIL: TestUndownloadedModule (1.77s)
    --- FAIL: TestUndownloadedModule/default (1.77s)
        completion_test.go:355: organizing imports before save: internal error updating shared cache: mkdir /.cache/gopls/0bdba3ae/analysis/a2: no space left on device
2023-01-17 23:21 aix-ppc64 tools@f3e53e5c go@7e740f91 x/tools/gopls/internal/regtest/inlayhints (log)
2023/01/18 01:23:53 can't create cache: mkdir /.cache/gopls/2cefdfe0: no space left on device
2023-01-18 15:15 aix-ppc64 tools@2fa6ca1e go@7026a8a1 x/tools/gopls/internal/regtest/codelens.TestLSP (log)
--- FAIL: TestLSP (72.65s)
    --- FAIL: TestLSP/Modules (21.73s)
        --- FAIL: TestLSP/Modules/Diagnostics (0.80s)
            --- FAIL: TestLSP/Modules/Diagnostics/bad1 (0.79s)
                lsp_test.go:224: bad1.go:8:6-8:13: unmatched diagnostic pattern "(undeclared name|undefined): unknown"
                lsp_test.go:224: bad1.go:16:1-16:2: unmatched diagnostic pattern "x declared (and|but) not used"
                lsp_test.go:224: bad1.go:17:5-17:6: unmatched diagnostic pattern "q declared (and|but) not used"
                lsp_test.go:224: bad1.go:17:7-17:11: unmatched diagnostic pattern "(undeclared name|undefined): blah"
                lsp_test.go:224: bad1.go:18:5-18:6: unmatched diagnostic pattern "t declared (and|but) not used"
                lsp_test.go:224: bad1.go:18:9-18:13: unmatched diagnostic pattern "(undeclared name|undefined): blob"
...
            --- FAIL: TestLSP/Modules/Diagnostics/bad_format (0.00s)
                lsp_test.go:224: bad_format.go:13:5-13:6: unmatched diagnostic pattern "x declared (and|but) not used"
            --- FAIL: TestLSP/Modules/Diagnostics/noparse_format (0.00s)
                lsp_test.go:224: noparse_format.go:9:4-9:5: unmatched diagnostic pattern "missing condition in if statement"
                lsp_test.go:224: noparse_format.go:11:4-11:6: unmatched diagnostic pattern "no new variables"
            --- FAIL: TestLSP/Modules/Diagnostics/generated (0.00s)
                lsp_test.go:224: generated.go:5:5-5:6: unmatched diagnostic pattern "y declared (and|but) not used"
            --- FAIL: TestLSP/Modules/Diagnostics/noparse (0.00s)
                lsp_test.go:224: noparse.go:16:3-16:5: unmatched diagnostic pattern "no new variables"
                lsp_test.go:224: noparse.go:23:5-23:6: unmatched diagnostic pattern "expected 'IDENT', found '.'"
...
            --- FAIL: TestLSP/MultiModule/MethodExtraction/extract_basic_13_2 (0.00s)
                lsp_test.go:647: internal error updating shared cache: mkdir /.cache/gopls/c201e786/analysis/91: no space left on device
            --- FAIL: TestLSP/MultiModule/MethodExtraction/extract_basic_14_2 (0.00s)
                lsp_test.go:647: internal error updating shared cache: mkdir /.cache/gopls/c201e786/analysis/91: no space left on device
            --- FAIL: TestLSP/MultiModule/MethodExtraction/extract_basic_18_2 (0.00s)
                lsp_test.go:647: internal error updating shared cache: mkdir /.cache/gopls/c201e786/analysis/91: no space left on device
            --- FAIL: TestLSP/MultiModule/MethodExtraction/extract_basic_22_2 (0.00s)
                lsp_test.go:647: internal error updating shared cache: mkdir /.cache/gopls/c201e786/analysis/91: no space left on device
            --- FAIL: TestLSP/MultiModule/MethodExtraction/extract_basic_23_2 (0.00s)
                lsp_test.go:647: internal error updating shared cache: mkdir /.cache/gopls/c201e786/analysis/91: no space left on device
2023-01-18 15:15 aix-ppc64 tools@2fa6ca1e go@7026a8a1 x/tools/gopls/internal/regtest/codelens.TestCapabilities (log)
2023/01/18 10:21:21 New session
	create_session=1
2023/01/18 10:21:21 go info for /ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/fake3646303764
(go dir /ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/fake3646303764)
(go version go version devel 7026a8a1a9aba58285b3cae215df04140245b6db aix/ppc64)
(valid build configuration = true)
(build flags: [])
(selected go env: [GO111MODULE=, GOCACHE=/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gocache, GOFLAGS=, GOMODCACHE=/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/pkg/mod, GOPATH=/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath, GOPRIVATE=, GOROOT=/ramdisk8GB/workdir-host-aix-ppc64-osuosl/go, GOWORK=])

2023/01/18 10:21:21 go/packages.Load #1
...
	directory=file:///ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/fake3646303764
	package="fake"
2023/01/18 10:21:22 warning: analyzing package: internal error updating shared cache: write /.cache/gopls/56751866/analysis/14/14b5b9d44450562d36c1e86fb4705a9f9a75b8843938ff058d5829935b3cc761.tmp.7621954752140244082: no space left on device
	snapshot=2
	directory=file:///ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/fake3646303764
	package="fake"
2023/01/18 10:21:22 Shutdown session
	shutdown_session=1
--- FAIL: TestCapabilities (1.12s)
    capabilities_test.go:99: internal error updating shared cache: write /.cache/gopls/56751866/analysis/a6/a64b48cc893112dd1d2502ec3365dffe3070a061107094ac1d76a25d538a2ed1.tmp.4009723660530232363: no space left on device
2023-01-18 15:15 aix-ppc64 tools@2fa6ca1e go@7026a8a1 x/tools/gopls/internal/regtest/codelens.TestBasics (log)
--- FAIL: TestBasics (0.02s)
    filecache_test.go:39: Set failed: write /.cache/gopls/45667bd5/TestBasics/41/41a798d9e96cd031a51e7970dddb3d120333b2f7c438cfe6c45da26c4cb97de8.tmp.4912140303740892178: no space left on device
    filecache_test.go:44: Get after Set failed: not found
2023-01-18 15:15 aix-ppc64 tools@2fa6ca1e go@7026a8a1 x/tools/gopls/internal/regtest/codelens.TestConcurrency (log)
--- FAIL: TestConcurrency (0.06s)
    filecache_test.go:99: write /.cache/gopls/45667bd5/TestConcurrency/02/023103f8aa194203171ebbe811bee404c7e2055194e08c5e844900d9614053cf.tmp.8899869678900295760: no space left on device
2023-01-18 15:15 aix-ppc64 tools@2fa6ca1e go@7026a8a1 x/tools/gopls/internal/regtest/codelens.TestIPC (log)
--- FAIL: TestIPC (0.01s)
    filecache_test.go:124: Set: write /.cache/gopls/45667bd5/TestIPC/19/192f3b9990d776814ff8c2065d19d6dc1e57450de4f4a78698c6cf99fc5847b2.tmp.812035947652641871: no space left on device
2023-01-18 15:15 aix-ppc64 tools@2fa6ca1e go@7026a8a1 x/tools/gopls/internal/regtest/codelens.TestSource (log)
--- FAIL: TestSource (60.00s)
    --- FAIL: TestSource/Modules (18.98s)
        --- FAIL: TestSource/Modules/Diagnostics (0.35s)
            --- FAIL: TestSource/Modules/Diagnostics/noparse_format (0.09s)
                source_test.go:160: internal error updating shared cache: write /.cache/gopls/41ff672e/analysis/39/39ccd4efd71582ee7a4e41ad9c29fb95a7d3f56fbeb6a7d01ff7883ba32179b9.tmp.6607179575278293581: no space left on device
            --- FAIL: TestSource/Modules/Diagnostics/a_x_test (0.24s)
                source_test.go:160: internal error updating shared cache: write /.cache/gopls/41ff672e/analysis/a4/a40dcc6c451179f17ee746c005eb65dbcfb0ee57421ee1932b3cd34c69c44889.tmp.3184074338617157011: no space left on device
            --- FAIL: TestSource/Modules/Diagnostics/bad_test (0.00s)
                source_test.go:160: internal error updating shared cache: write /.cache/gopls/41ff672e/analysis/a4/a40dcc6c451179f17ee746c005eb65dbcfb0ee57421ee1932b3cd34c69c44889.tmp.3184074338617157011: no space left on device
            --- FAIL: TestSource/Modules/Diagnostics/badstmt (0.00s)
...
            --- FAIL: TestSource/Modules/Diagnostics/bad1 (0.00s)
                source_test.go:160: internal error updating shared cache: mkdir /.cache/gopls/41ff672e/analysis/b4: no space left on device
            --- FAIL: TestSource/Modules/Diagnostics/generated (0.00s)
                source_test.go:160: internal error updating shared cache: mkdir /.cache/gopls/41ff672e/analysis/55: no space left on device
            --- FAIL: TestSource/Modules/Diagnostics/noparse (0.00s)
                source_test.go:160: internal error updating shared cache: mkdir /.cache/gopls/41ff672e/analysis/a5: no space left on device
            --- FAIL: TestSource/Modules/Diagnostics/good0 (0.00s)
                source_test.go:160: internal error updating shared cache: mkdir /.cache/gopls/41ff672e/analysis/0b: no space left on device
            --- FAIL: TestSource/Modules/Diagnostics/generator (0.00s)
                source_test.go:160: internal error updating shared cache: mkdir /.cache/gopls/41ff672e/analysis/55: no space left on device
...
            --- FAIL: TestSource/MultiModule/Diagnostics/generated (0.00s)
                source_test.go:160: internal error updating shared cache: mkdir /.cache/gopls/41ff672e/analysis/01: no space left on device
            --- FAIL: TestSource/MultiModule/Diagnostics/badstmt (0.00s)
                source_test.go:160: internal error updating shared cache: mkdir /.cache/gopls/41ff672e/analysis/d4: no space left on device
            --- FAIL: TestSource/MultiModule/Diagnostics/bad_format (0.00s)
                source_test.go:160: internal error updating shared cache: mkdir /.cache/gopls/41ff672e/analysis/85: no space left on device
            --- FAIL: TestSource/MultiModule/Diagnostics/noparse (0.00s)
                source_test.go:160: internal error updating shared cache: mkdir /.cache/gopls/41ff672e/analysis/3b: no space left on device
            --- FAIL: TestSource/MultiModule/Diagnostics/rundespiteerrors (0.00s)
                source_test.go:160: internal error updating shared cache: mkdir /.cache/gopls/41ff672e/analysis/f8: no space left on device
2023-01-18 15:15 aix-ppc64 tools@2fa6ca1e go@7026a8a1 x/tools/gopls/internal/regtest/codelens.TestRegenerateCgo (log)
#### Start Gopls Test Logs for "TestRegenerateCgo/default"
[Trace - 10:21:50.761 AM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"commitCharactersSupport":false,"documentationFormat":null,"deprecatedSupport":false,"preselectSupport":false,"tagSupport":{"valueSet":[1]},"insertReplaceSupport":false,"resolveSupport":{"properties":null},"insertTextModeSupport":{"valueSet":null},"labelDetailsSupport":false}},"hover":{},"documentSymbol":{},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"rename":{},"foldingRange":{},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":false,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/gopls-regtest-2158361668/TestRegenerateCgo/default/gopath","GOPROXY":"file:///ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/gopls-regtest-2158361668/TestRegenerateCgo/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/gopls-regtest-2158361668/TestRegenerateCgo/default/work","name":"work"}]}


[Trace - 10:21:50.762 AM] Received response 'initialize - (1)' in 1ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":{"documentSelector":null},"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"},"fileOperations":{}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel 7026a8a1a9aba58285b3cae215df04140245b6db\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 10:21:50.763 AM] Sending notification 'initialized'.
...
--- FAIL: TestRegenerateCgo (1.60s)
    --- FAIL: TestRegenerateCgo/default (1.57s)
        env.go:322: waiting on:
            Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 1 time(s)" is met, must have:
            any diagnostics at the first position matching `` in "cgo.go", with message containing "go list failed to return CompiledGoFiles"

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...

[Trace - 10:21:54.039 AM] Received notification 'window/logMessage'.
Params: {"type":1,"message":"2023/01/18 10:21:54 warning: analyzing package: internal error updating shared cache: write /.cache/gopls/f4662edf/analysis/a4/a40dcc6c451179f17ee746c005eb65dbcfb0ee57421ee1932b3cd34c69c44889.tmp.3485104812414732449: no space left on device\n\tsnapshot=1\n\tdirectory=file:///ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/gopls-regtest-2158361668/TestGCDetails_Toggle/default/work\n\tpackage=\"mod.com\"\n"}


[Trace - 10:21:54.040 AM] Received notification '$/progress'.
Params: {"token":"2301814445484628398","value":{"kind":"end","message":"Done."}}


#### End Gopls Test Logs for "TestGCDetails_Toggle/default"
2023-01-18 15:15 aix-ppc64 tools@2fa6ca1e go@7026a8a1 x/tools/gopls/internal/regtest/codelens.TestGCDetails_Toggle (log)
--- FAIL: TestGCDetails_Toggle (559.79s)
    --- FAIL: TestGCDetails_Toggle/default (559.79s)
        env.go:322: waiting on:
            Unmet: once "any diagnostics at main.go:5:13" is met, must have:
            read diagnostics for "main.go"

            err:context deadline exceeded

            state:
            #### log messages (see RPC logs for full text):
            	Info: "2023/01/18 10:21:52 go info for /ramdisk8GB/workdi...
            	Info: "2023/01/18 10:21:53 go/packages.Load #28\n\tsnapsh...
            	Info: "2023/01/18 10:21:53 go/packages.Load #28: updating...
            	Error: "2023/01/18 10:21:54 warning: analyzing package: i...
            	Error: "2023/01/18 10:21:54 warning: analyzing package: i...
            	Error: "2023/01/18 10:21:54 warning: analyzing package: i...

            #### diagnostics:
            	main.go (version 1):

            #### outstanding work:
            #### completed work:
            	diagnosing opened files: 1
            	Toggling GC Details: 1
            	diagnosing initial workspace load: 1
            	Setting up workspace: 1
2023-01-18 15:15 aix-ppc64 tools@2fa6ca1e go@7026a8a1 x/tools/gopls/internal/regtest/completion (log)
2023/01/18 10:21:44 can't create cache: mkdir /.cache/gopls/2f50cb10: no space left on device
2023-01-18 15:15 aix-ppc64 tools@2fa6ca1e go@7026a8a1 x/tools/gopls/test.TestMissingPatternDiagnostic (log)
--- FAIL: TestMissingPatternDiagnostic (2.24s)
    --- FAIL: TestMissingPatternDiagnostic/default (2.24s)
        env.go:322: waiting on:
            Unmeetable: once "All of:\ncompleted work \"diagnosing opened files\" at least 1 time(s)" is met, must have:
            any diagnostics at the first position matching `NONEXISTENT` in "x.go", with message containing "no matching files found"

            err:condition has final verdict Unmeetable

            state:
            #### log messages (see RPC logs for full text):
...
panic: test timed out after 10m0s
running tests:
	TestExtractFunction (0s)
	TestExtractFunction/default (0s)

goroutine 17968 [running]:
testing.(*M).startAlarm.func1()
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/src/testing/testing.go:2241 +0x34c
created by time.goFunc
	/ramdisk8GB/workdir-host-aix-ppc64-osuosl/go/src/time/sleep.go:176 +0x58

watchflakes

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- repo == "tools" && builder == "aix-ppc64"
2023-04-04 16:15 aix-ppc64 tools@4d205d81 go@3e8f5457 x/tools/gopls/internal/regtest/misc.Test_Issue38211 (log)
#### Start Gopls Test Logs for "Test_Issue38211/default"
[Trace - 03:25:51.047 AM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"tagSupport":{"valueSet":[1]}}},"documentSymbol":{"hierarchicalDocumentSymbolSupport":true},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":null,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/gopls-regtest-129314196/Test_Issue38211/default/gopath","GOPROXY":"file:///ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/gopls-regtest-129314196/Test_Issue38211/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/gopls-regtest-129314196/Test_Issue38211/default/work","name":"work"}]}


[Trace - 03:25:51.048 AM] Received response 'initialize - (1)' in 1ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.mem_stats","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel 3e8f5457ef79c2574ba34f8dafc5ad95464c172d\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}


[Trace - 03:25:51.049 AM] Sending notification 'initialized'.
...
--- FAIL: Test_Issue38211 (2.38s)
    --- FAIL: Test_Issue38211/default (2.38s)
        diagnostics_test.go:660: no quick fixes were applied
#### Start Gopls Test Logs for "TestNewModule_Issue38207/default"
[Trace - 03:25:53.442 AM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"tagSupport":{"valueSet":[1]}}},"documentSymbol":{"hierarchicalDocumentSymbolSupport":true},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":null,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/gopls-regtest-129314196/TestNewModule_Issue38207/default/gopath","GOPROXY":"file:///ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/gopls-regtest-129314196/TestNewModule_Issue38207/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/gopls-regtest-129314196/TestNewModule_Issue38207/default/work","name":"work"}]}


[Trace - 03:25:53.444 AM] Received response 'initialize - (1)' in 2ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.mem_stats","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel 3e8f5457ef79c2574ba34f8dafc5ad95464c172d\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}
...


[Trace - 03:25:55.507 AM] Received notification 'window/logMessage'.
Params: {"type":1,"message":"2023/04/06 03:25:55 storing diagnostics data for mod.com: write /.cache/gopls/6a48b73b/diagnostics/d7/d7505721fbac9cfc6f79e83134d4e71514d8aa3907f44ea07ee33b7a8fae358a: no space left on device\n"}


[Error - Received] 03:25:55.525 AM #2 internal error updating shared cache: write /.cache/gopls/6a48b73b/analysis/e5/e5f09231ef5b5939101384b9f6f322266c7f90b51476cdd997455f268fd156f2: no space left on device


#### End Gopls Test Logs for "TestNewModule_Issue38207/default"
2023-04-04 16:15 aix-ppc64 tools@4d205d81 go@3e8f5457 x/tools/gopls/internal/regtest/misc.TestNewModule_Issue38207 (log)
--- FAIL: TestNewModule_Issue38207 (2.40s)
    --- FAIL: TestNewModule_Issue38207/default (2.40s)
        diagnostics_test.go:712: organizing imports before save: internal error updating shared cache: write /.cache/gopls/6a48b73b/analysis/e5/e5f09231ef5b5939101384b9f6f322266c7f90b51476cdd997455f268fd156f2: no space left on device
#### Start Gopls Test Logs for "TestManuallyCreatingXTest/default"
[Trace - 03:25:59.925 AM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"tagSupport":{"valueSet":[1]}}},"documentSymbol":{"hierarchicalDocumentSymbolSupport":true},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":null,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/gopls-regtest-129314196/TestManuallyCreatingXTest/default/gopath","GOPROXY":"file:///ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/gopls-regtest-129314196/TestManuallyCreatingXTest/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/gopls-regtest-129314196/TestManuallyCreatingXTest/default/work","name":"work"}]}


[Trace - 03:25:59.926 AM] Received response 'initialize - (1)' in 1ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.mem_stats","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel 3e8f5457ef79c2574ba34f8dafc5ad95464c172d\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}
...


[Trace - 03:26:05.436 AM] Received notification 'window/logMessage'.
Params: {"type":1,"message":"2023/04/06 03:26:05 storing export data for mod.com/hello_test [mod.com/hello.test]: write /.cache/gopls/6a48b73b/export/45/4512d37329b7d7dd9c80ceb02cd926ce533b088e340cdcf8479392fdddf12323: no space left on device\n"}


[Error - Received] 03:26:05.447 AM #2 internal error updating shared cache: write /.cache/gopls/6a48b73b/analysis/eb/eb06e6be1311f979579a8a880d749b223963cf30b640e41fd56e230466b28e1a: no space left on device


#### End Gopls Test Logs for "TestManuallyCreatingXTest/default"
2023-04-04 16:15 aix-ppc64 tools@4d205d81 go@3e8f5457 x/tools/gopls/internal/regtest/misc.TestManuallyCreatingXTest (log)
--- FAIL: TestManuallyCreatingXTest (5.73s)
    --- FAIL: TestManuallyCreatingXTest/default (5.73s)
        diagnostics_test.go:816: organizing imports before save: internal error updating shared cache: write /.cache/gopls/6a48b73b/analysis/eb/eb06e6be1311f979579a8a880d749b223963cf30b640e41fd56e230466b28e1a: no space left on device
#### Start Gopls Test Logs for "TestCutAndPaste/default"
[Trace - 03:26:43.736 AM] Sending request 'initialize - (1)'.
Params: {"processId":0,"clientInfo":{"name":"fakeclient","version":"v1.0.0"},"rootUri":"","capabilities":{"workspace":{"workspaceEdit":{"resourceOperations":["rename"]},"didChangeConfiguration":{},"didChangeWatchedFiles":{"dynamicRegistration":true},"configuration":true},"textDocument":{"completion":{"completionItem":{"snippetSupport":true,"tagSupport":{"valueSet":[1]}}},"documentSymbol":{"hierarchicalDocumentSymbolSupport":true},"codeAction":{"codeActionLiteralSupport":{"codeActionKind":{"valueSet":null}}},"publishDiagnostics":{},"semanticTokens":{"requests":{"range":null,"full":true},"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"],"formats":null}},"window":{"workDoneProgress":true}},"initializationOptions":{"completionBudget":"10s","diagnosticsDelay":"10ms","env":{"GO111MODULE":"","GOMODCACHE":"","GOPACKAGESDRIVER":"off","GOPATH":"/ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/gopls-regtest-129314196/TestCutAndPaste/default/gopath","GOPROXY":"file:///ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/gopls-regtest-129314196/TestCutAndPaste/default/proxy","GOSUMDB":"off"},"verboseWorkDoneProgress":true},"trace":"messages","workspaceFolders":[{"uri":"file:///ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/gopls-regtest-129314196/TestCutAndPaste/default/work","name":"work"}]}


[Trace - 03:26:43.738 AM] Received response 'initialize - (1)' in 1ms.
Result: {"capabilities":{"textDocumentSync":{"openClose":true,"change":2,"save":{}},"completionProvider":{"triggerCharacters":["."]},"hoverProvider":true,"signatureHelpProvider":{"triggerCharacters":["(",","]},"definitionProvider":true,"typeDefinitionProvider":true,"implementationProvider":true,"referencesProvider":true,"documentHighlightProvider":true,"documentSymbolProvider":true,"codeActionProvider":true,"codeLensProvider":{},"documentLinkProvider":{},"workspaceSymbolProvider":true,"documentFormattingProvider":true,"renameProvider":true,"foldingRangeProvider":true,"selectionRangeProvider":true,"executeCommandProvider":{"commands":["gopls.add_dependency","gopls.add_import","gopls.apply_fix","gopls.check_upgrades","gopls.edit_go_directive","gopls.fetch_vulncheck_result","gopls.gc_details","gopls.generate","gopls.go_get_package","gopls.list_imports","gopls.list_known_packages","gopls.mem_stats","gopls.regenerate_cgo","gopls.remove_dependency","gopls.reset_go_mod_diagnostics","gopls.run_govulncheck","gopls.run_tests","gopls.start_debugging","gopls.test","gopls.tidy","gopls.toggle_gc_details","gopls.update_go_sum","gopls.upgrade_dependency","gopls.vendor"]},"callHierarchyProvider":true,"semanticTokensProvider":{"legend":{"tokenTypes":["namespace","type","class","enum","interface","struct","typeParameter","parameter","variable","property","enumMember","event","function","method","macro","keyword","modifier","comment","string","number","regexp","operator"],"tokenModifiers":["declaration","definition","readonly","static","deprecated","abstract","async","modification","documentation","defaultLibrary"]},"range":true,"full":true},"inlayHintProvider":{},"workspace":{"workspaceFolders":{"supported":true,"changeNotifications":"workspace/didChangeWorkspaceFolders"}}},"serverInfo":{"name":"gopls","version":"{\"GoVersion\":\"devel 3e8f5457ef79c2574ba34f8dafc5ad95464c172d\",\"Path\":\"\",\"Main\":{\"Path\":\"\",\"Version\":\"\",\"Sum\":\"\",\"Replace\":null},\"Deps\":null,\"Settings\":null,\"Version\":\"master\"}"}}
...


[Trace - 03:26:47.062 AM] Received notification 'window/logMessage'.
Params: {"type":1,"message":"2023/04/06 03:26:47 storing export data for mod.com: write /.cache/gopls/6a48b73b/export/47/47360971f099edec88e021f01c5db0176edb0da7c86459a894fbd6356e48c8c6: no space left on device\n"}


[Error - Received] 03:26:47.062 AM #2 internal error updating shared cache: open /.cache/gopls/6a48b73b/analysis/98/986473844bee4bc34257a32bcf3b33dedfaef941f53ecc87c1d37797d817e41d: no space left on device


#### End Gopls Test Logs for "TestCutAndPaste/default"
2023-04-04 16:15 aix-ppc64 tools@4d205d81 go@a156e02c x/tools/gopls/internal/regtest/workspace.TestLSP (log)
--- FAIL: TestLSP (48.72s)
    --- FAIL: TestLSP/Modules (13.05s)
        --- FAIL: TestLSP/Modules/Diagnostics (0.38s)
            --- FAIL: TestLSP/Modules/Diagnostics/noparse (0.00s)
                lsp_test.go:247: noparse.go:16:3-16:5: unmatched diagnostic pattern "no new variables"
            --- FAIL: TestLSP/Modules/Diagnostics/noparse_format (0.00s)
                lsp_test.go:247: noparse_format.go:11:4-11:6: unmatched diagnostic pattern "no new variables"
            --- FAIL: TestLSP/Modules/Diagnostics/bad_test (0.00s)
                lsp_test.go:247: bad_test.go:9:0-9:0: unmatched diagnostic pattern "Testbad has malformed name: first letter after 'Test' must not be lowercase"
                lsp_test.go:247: bad_test.go:11:5-11:6: unmatched diagnostic pattern "assignment copies lock value to _: sync.Mutex"
...
            --- FAIL: TestLSP/Modules/Diagnostics/badstmt (0.00s)
                lsp_test.go:247: badstmt.go:12:3-12:5: unmatched diagnostic pattern "no new variables"
        --- FAIL: TestLSP/Modules/Import (0.01s)
            --- FAIL: TestLSP/Modules/Import/add_import (0.00s)
                lsp_test.go:467: internal error updating shared cache: write /.cache/gopls/800c409b/analysis/07/07073c6815d71326dba04ef8c4fda2b217e08d9b81a790a6c825c56c466e91a1: no space left on device
            --- FAIL: TestLSP/Modules/Import/good_imports (0.00s)
                lsp_test.go:467: internal error updating shared cache: write /.cache/gopls/800c409b/analysis/07/07073c6815d71326dba04ef8c4fda2b217e08d9b81a790a6c825c56c466e91a1: no space left on device
            --- FAIL: TestLSP/Modules/Import/issue35458 (0.00s)
                lsp_test.go:467: internal error updating shared cache: write /.cache/gopls/800c409b/analysis/07/07073c6815d71326dba04ef8c4fda2b217e08d9b81a790a6c825c56c466e91a1: no space left on device
            --- FAIL: TestLSP/Modules/Import/multiple_blocks (0.00s)
...
            --- FAIL: TestLSP/MultiModule/MethodExtraction/extract_basic_13_2 (0.00s)
                lsp_test.go:660: internal error updating shared cache: mkdir /.cache/gopls/800c409b/analysis/e8: no space left on device
            --- FAIL: TestLSP/MultiModule/MethodExtraction/extract_basic_14_2 (0.00s)
                lsp_test.go:660: internal error updating shared cache: mkdir /.cache/gopls/800c409b/analysis/e8: no space left on device
            --- FAIL: TestLSP/MultiModule/MethodExtraction/extract_basic_18_2 (0.00s)
                lsp_test.go:660: internal error updating shared cache: mkdir /.cache/gopls/800c409b/analysis/e8: no space left on device
            --- FAIL: TestLSP/MultiModule/MethodExtraction/extract_basic_22_2 (0.00s)
                lsp_test.go:660: internal error updating shared cache: mkdir /.cache/gopls/800c409b/analysis/e8: no space left on device
            --- FAIL: TestLSP/MultiModule/MethodExtraction/extract_basic_23_2 (0.00s)
                lsp_test.go:660: internal error updating shared cache: mkdir /.cache/gopls/800c409b/analysis/e8: no space left on device
2023-04-04 16:15 aix-ppc64 tools@4d205d81 go@a156e02c x/tools/gopls/internal/regtest/workspace.TestCapabilities (log)
2023/04/06 03:36:10 New session
	create_session=1
2023/04/06 03:36:10 go info for /ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/fake26689441
(go dir /ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/fake26689441)
(go version go version devel a156e02c16c1e0e71ba0477a27734b8d38f41cf7 aix/ppc64)
(valid build configuration = true)
(build flags: [])
(selected go env: [GO111MODULE=, GOCACHE=/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gocache, GOFLAGS=, GOMODCACHE=/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath/pkg/mod, GOPATH=/ramdisk8GB/workdir-host-aix-ppc64-osuosl/gopath, GOPRIVATE=, GOROOT=/ramdisk8GB/workdir-host-aix-ppc64-osuosl/go, GOWORK=])

2023/04/06 03:36:10 go/packages.Load #1
...
2023/04/06 03:36:11 storing methodsets data for fake: write /.cache/gopls/64eab34e/methodsets/e4/e4998d8dd6c53f084bbc14820dbe6587f7b3c7743b0bec0e4a58d8680bafaa0f: no space left on device
2023/04/06 03:36:11 warning: analyzing package: internal error updating shared cache: write /.cache/gopls/64eab34e/analysis/aa/aa924efa7951a84afe50343e6c10d081be3c40f751bb5d3a456c7c97e27c9f1a: no space left on device
	snapshot=2
	directory=file:///ramdisk8GB/workdir-host-aix-ppc64-osuosl/tmp/fake26689441
	package="fake"
2023/04/06 03:36:11 storing diagnostics data for fake: write /.cache/gopls/64eab34e/diagnostics/e4/e4998d8dd6c53f084bbc14820dbe6587f7b3c7743b0bec0e4a58d8680bafaa0f: no space left on device
2023/04/06 03:36:12 Shutdown session
	shutdown_session=1
--- FAIL: TestCapabilities (2.16s)
    capabilities_test.go:99: internal error updating shared cache: write /.cache/gopls/64eab34e/analysis/1c/1c1823476813e00c571ce850621b01158f31a408f5f1da362cf6e37e5e0bba88: no space left on device
2023-04-04 16:15 aix-ppc64 tools@4d205d81 go@a156e02c x/tools/gopls/internal/regtest/workspace.TestFix (log)
--- FAIL: TestFix (3.27s)
    integration_test.go:712: gopls fix -a a.go: exited with code 2, want success: true (gopls fix -a a.go: exit=2 stdout=<<>> stderr=<<2023/04/06 03:36:12 Error:2023/04/06 03:36:12 storing xrefs data for example.com: write /.cache/gopls/1082cfb0/xrefs/35/354cf149d538c60885c01b2421a2880d1e90de79e368c5c469bebd54c2774a5f: no space left on device
        2023/04/06 03:36:12 Error:2023/04/06 03:36:12 storing methodsets data for example.com: write /.cache/gopls/1082cfb0/methodsets/35/354cf149d538c60885c01b2421a2880d1e90de79e368c5c469bebd54c2774a5f: no space left on device
        2023/04/06 03:36:12 Error:2023/04/06 03:36:12 storing methodsets data for example.com: write /.cache/gopls/1082cfb0/methodsets/35/354cf149d538c60885c01b2421a2880d1e90de79e368c5c469bebd54c2774a5f: no space left on device
        2023/04/06 03:36:12 Error:2023/04/06 03:36:12 storing export data for example.com: write /.cache/gopls/1082cfb0/export/35/354cf149d538c60885c01b2421a2880d1e90de79e368c5c469bebd54c2774a5f: no space left on device
        2023/04/06 03:36:12 Error:2023/04/06 03:36:12 storing diagnostics data for example.com: write /.cache/gopls/1082cfb0/diagnostics/35/354cf149d538c60885c01b2421a2880d1e90de79e368c5c469bebd54c2774a5f: no space left on device
        2023/04/06 03:36:12 Error:2023/04/06 03:36:12 storing export data for example.com: write /.cache/gopls/1082cfb0/export/35/354cf149d538c60885c01b2421a2880d1e90de79e368c5c469bebd54c2774a5f: no space left on device
        2023/04/06 03:36:12 Error:2023/04/06 03:36:12 storing diagnostics data for example.com: write /.cache/gopls/1082cfb0/diagnostics/35/354cf149d538c60885c01b2421a2880d1e90de79e368c5c469bebd54c2774a5f: no space left on device
        2023/04/06 03:36:12 Error:2023/04/06 03:36:12 storing xrefs data for example.com: write /.cache/gopls/1082cfb0/xrefs/35/354cf149d538c60885c01b2421a2880d1e90de79e368c5c469bebd54c2774a5f: no space left on device
        2023/04/06 03:36:13 Error:2023/04/06 03:36:13 warning: analyzing package: internal error updating shared cache: write /.cache/gopls/1082cfb0/analysis/22/22f9ae2449482127a19e6b06a9fcc9f1ccaae3107c9db79cbc679ea7e1f9bd80: no space left on device
        	snapshot=1
        	directory=file://.
        	package="example.com"
        2023/04/06 03:36:13 Error:2023/04/06 03:36:13 storing xrefs data for example.com: write /.cache/gopls/1082cfb0/xrefs/35/354cf149d538c60885c01b2421a2880d1e90de79e368c5c469bebd54c2774a5f: no space left on device
        2023/04/06 03:36:13 Error:2023/04/06 03:36:13 storing methodsets data for example.com: write /.cache/gopls/1082cfb0/methodsets/35/354cf149d538c60885c01b2421a2880d1e90de79e368c5c469bebd54c2774a5f: no space left on device
        2023/04/06 03:36:13 Error:2023/04/06 03:36:13 storing export data for example.com: write /.cache/gopls/1082cfb0/export/35/354cf149d538c60885c01b2421a2880d1e90de79e368c5c469bebd54c2774a5f: no space left on device
        2023/04/06 03:36:13 Error:2023/04/06 03:36:13 storing diagnostics data for example.com: write /.cache/gopls/1082cfb0/diagnostics/35/354cf149d538c60885c01b2421a2880d1e90de79e368c5c469bebd54c2774a5f: no space left on device
        gopls: internal error updating shared cache: write /.cache/gopls/1082cfb0/analysis/22/22f9ae2449482127a19e6b06a9fcc9f1ccaae3107c9db79cbc679ea7e1f9bd80: no space left on device
        >>)
    integration_test.go:715: fix: got <<>>, want <<package a
        var _ error = T(0)
        type T int
        func f() (int, string) { return 0, "" }
        >>

watchflakes

@gopherbot
Copy link

Change https://go.dev/cl/482823 mentions this issue: gopls/internal/lsp/filecache: evict aggressively on Go builders

@gopherbot
Copy link

Found new dashboard test flakes for:

#!watchflakes
post <- repo == "tools" && builder == "aix-ppc64"
2023-04-18 19:06 aix-ppc64 tools@641e4d7e go@130a7f8e x/tools/gopls/internal/lsp/cmd/test.TestFix (log)
--- FAIL: TestFix (2.72s)
    integration_test.go:715: fix: got <<package a
        var _ error = T(0)
        type T int
        func f() (int, string) { return }
        >>, want <<package a
        var _ error = T(0)
        type T int
        func f() (int, string) { return 0, "" }
        >>

watchflakes

@findleyr
Copy link
Contributor Author

That flake is #59475, which I'm looking at.

@bcmills
Copy link
Contributor

bcmills commented Apr 27, 2023

I just cleared off many GiB of .cache/gopls from the freebsd-arm64-dmgk builder (https://build.golang.org/log/40dc9e3bd385f3f68c8a12032377c97a91245741).

@gopherbot
Copy link

Change https://go.dev/cl/494297 mentions this issue: cmd/buildlet: set GOPLSCACHE=$workdir/goplscache

gopherbot pushed a commit to golang/build that referenced this issue May 12, 2023
Ordinarily, gopls processes live such long and idle lives that the
internal garbage collector for gopls' file-based cache can easily keep
up with the churn rate and maintain the shared cache at a reasonable
size. But tests burn twice as bright and half as long and, despite
various efforts, have tended to fill the cache volume; see the
attached Go issues.

This change causes the buildlet to set GOPLSCACHE to a fresh
subdirectory of the work dir for each builder run so that each is
cleaned up at the end of the run. This does mean that the tests don't
exercise the shared cache behavior, but the problems our tests
hitherto uncovered were not particularly representative of production.

Updates golang/go#57900
Updates golang/go#57902

Change-Id: I63e91dd873897eb3619929530bc3a75a16b96095
Reviewed-on: https://go-review.googlesource.com/c/build/+/494297
Run-TryBot: Alan Donovan <adonovan@google.com>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gopls Issues related to the Go language server, gopls. NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Development

No branches or pull requests

5 participants