Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/internal/robustio: TestFileID consistently failing on android builders with EPERM #57844

Closed
bcmills opened this issue Jan 17, 2023 · 2 comments
Closed

x/tools/internal/robustio: TestFileID consistently failing on android builders with EPERM #57844

bcmills opened this issue Jan 17, 2023 · 2 comments
Assignees
@adonovan
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Jan 17, 2023 

#!watchflakes
post <- builder ~ `^android-.*` && test == "TestFileID"

https://build.golang.org/log/2986bd93a11934517802df1e2b7314280acfd478:

--- FAIL: TestFileID (0.00s)
    robustio_test.go:63: link /data/local/tmp/go_android_exec/robustio.test-16829/TestFileID3286931938/002/real /data/local/tmp/go_android_exec/robustio.test-16829/TestFileID3286931938/005/hardlink: permission denied
FAIL
exitcode=1
FAIL	golang.org/x/tools/internal/robustio	2.577s
@gopherbot gopherbot added the Tools This label describes issues relating to any tools in the x/tools repository. label Jan 17, 2023
@gopherbot gopherbot added this to the Unreleased milestone Jan 17, 2023
@bcmills
Copy link
Contributor Author

bcmills commented Jan 17, 2023

The test seems to be assuming that it can create hard-links in t.TempDir():
https://cs.opensource.google/go/x/tools/+/master:internal/robustio/robustio_test.go;l=62;drc=3856a5d80cf9ed9505c189333d753350aaaffcd2

While that is usually true, it does not hold for all filesystems and container implementations.
(Compare https://pkg.go.dev/internal/testenv#HasLink.)

@bcmills bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. NeedsFix The path to resolution is known, but the work has not been done. labels Jan 17, 2023
@gopherbot
Copy link

Change https://go.dev/cl/462415 mentions this issue: internal/robustio: skip os.Link test on android

@golang golang locked and limited conversation to collaborators Jan 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@adonovan adonovan

Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bcmills @adonovan @gopherbot