Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net/http: TestOnlyWriteTimeout failures #57830

Closed
gopherbot opened this issue Jan 16, 2023 · 8 comments
Closed

net/http: TestOnlyWriteTimeout failures #57830

gopherbot opened this issue Jan 16, 2023 · 8 comments
Assignees
@bcmills
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.21

Comments

@gopherbot
Copy link

gopherbot commented Jan 16, 2023 •
edited by bcmills 

#!watchflakes
post <- pkg == "net/http" && test == "TestOnlyWriteTimeout" && `timeout waiting for .* error`

Issue created automatically to collect these failures.

Example (log):

2023/01/09 20:31:43 http: TLS handshake error from 127.0.0.1:50632: read tcp 127.0.0.1:50625->127.0.0.1:50632: use of closed network connection
2023/01/09 20:31:49 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *net.TCPConn 0xc0001f9938 127.0.0.1:50815 in state active
2023/01/09 20:31:49 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *net.TCPConn 0xc00017e090 127.0.0.1:50819 in state active
--- FAIL: TestOnlyWriteTimeout (15.12s)
    serve_test.go:968: timeout waiting for Get error

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 16, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestOnlyWriteTimeout"
2023-01-09 21:17 darwin-amd64-nocgo go@071a1ed0 net/http.TestOnlyWriteTimeout (log) 
2023/01/09 20:31:43 http: TLS handshake error from 127.0.0.1:50632: read tcp 127.0.0.1:50625->127.0.0.1:50632: use of closed network connection
2023/01/09 20:31:49 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *net.TCPConn 0xc0001f9938 127.0.0.1:50815 in state active
2023/01/09 20:31:49 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *net.TCPConn 0xc00017e090 127.0.0.1:50819 in state active
--- FAIL: TestOnlyWriteTimeout (15.12s)
    serve_test.go:968: timeout waiting for Get error

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Jan 17, 2023

(attn @neild)

The failure mode — a darwin platform and an error matching timeout waiting for .* error — is strikingly similar to #57599.

@bcmills bcmills added this to the Backlog milestone Jan 17, 2023
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestOnlyWriteTimeout"
2023-01-09 21:17 darwin-amd64-12_0 go@071a1ed0 net/http.TestOnlyWriteTimeout (log) 
1 second passes in backend, proxygone= false
1 second passes in backend, proxygone= false
2023/01/09 20:36:36 http: TLS handshake error from 127.0.0.1:51093: read tcp 127.0.0.1:51092->127.0.0.1:51093: read: connection reset by peer
--- FAIL: TestOnlyWriteTimeout (13.03s)
    serve_test.go:968: timeout waiting for Get error

— watchflakes

@gopherbot

This comment was marked as off-topic.

Sign in to view
@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestOnlyWriteTimeout" && `timeout waiting for .* error`
2023-02-24 07:13 darwin-amd64-nocgo go@ddb423a7 net/http.TestOnlyWriteTimeout (log) 
2023/02/23 23:28:55 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *net.TCPConn 0xc00047e7d8 127.0.0.1:50627 in state active
--- FAIL: TestOnlyWriteTimeout (0.00s)
    --- FAIL: TestOnlyWriteTimeout/h1 (22.39s)
        serve_test.go:1008: timeout waiting for Get error
2023/02/23 23:29:04 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *tls.Conn 0xc000d6ca80 127.0.0.1:50895 in state idle

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestOnlyWriteTimeout" && `timeout waiting for .* error`
2023-02-27 19:59 darwin-amd64-13 go@ce025d90 net/http.TestOnlyWriteTimeout (log) 
2023/02/28 06:03:20 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *net.TCPConn 0xc0005080d8 127.0.0.1:50443 in state active
2023/02/28 06:03:20 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *net.TCPConn 0xc0000a8068 127.0.0.1:50447 in state active
--- FAIL: TestOnlyWriteTimeout (11.88s)
    serve_test.go:968: timeout waiting for Get error

— watchflakes

@gopherbot
Copy link
Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "net/http" && test == "TestOnlyWriteTimeout" && `timeout waiting for .* error`
2023-04-03 20:02 darwin-amd64-nocgo go@7a5787f3 net/http.TestOnlyWriteTimeout (log) 
2023/04/03 15:21:25 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *net.TCPConn 0xc000012008 127.0.0.1:50764 in state active
--- FAIL: TestOnlyWriteTimeout (24.85s)
    serve_test.go:968: timeout waiting for Get error
2023/04/03 15:21:48 httptest.Server blocked in Close after 5 seconds, waiting for connections:
  *net.TCPConn 0xc0005b8038 127.0.0.1:50880 in state active

— watchflakes

@bcmills
Copy link
Contributor

bcmills commented Apr 5, 2023

This failure mode is no longer possible after CL 476035. It may still occur on the release branches, though.

@bcmills bcmills closed this as completed Apr 5, 2023
@bcmills bcmills self-assigned this Apr 5, 2023
@bcmills bcmills modified the milestones: Backlog, Go1.21 Apr 5, 2023
@golang golang locked and limited conversation to collaborators Apr 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bcmills bcmills

Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Test Flakes
Status: Done
Milestone
Go1.21
Development

No branches or pull requests
2 participants
@bcmills @gopherbot