Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/perf/cmd/benchsave: authentication broken #57791

Open
prattmic opened this issue Jan 13, 2023 · 1 comment
Open

x/perf/cmd/benchsave: authentication broken #57791

prattmic opened this issue Jan 13, 2023 · 1 comment
Assignees
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@prattmic
Copy link
Member

x/perf/cmd/benchsave uses Google's out-of-band authentication flow which has been deprecated, so benchsave can no longer authenticate, or thus upload benchmark results.

I think the best path forward here is to migrate perfdata.golang.org to x/build's GKE cluster, at which point we can put perfdata.golang.org/upload behind IAP like other x/build authenticated services. At that point, benchsave can reuse x/build/internal/iapclient, the same authentication client used by gomote.

This is not the quickest path, but this migration is something we've put off for a while and doing the long path won't be leaving tech debt behind.

cc @mknyszek @aclements

@prattmic prattmic added this to the Unreleased milestone Jan 13, 2023
@prattmic prattmic self-assigned this Jan 13, 2023
@gopherbot
Copy link

Change https://go.dev/cl/461961 mentions this issue: internal/access: add IAP context to HTTP requests

@bcmills bcmills added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

3 participants