Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: revisit version tags in "go get" #5779

Closed
ncw opened this issue Jun 25, 2013 · 4 comments
Closed

cmd/go: revisit version tags in "go get" #5779

ncw opened this issue Jun 25, 2013 · 4 comments

Comments

@ncw
Copy link
Contributor

ncw commented Jun 25, 2013

go get should be able to select a go1.0 tag so we can gracefully leave behind go 1.0
code in a 'go1.0' branch and get on with go 1.1.

It looks like this has been thought about here but not implemented

https://code.google.com/p/go/source/browse/src/cmd/go/get.go#334
@adg
Copy link
Contributor

adg commented Jun 25, 2013

Comment 1:

We left that out until we decided what to do with it.
In the mean time you can use build constraints to achieve a similar goal:
http://golang.org/doc/go1.1#tags

Status changed to Accepted.

@rsc
Copy link
Contributor

rsc commented Jul 2, 2013

Comment 2:

I have no plans to change the tag/branch selection rule before Go 2. We used to do this
for individual releases and it was too heavy weight.
The official suggestion for maintaining code that needs to work with multiple Go 1.x
versions is either to limit yourself to the features of the oldest supported version or
to use // +build tags in files. It is a significantly lighter weight mechanism than
different versions or branches.

Labels changed: added priority-later, go2, removed priority-triage.

@rsc
Copy link
Contributor

rsc commented Jul 2, 2013

Comment 3:

Labels changed: removed go2.

Status changed to LongTerm.

@rsc
Copy link
Contributor

rsc commented Jul 30, 2013

Comment 4:

Status changed to WorkingAsIntended.

@golang golang locked and limited conversation to collaborators Jun 24, 2016
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants