Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/pkgsite: k8s.io/api/core/v1#PersistentVolumeSpec information is wrong #57758

Closed
zioproto opened this issue Jan 12, 2023 · 2 comments
Closed

x/pkgsite: k8s.io/api/core/v1#PersistentVolumeSpec information is wrong #57758

zioproto opened this issue Jan 12, 2023 · 2 comments
Labels
FrozenDueToAge pkgsite
Milestone
Unreleased

Comments

@zioproto
Copy link

What is the URL of the page with the issue?

https://pkg.go.dev/k8s.io/api/core/v1#PersistentVolumeSpec

What is your user agent?

Not relevant

Screenshot

Screenshot 2023-01-12 at 14 11 29

What did you do?

The information is wrong:
https://github.com/kubernetes/kubernetes/blob/master/pkg/apis/core/types.go#L303-L306

From the upstream source code you can see the PersistentVolumeSpec.Capacity is not optional

What did you expect to see?

I expected to see the same struct for PersistentVolumeSpec as in the Kubernetes repository.

What did you see instead?

I see a different version where capacity is marked as optional, but this is wrong.
@gopherbot gopherbot added this to the Unreleased milestone Jan 12, 2023
@seankhliao
Copy link
Member

please report this to kubernetes

@seankhliao seankhliao closed this as not planned Won't fix, can't repro, duplicate, stale Jan 12, 2023
@zioproto
Copy link
Author

zioproto commented Jan 12, 2023 •
edited

Thanks, I figured out now the bug is actually here:
https://github.com/kubernetes/api/blob/release-1.26/core/v1/types.go#L324-L366
I will report to Kubernetes. Thanks

@golang golang locked and limited conversation to collaborators Jan 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge pkgsite
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@zioproto @gopherbot @seankhliao