Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/internal/task: improve advisory TryBot usability #57725

Closed
heschi opened this issue Jan 10, 2023 · 2 comments
Closed

x/build/internal/task: improve advisory TryBot usability #57725

heschi opened this issue Jan 10, 2023 · 2 comments
Assignees
@cagedmantis
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@heschi
Copy link
Contributor

heschi commented Jan 10, 2023

As implemented, advisory trybots failures are a pain to deal with. First, they should retry to suppress flakes. Second, the process of bouncing between the "Approve any TryBot failures" task and the individual failures is needlessly annoying.

Because a failing trybot run shouldn't break the build, we can't take advantage of the workflow package's retry support. We'll have to do some internal retries. Moving the approval step to the individual failures is easy.
@heschi heschi added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 10, 2023
@heschi heschi added this to the Unreleased milestone Jan 10, 2023
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Jan 10, 2023
@cagedmantis cagedmantis self-assigned this Jan 10, 2023
@gopherbot
Copy link

Change https://go.dev/cl/463535 mentions this issue: internal/relui: modify advisory trybots

@gopherbot
Copy link

Change https://go.dev/cl/464299 mentions this issue: internal/relui: pass advisory trybot when context canceled

gopherbot pushed a commit to golang/build that referenced this issue Jan 31, 2023
@cagedmantis
internal/relui: pass advisory trybot when context canceled
44974d2 
When an advisory trybot run times out, the context is canceled.
The trybot will never complete successfully with a canceled context.
This change records the failure and approves the trybot run.

For golang/go#57725

Change-Id: I79ba2d9cf32c91180cbce70f5b51426aaa11a704
Reviewed-on: https://go-review.googlesource.com/c/build/+/464299
Run-TryBot: Carlos Amedee <carlos@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Michael Knyszek <mknyszek@google.com>
@dmitshur dmitshur mentioned this issue May 25, 2023
Open
@golang golang locked and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@cagedmantis cagedmantis

Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
Go Release
Archived in project
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@cagedmantis @gopherbot @heschi