Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go/internal/vcs: wrong comment, repoRootForImportPathStatic func no longer exists #57718

Closed
bekcpear opened this issue Jan 10, 2023 · 3 comments
Closed

cmd/go/internal/vcs: wrong comment, repoRootForImportPathStatic func no longer exists #57718

bekcpear opened this issue Jan 10, 2023 · 3 comments
Labels
Documentation FrozenDueToAge GoCommand cmd/go help wanted NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.21

Comments

@bekcpear
Copy link

What version of Go are you using (go version)?

$ go version
go version go1.19.4 linux/amd64

Does this issue reproduce with the latest release?

Yes

Details

check this line:

go/src/cmd/go/internal/vcs/vcs.go

Line 1273 in 0202ad0

// statically known by repoRootForImportPathStatic.

the repoRootForImportPathStatic func has been replaced by repoRootFromVCSPaths func in this commit: 669f5be, but the comment here is not updated.
@seankhliao seankhliao changed the title affected/package: cmd/go/internal/vcs, wrong comment, repoRootForImportPathStatic func no longer exists cmd/go/internal/vcs: wrong comment, repoRootForImportPathStatic func no longer exists Jan 10, 2023
@bcmills
Copy link
Contributor

bcmills commented Jan 10, 2023

This doesn't really need to be filed as an issue — if a comment is wrong please just send a PR or CL. 😅

https://go.dev/doc/contribute

@bcmills bcmills added Documentation help wanted NeedsFix The path to resolution is known, but the work has not been done. GoCommand cmd/go labels Jan 10, 2023
@bcmills bcmills modified the milestones: Gccgo, Backlog Jan 10, 2023
cbedard added a commit to cbedard/go that referenced this issue Jan 12, 2023
@cbedard
fix outdated comment
b8c9dbc 
func name was changed in commit: 669f5be

Fixes golang#57718
@cbedard cbedard mentioned this issue Jan 12, 2023
Closed
@gopherbot
Copy link

Change https://go.dev/cl/461610 mentions this issue: vcs: fix outdated comment

@bekcpear
Copy link
Author

This doesn't really need to be filed as an issue — if a comment is wrong please just send a PR or CL. sweat_smile

Thanks for your reply, however I just found this wrong comment and not sure whether there are something others related contents/comments should be fixed either, and I don't want to ignore the question, so I opened this issue.

@dmitshur dmitshur modified the milestones: Backlog, Go1.21 Jan 26, 2023
@golang golang locked and limited conversation to collaborators Jan 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation FrozenDueToAge GoCommand cmd/go help wanted NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.21
Development

Successfully merging a pull request may close this issue.

cmd/go/internal/vcs: fix outdated comment cbedard/go
4 participants
@dmitshur @bcmills @bekcpear @gopherbot