Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc/cgo: backport needed for dlltool fix [1.19 backport] #57706

Closed
gopherbot opened this issue Jan 9, 2023 · 3 comments
Closed

misc/cgo: backport needed for dlltool fix [1.19 backport] #57706

gopherbot opened this issue Jan 9, 2023 · 3 comments
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@gopherbot
Copy link
Contributor

@thanm requested issue #57704 to be considered for backport to the next 1.19 minor release.

@gopherbot please open backport issues

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Jan 9, 2023
@gopherbot gopherbot added this to the Go1.19.5 milestone Jan 9, 2023
@gopherbot
Copy link
Contributor Author

Change https://go.dev/cl/461175 mentions this issue: misc/cgo/testcshared: handle unsuffixed dlltool path

@cagedmantis
Copy link
Contributor

Approved as this is a test only fix.

@cagedmantis cagedmantis added the CherryPickApproved Used during the release process for point releases label Jan 9, 2023
@gopherbot gopherbot removed the CherryPickCandidate Used during the release process for point releases label Jan 9, 2023
@dmitshur dmitshur added the Testing An issue that has been verified to require only test changes, not just a test failure. label Jan 9, 2023
gopherbot pushed a commit that referenced this issue Jan 9, 2023
…ol path

Adapt the testcshared tests to handle the case where the path output
by invoking

  gcc -print-prog-name=dlltool

is a path lacking the final ".exe" suffix (this seems to be what clang
is doing); tack it on before using if this is the case.

Updates #57704.
Fixes #57706.

Change-Id: I04fb7b9fc90677880b1ced4a4ad2a8867a3f5f86
Reviewed-on: https://go-review.googlesource.com/c/go/+/451816
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Bryan Mills <bcmills@google.com>
Run-TryBot: Than McIntosh <thanm@google.com>
Reviewed-by: Cherry Mui <cherryyz@google.com>
(cherry picked from commit 771a98d)
Reviewed-on: https://go-review.googlesource.com/c/go/+/461175
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Heschi Kreinick <heschi@google.com>
Reviewed-by: Carlos Amedee <carlos@golang.org>
@gopherbot
Copy link
Contributor Author

Closed by merging 071a1ed to release-branch.go1.19.

@golang golang locked and limited conversation to collaborators Jan 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CherryPickApproved Used during the release process for point releases FrozenDueToAge Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

3 participants